Page MenuHomePhabricator
Differential D11735

Introduce new JSI call to retrieve backup message for latest siwe backup
ClosedPublic
Actions

Authored by marcin on Apr 23 2024, 3:56 AM.
Tags
None
Referenced Files
F3358346: D11735.diff
Sun, Nov 24, 4:16 AM
F3357128: D11735.id39542.diff
Sat, Nov 23, 10:34 PM
Unknown Object (File)
Thu, Nov 21, 7:43 PM
Unknown Object (File)
Thu, Nov 21, 7:19 PM
Unknown Object (File)
Thu, Nov 21, 5:23 PM
Unknown Object (File)
Sun, Nov 3, 6:30 AM
Unknown Object (File)
Oct 14 2024, 6:26 PM
Unknown Object (File)
Oct 12 2024, 5:23 PM
View All 64 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
bartek
Commits
rCOMMdf80d4d44147: Introduce new JSI call to retrieve backup message for latest siwe backup
Summary

This differential introduces new JSI call to fetch latest backup id and associated backup message for SIWE user.

Test Plan
  1. Log in as SIWE user.
  2. In use-backu-client add call to this function after awaiting createNewBackup. Log the result.
  3. Ensure that the result logged is the same as backup message in dynamodb web viewer.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Apr 23 2024, 3:56 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 23 2024, 3:56 AM
marcin added a parent revision: D11734: Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse'.Apr 23 2024, 3:57 AM
Harbormaster completed remote builds in B28397: Diff 39392.Apr 23 2024, 4:12 AM
marcin requested review of this revision.Apr 23 2024, 4:12 AM
bartek requested changes to this revision.Apr 24 2024, 2:09 AM
bartek added inline comments.
native/schema/CommCoreModuleSchema.js
163 ↗(On Diff #39392)

The Rust retrieve_latest_siwe_backup_data() calls handle_string_result_as_callback but here you have Promise<void>

This revision now requires changes to proceed.Apr 24 2024, 2:09 AM
marcin updated this revision to Diff 39542.Apr 26 2024, 6:26 AM
  1. Rename msg_backup to siwe_backup_message
  2. Fix JSI type
Harbormaster completed remote builds in B28507: Diff 39542.Apr 26 2024, 7:00 AM
bartek accepted this revision.Apr 28 2024, 11:07 PM
This revision is now accepted and ready to land.Apr 28 2024, 11:07 PM
marcin updated this revision to Diff 40004.May 9 2024, 6:22 AM

Rebase before landig

marcin added a child revision: D11968: Bump staging backup service version.May 9 2024, 6:32 AM
Harbormaster completed remote builds in B28803: Diff 40004.May 9 2024, 6:53 AM
Closed by commit rCOMMdf80d4d44147: Introduce new JSI call to retrieve backup message for latest siwe backup (authored by marcin). · Explain WhyMay 9 2024, 7:00 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMdf80d4d44147: Introduce new JSI call to retrieve backup message for latest siwe backup.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
1 line
9 lines
_generated/
native_rust_library/
src/
69 lines
3 lines
schema/
1 line

Diff 40014

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/native_rust_library/src/backup.rs

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...