Page MenuHomePhabricator
Differential D11734

Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse'
AcceptedPublic
Actions

Authored by marcin on Tue, Apr 23, 3:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 1:09 PM
Unknown Object (File)
Wed, May 1, 6:51 PM
Unknown Object (File)
Wed, May 1, 10:02 AM
Unknown Object (File)
Tue, Apr 30, 3:38 PM
Unknown Object (File)
Mon, Apr 29, 7:43 PM
Unknown Object (File)
Sun, Apr 28, 4:17 PM
Unknown Object (File)
Fri, Apr 26, 3:54 PM
Unknown Object (File)
Tue, Apr 23, 9:18 PM
View All 10 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
bartek
Summary

This differential introduces backup message field to OrderedBackupItem so that backup message can be fetched from dynamodb.

Test Plan

For now ensure that backup functionality remains unbroken. Very next diff will enable testing with simple button click.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Tue, Apr 23, 3:51 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Apr 23, 3:51 AM
marcin added a parent revision: D11733: Update latest backup id search index to include 'msgBackup'.Tue, Apr 23, 3:52 AM
marcin edited the summary of this revision. (Show Details)
marcin added a child revision: D11735: Introduce new JSI call to retrieve backup message for latest siwe backup.Tue, Apr 23, 3:57 AM
Harbormaster completed remote builds in B28396: Diff 39391.Tue, Apr 23, 4:08 AM
marcin requested review of this revision.Tue, Apr 23, 4:08 AM
bartek accepted this revision.Wed, Apr 24, 2:04 AM

Logic looks good, just some code-style comments

services/backup/src/database/backup_item.rs
217–226 ↗(On Diff #39391)

Same comment as in https://phab.comm.dev/D11713#inline-70320 - this could be simplified

shared/comm-lib/src/backup/mod.rs
4–11 ↗(On Diff #39391)

We have a convention of preferring rename_all over field-level directives.
backupID is an exception because it'd be renamed to backupId (lowercase d).

This revision is now accepted and ready to land.Wed, Apr 24, 2:04 AM
marcin added a parent revision: D11781: Move MissingRegistrationDataHandler to NavigationHandler.Fri, Apr 26, 1:19 AM
marcin removed a parent revision: D11781: Move MissingRegistrationDataHandler to NavigationHandler.
marcin updated this revision to Diff 39541.Fri, Apr 26, 6:25 AM
  1. Rename msg_backup to siwe_backup_msg
  2. Simplify code.
Harbormaster completed remote builds in B28506: Diff 39541.Fri, Apr 26, 6:54 AM

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
src/
2 lines
services/
backup/
src/
database/
5 lines
http/
handlers/
1 line
shared/
comm-lib/
src/
backup/
3 lines

Diff 39541

View Options

native/native_rust_library/src/backup.rs

Loading...
View Options

services/backup/src/database/backup_item.rs

Loading...
View Options

services/backup/src/http/handlers/backup.rs

Loading...
View Options

shared/comm-lib/src/backup/mod.rs

Loading...