Page MenuHomePhabricator
Differential D11781

Move MissingRegistrationDataHandler to NavigationHandler
ClosedPublic
Actions

Authored by marcin on Thu, Apr 25, 8:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 5:45 PM
Unknown Object (File)
Thu, May 2, 3:56 PM
Unknown Object (File)
Wed, May 1, 8:31 PM
Unknown Object (File)
Wed, May 1, 11:15 AM
Unknown Object (File)
Tue, Apr 30, 6:44 PM
Unknown Object (File)
Mon, Apr 29, 1:14 PM
Unknown Object (File)
Mon, Apr 29, 9:18 AM
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM2c232c7e3138: Move MissingRegistrationDataHandler to NavigationHandler
Summary

This differential solves the following Linear issue: https://linear.app/comm/issue/ENG-7967/navigation-error.

Test Plan
  1. Repeat reproduction steps without this diff. Ensure error occurs.
  2. Repeat reproduction steps with this diff. Ensure everything works.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Thu, Apr 25, 8:20 AM
Herald added a subscriber: ashoat. · View Herald TranscriptThu, Apr 25, 8:20 AM
Harbormaster completed remote builds in B28468: Diff 39491.Thu, Apr 25, 8:37 AM
marcin requested review of this revision.Thu, Apr 25, 8:37 AM
marcin added a child revision: D11734: Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse'.Fri, Apr 26, 1:19 AM
marcin edited child revisions, added: D11782: Let the user skip backup message generation and record it in alert store; removed: D11734: Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse'.
marcin added a parent revision: D11645: Force already logged in ETH users to create and sign backup message.
marcin removed a parent revision: D11645: Force already logged in ETH users to create and sign backup message.
marcin added a parent revision: D11794: [native] Don't refetch nonce after SIWE is complete.
tomek accepted this revision.Fri, Apr 26, 5:19 AM
This revision is now accepted and ready to land.Fri, Apr 26, 5:19 AM
marcin updated this revision to Diff 39638.Mon, Apr 29, 3:35 AM

Rebase before landing

Harbormaster completed remote builds in B28565: Diff 39638.Mon, Apr 29, 3:51 AM
marcin updated this revision to Diff 39643.Mon, Apr 29, 4:15 AM

Rebase before landing

Harbormaster completed remote builds in B28569: Diff 39643.Mon, Apr 29, 4:32 AM
Closed by commit rCOMM2c232c7e3138: Move MissingRegistrationDataHandler to NavigationHandler (authored by marcin). · Explain WhyMon, Apr 29, 4:55 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM2c232c7e3138: Move MissingRegistrationDataHandler to NavigationHandler.

Revision Contents
Changeset List

PathSize
native/
navigation/
2 lines
2 lines

Diff 39647

View Options

native/navigation/navigation-handler.react.js

Loading...
View Options

native/root.react.js

Loading...