This differential introduces new field - msg_backup to BackupItem so that backup data can be persisted in dynamodb with respective backup message.
Details
Details
- Reviewers
bartek kamil - Commits
- rCOMM70288a9803d4: Introduce msg_backup field to BackupItem
- Locally trigger backup upload from password user.
- Ensure that it works and using web inspector of dynamodb see that there is a new column with undefined value.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Mostly looks good. Left a few suggestions
| services/backup/src/constants.rs | ||
|---|---|---|
| 30 ↗ | (On Diff #39356) | I'd prefer naming this siwe_backup_message / siweBackupMessage / SIWE_BACKUP_MSG |
| services/backup/src/database/backup_item.rs | ||
| 160–168 ↗ | (On Diff #39356) | This should work too. Or even simpler: // top of the file use comm_lib::database::AttributeExtractor; // then you can let msg_backup: Option<String> = value.take_attr(backup_table::attr::MSG_BACKUP)?; |
| services/backup/src/http/handlers/backup.rs | ||
| 80 ↗ | (On Diff #39356) | Shouldn't we catch errors the same way we're doing e.g. for the "attachments" text field above? |
| services/backup/src/constants.rs | ||
|---|---|---|
| 30 ↗ | (On Diff #39356) | agree with that |