Details

Reviewers

bartek
kamil

Commits

rCOMM70288a9803d4: Introduce msg_backup field to BackupItem

Summary

This differential introduces new field - msg_backup to BackupItem so that backup data can be persisted in dynamodb with respective backup message.

Test Plan

Locally trigger backup upload from password user.
Ensure that it works and using web inspector of dynamodb see that there is a new column with undefined value.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Apr 22 2024, 11:17 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 22 2024, 11:17 AM

marcin added a parent revision: D11645: Force already logged in ETH users to create and sign backup message.Apr 22 2024, 11:17 AM

marcin added a child revision: D11714: Introduce function to get path to a file to temporarily save backup message.Apr 22 2024, 11:21 AM

Harbormaster completed remote builds in B28360: Diff 39350.Apr 22 2024, 11:32 AM

marcin requested review of this revision.Apr 22 2024, 11:32 AM

Remove empty line

Harbormaster completed remote builds in B28366: Diff 39356.Apr 22 2024, 11:56 AM

Mostly looks good. Left a few suggestions

services/backup/src/constants.rs
30	I'd prefer naming this `siwe_backup_message` / `siweBackupMessage` / `SIWE_BACKUP_MSG`
services/backup/src/database/backup_item.rs
160–168	This should work too. Or even simpler: // top of the file use comm_lib::database::AttributeExtractor; // then you can let msg_backup: Option<String> = value.take_attr(backup_table::attr::MSG_BACKUP)?;
services/backup/src/http/handlers/backup.rs
80	Shouldn't we catch errors the same way we're doing e.g. for the `"attachments"` text field above?