Page MenuHomePhabricator
Differential D11792

[lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook
ClosedPublic
Actions

Authored by atul on Apr 25 2024, 2:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 13, 11:44 AM
Unknown Object (File)
Thu, Mar 13, 11:44 AM
Unknown Object (File)
Thu, Mar 13, 11:44 AM
Unknown Object (File)
Thu, Mar 13, 11:44 AM
Unknown Object (File)
Thu, Mar 13, 11:44 AM
Unknown Object (File)
Mon, Mar 10, 8:52 AM
Unknown Object (File)
Feb 9 2025, 4:26 AM
Unknown Object (File)
Feb 2 2025, 12:48 AM
View All 70 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM64ad347fd686: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook
Summary

Part of deprecating use of threadHasPermission on client.

Depends on D11791

Test Plan

flow + close reading

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Apr 25 2024, 2:03 PM
Harbormaster completed remote builds in B28488: Diff 39518.Apr 25 2024, 2:30 PM
atul requested review of this revision.Apr 25 2024, 2:30 PM
ashoat accepted this revision.Apr 25 2024, 2:32 PM
ashoat added inline comments.
lib/hooks/promote-sidebar.react.js
34–37 ↗(On Diff #39518)

Might as well combine all of these now

This revision is now accepted and ready to land.Apr 25 2024, 2:32 PM
atul added inline comments.Apr 26 2024, 11:47 AM
lib/hooks/promote-sidebar.react.js
34–37 ↗(On Diff #39518)

Ah yeah that makes way more sense, will update

atul updated this revision to Diff 39587.Apr 26 2024, 12:08 PM

consolidate conditional

This revision was landed with ongoing or failed builds.Apr 26 2024, 12:12 PM
Closed by commit rCOMM64ad347fd686: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM64ad347fd686: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook.
Harbormaster completed remote builds in B28532: Diff 39587.Apr 26 2024, 12:31 PM
atul added a child revision: D11816: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`.Apr 26 2024, 12:49 PM

Revision Contents
Changeset List

PathSize
lib/
hooks/
23 lines
web/
modals/
threads/
notifications/
12 lines

Diff 39590

View Options

lib/hooks/promote-sidebar.react.js

Show All 24 Lines "devDependencies": {
"@babel/cli": "^7.23.4", "@babel/cli": "^7.23.4",
"@babel/core": "^7.23.7", "@babel/core": "^7.23.7",
"@babel/node": "^7.22.19", "@babel/node": "^7.22.19",
"@babel/plugin-syntax-dynamic-import": "^7.8.3", "@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-class-properties": "^7.23.3", "@babel/plugin-transform-class-properties": "^7.23.3",
"@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4", "@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4",
"@babel/plugin-transform-object-rest-spread": "^7.23.4", "@babel/plugin-transform-object-rest-spread": "^7.23.4",
"@babel/plugin-transform-optional-chaining": "^7.23.4", "@babel/plugin-transform-optional-chaining": "^7.23.4",
"@babel/plugin-transform-private-methods": "^7.24.1",
"@babel/plugin-transform-runtime": "^7.23.7", "@babel/plugin-transform-runtime": "^7.23.7",
"@babel/preset-env": "^7.23.7", "@babel/preset-env": "^7.23.7",
"@babel/preset-flow": "^7.23.3", "@babel/preset-flow": "^7.23.3",
"@babel/preset-react": "^7.23.3", "@babel/preset-react": "^7.23.3",
"babel-jest": "^29.7.0", "babel-jest": "^29.7.0",
"babel-plugin-transform-import-meta": "2.2.1", "babel-plugin-transform-import-meta": "2.2.1",
"chokidar-cli": "^2.1.0", "chokidar-cli": "^2.1.0",
"concurrently": "^5.3.0", "concurrently": "^5.3.0",
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines
View Options

web/modals/threads/notifications/notifications-modal.react.js

Show All 24 Lines "devDependencies": {
"@babel/cli": "^7.23.4", "@babel/cli": "^7.23.4",
"@babel/core": "^7.23.7", "@babel/core": "^7.23.7",
"@babel/node": "^7.22.19", "@babel/node": "^7.22.19",
"@babel/plugin-syntax-dynamic-import": "^7.8.3", "@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-class-properties": "^7.23.3", "@babel/plugin-transform-class-properties": "^7.23.3",
"@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4", "@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4",
"@babel/plugin-transform-object-rest-spread": "^7.23.4", "@babel/plugin-transform-object-rest-spread": "^7.23.4",
"@babel/plugin-transform-optional-chaining": "^7.23.4", "@babel/plugin-transform-optional-chaining": "^7.23.4",
"@babel/plugin-transform-private-methods": "^7.24.1",
"@babel/plugin-transform-runtime": "^7.23.7", "@babel/plugin-transform-runtime": "^7.23.7",
"@babel/preset-env": "^7.23.7", "@babel/preset-env": "^7.23.7",
"@babel/preset-flow": "^7.23.3", "@babel/preset-flow": "^7.23.3",
"@babel/preset-react": "^7.23.3", "@babel/preset-react": "^7.23.3",
"babel-jest": "^29.7.0", "babel-jest": "^29.7.0",
"babel-plugin-transform-import-meta": "2.2.1", "babel-plugin-transform-import-meta": "2.2.1",
"chokidar-cli": "^2.1.0", "chokidar-cli": "^2.1.0",
"concurrently": "^5.3.0", "concurrently": "^5.3.0",
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines