Page MenuHomePhabricator

atul (Atul)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Dec 29 2020, 8:08 PM (171 w, 4 d)
Roles
Administrator

FS_JGHeXwAEZWmZ.jpg (700×500 px, 54 KB)

FS_JGHgXwAAsCf2.jpg (700×500 px, 46 KB)

FS_JGHdWYAEPW_t.jpg (700×500 px, 54 KB)

FS_JGHdXwAMHbdF.jpg (700×500 px, 53 KB)

Recent Activity

Fri, Apr 12

atul published D11653: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromClientDB` to handle `farcaster_mutual` for review.
Fri, Apr 12, 1:12 PM
atul published D11652: [lib] Update `UPDATE_RELATIONSHIP.rawMessageInfoFromServerDB` to handle `farcaster_mutual` for review.
Fri, Apr 12, 12:59 PM
atul updated the test plan for D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.
Fri, Apr 12, 12:27 PM
atul published D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual` for review.
Fri, Apr 12, 12:26 PM
atul requested review of D11650: [lib] Split `UpdateRelationshipMessageInfo` into `Update[Traditional/Farcaster]RelationshipMessageInfo`.
Fri, Apr 12, 12:03 PM

Thu, Apr 11

atul requested review of D11642: [lib] Split `rawUpdateRelationshipMessageInfoValidator` into `rawUpdate[Traditional/Farcaster]RelationshipMessageInfoValidator`.
Thu, Apr 11, 8:58 PM
atul published D11641: [lib] Split `UpdateRelationshipMessageData` into `UpdateTraditionalMessageData` and `UpdateFarcasterMessageData` for review.
Thu, Apr 11, 8:06 PM
atul accepted D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Thu, Apr 11, 6:53 PM
atul accepted D11637: Implement JSI getter and setter for siwe backup secrets.

Looks good. (There shouldn't be any WASM stuff that needs to be generated for the non-DB code here right?)

Thu, Apr 11, 6:42 PM
atul added a comment to D11636: Implement screen to create backup mesage and its signature.

Would also be good to include some screenshots of what it looks like in Test Plan so reviewers can side-by-side with the Figma designs

Thu, Apr 11, 6:38 PM
atul added a reviewer for D11636: Implement screen to create backup mesage and its signature: ginsu.
Thu, Apr 11, 6:38 PM
atul accepted D11636: Implement screen to create backup mesage and its signature.
Thu, Apr 11, 6:37 PM
atul accepted D11635: Handle backup message type with different user texts in siwe.reac.js.
Thu, Apr 11, 6:25 PM
atul accepted D11628: [lib] Make synced metadata name field an enum.
Thu, Apr 11, 6:21 PM
atul accepted D11627: Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear.
Thu, Apr 11, 6:18 PM
atul accepted D11622: [lib] Make `lastPruned` and `lastNavigatedTo` type optional for thread activity entry.
Thu, Apr 11, 6:18 PM
atul accepted D11618: [native][web] Read thread activity entries from SQLite on app start.
Thu, Apr 11, 6:18 PM
atul accepted D11616: [native] migrate threadActivityStore to SQLite.
Thu, Apr 11, 6:16 PM
atul accepted D11634: Introduce user texts for siwe backup message creation.
Thu, Apr 11, 12:23 PM
atul accepted D11633: Introduce SIWE message types.

Looks clean!

Thu, Apr 11, 12:15 PM
atul accepted D11640: [lib] rewrite integrityInfos ThreadHashes.
Thu, Apr 11, 12:04 PM

Wed, Apr 10

atul requested review of D11624: [lib] Fix `farcasterRelationshipRequestValidator`.
Wed, Apr 10, 1:25 PM
atul updated the diff for D11612: [lib] Update `updateRelationshipInputValidator` to be union of `[traditional/farcaster]RelationshipRequestValidator`.

rebase

Wed, Apr 10, 12:22 PM
atul updated the diff for D11611: [keyserver] Update `updateRelationshipsResponder` to handle `RelationshipRequest`.

rebasing

Wed, Apr 10, 12:22 PM
atul updated the diff for D11610: [keyserver] Narrow `updateRelationshipInputValidator` to exclude `farcaster` action.

rebasing

Wed, Apr 10, 12:22 PM
atul updated the diff for D11609: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action.

address @tomek's feedback

Wed, Apr 10, 12:20 PM
atul added inline comments to D11609: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action.
Wed, Apr 10, 12:20 PM
atul attached a referenced file: F1510994: 3cf86a.png.
Wed, Apr 10, 12:18 PM
atul updated the diff for D11607: [keyserver] Update `createPersonalThreads` to support both `[Traditional/Farcaster]RelationshipRequest`.

rebasing stack

Wed, Apr 10, 12:18 PM
atul added inline comments to D11607: [keyserver] Update `createPersonalThreads` to support both `[Traditional/Farcaster]RelationshipRequest`.
Wed, Apr 10, 12:18 PM
atul updated the diff for D11606: [lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest` with `userIDsToFID`.

address @ashoat's feedback

Wed, Apr 10, 12:14 PM
atul added inline comments to D11606: [lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest` with `userIDsToFID`.
Wed, Apr 10, 12:10 PM
atul updated the diff for D11606: [lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest` with `userIDsToFID`.

address @tomek's feedback

Wed, Apr 10, 12:06 PM
atul closed D11605: [lib] Re-introduce `RelationshipRequest` and replace `TraditionalRelationshipRequest` where simple.
Wed, Apr 10, 11:55 AM
atul committed rCOMMeef5dc5615bc: [lib] Re-introduce `RelationshipRequest` and replace… (authored by atul).
[lib] Re-introduce `RelationshipRequest` and replace…
Wed, Apr 10, 11:54 AM
atul updated the diff for D11605: [lib] Re-introduce `RelationshipRequest` and replace `TraditionalRelationshipRequest` where simple.

land

Wed, Apr 10, 11:54 AM
atul closed D11603: [lib] Rename `sansFarcaster` variable names and types to `Traditional*`.
Wed, Apr 10, 11:51 AM
atul committed rCOMM5f8a4e609540: [lib] Rename `sansFarcaster` variable names and types to `Traditional*` (authored by atul).
[lib] Rename `sansFarcaster` variable names and types to `Traditional*`
Wed, Apr 10, 11:51 AM
atul updated the diff for D11603: [lib] Rename `sansFarcaster` variable names and types to `Traditional*`.

land

Wed, Apr 10, 11:39 AM
atul attached a referenced file: F1510592: fbb9f4.png.
Wed, Apr 10, 11:36 AM
atul added a comment to D11622: [lib] Make `lastPruned` and `lastNavigatedTo` type optional for thread activity entry.

As discussed offline it might make sense to do something like

Wed, Apr 10, 11:35 AM
atul closed D11602: [lib] Rename `RelationshipRequest` to `TraditionalRelationshipRequest`.
Wed, Apr 10, 11:28 AM
atul committed rCOMMc18881ba3684: [lib] Rename `RelationshipRequest` to `TraditionalRelationshipRequest` (authored by atul).
[lib] Rename `RelationshipRequest` to `TraditionalRelationshipRequest`
Wed, Apr 10, 11:28 AM
atul updated the diff for D11602: [lib] Rename `RelationshipRequest` to `TraditionalRelationshipRequest`.

land

Wed, Apr 10, 11:27 AM
atul accepted D11601: [native/web] introduce migration to update notifPermissionAlertInfo to alertStore in redux.

jk, you already handled this in stack

Wed, Apr 10, 10:43 AM
atul requested changes to D11601: [native/web] introduce migration to update notifPermissionAlertInfo to alertStore in redux.

Might be missing something, but don't we also need to update default states? For example in defaultWebState?

Wed, Apr 10, 10:41 AM
atul accepted D11600: [lib/native/web] refactor recordNotifPermissionAlertActionType to recordAlertActionType.
Wed, Apr 10, 10:39 AM
atul accepted D11599: [lib/native/web] move recordNotifPermissionAlertActionType into seperate actions file.
Wed, Apr 10, 10:05 AM
atul accepted D11621: [native] fix copy in FarcasterPrompt.
Wed, Apr 10, 10:03 AM
atul requested review of D11611: [keyserver] Update `updateRelationshipsResponder` to handle `RelationshipRequest`.
Wed, Apr 10, 9:54 AM
atul requested review of D11612: [lib] Update `updateRelationshipInputValidator` to be union of `[traditional/farcaster]RelationshipRequestValidator`.
Wed, Apr 10, 8:10 AM
atul requested review of D11610: [keyserver] Narrow `updateRelationshipInputValidator` to exclude `farcaster` action.
Wed, Apr 10, 8:09 AM

Tue, Apr 9

atul accepted D11598: [native] handle successful connection from connect farcaster bottom sheet.
Tue, Apr 9, 10:24 PM
atul accepted D11597: [native] flip farcaster prompt based on fid prop instead of context.
Tue, Apr 9, 10:23 PM
atul requested review of D11609: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action.
Tue, Apr 9, 9:57 PM
atul requested review of D11607: [keyserver] Update `createPersonalThreads` to support both `[Traditional/Farcaster]RelationshipRequest`.
Tue, Apr 9, 9:38 PM
atul requested review of D11606: [lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest` with `userIDsToFID`.
Tue, Apr 9, 9:06 PM
atul requested review of D11605: [lib] Re-introduce `RelationshipRequest` and replace `TraditionalRelationshipRequest` where simple.
Tue, Apr 9, 8:23 PM
atul requested review of D11603: [lib] Rename `sansFarcaster` variable names and types to `Traditional*`.
Tue, Apr 9, 6:59 PM
atul requested review of D11602: [lib] Rename `RelationshipRequest` to `TraditionalRelationshipRequest`.
Tue, Apr 9, 5:11 PM
atul closed D11593: [lib] Introduce `FarcasterRelationshipRequest`, validators, and unit tests.
Tue, Apr 9, 4:49 PM
atul committed rCOMMbff93822188e: [lib] Introduce `FarcasterRelationshipRequest`, validators, and unit tests (authored by atul).
[lib] Introduce `FarcasterRelationshipRequest`, validators, and unit tests
Tue, Apr 9, 4:49 PM
atul added inline comments to D11593: [lib] Introduce `FarcasterRelationshipRequest`, validators, and unit tests.
Tue, Apr 9, 10:23 AM
atul updated the diff for D11593: [lib] Introduce `FarcasterRelationshipRequest`, validators, and unit tests.

make RelationshipRequest and FarcasterRelationshipRequest readonly

Tue, Apr 9, 10:14 AM
atul added inline comments to D11593: [lib] Introduce `FarcasterRelationshipRequest`, validators, and unit tests.
Tue, Apr 9, 10:12 AM
atul closed D11592: [lib] Split `RelationshipAction` and `RelationshipActionSansFarcaster`.
Tue, Apr 9, 10:11 AM
atul committed rCOMM0ea301c36f48: [lib] Split `RelationshipAction` and `RelationshipActionSansFarcaster` (authored by atul).
[lib] Split `RelationshipAction` and `RelationshipActionSansFarcaster`
Tue, Apr 9, 10:11 AM
atul updated the diff for D11592: [lib] Split `RelationshipAction` and `RelationshipActionSansFarcaster`.

land

Tue, Apr 9, 10:08 AM
atul planned changes to D11593: [lib] Introduce `FarcasterRelationshipRequest`, validators, and unit tests.

read only

Tue, Apr 9, 6:07 AM

Mon, Apr 8

atul published D11593: [lib] Introduce `FarcasterRelationshipRequest`, validators, and unit tests for review.
Mon, Apr 8, 1:58 PM
atul requested review of D11592: [lib] Split `RelationshipAction` and `RelationshipActionSansFarcaster`.
Mon, Apr 8, 1:32 PM
atul accepted D11581: [sqlite] Implement C++ methods for thread activity.

Looks good, thanks for adding unit tests... definitely improves confidence in changes

Mon, Apr 8, 10:30 AM
atul accepted D11579: [lib] return ops from thread activity reducer.
Mon, Apr 8, 10:28 AM
atul accepted D11578: [lib] refactor thread activity reducer to use sqlite operations.
Mon, Apr 8, 10:28 AM
atul accepted D11576: [native/sqlite] Create thread activity table in sqlite.

Would be good to include both create_schema and migration flow in Test Plan

Mon, Apr 8, 10:27 AM
atul accepted D11575: [lib] Add thread activity store ops.
Mon, Apr 8, 10:26 AM
atul added inline comments to D8665: Implement native iOS code to fetch data from blob service and keyserver code to upload notification payload if it exceeds APNs limits.
Mon, Apr 8, 9:20 AM
atul accepted D11569: [lib/native/web] introduce CONNECT_FARCASTER alert type.
Mon, Apr 8, 6:29 AM
atul accepted D11568: [lib/native/web] refactor notif permission alert info reducer.
Mon, Apr 8, 6:27 AM
atul added inline comments to D11567: [lib/native/web] introduce alert types.
Mon, Apr 8, 6:25 AM
atul accepted D11567: [lib/native/web] introduce alert types.
Mon, Apr 8, 6:18 AM
atul closed D11459: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`.
Mon, Apr 8, 6:17 AM
atul committed rCOMM88077c9da4b0: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo` (authored by atul).
[lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`
Mon, Apr 8, 6:17 AM
atul updated the diff for D11459: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`.

land

Mon, Apr 8, 6:16 AM

Fri, Apr 5

atul updated the diff for D11459: [lib] Implement `UpdateRelationshipSpec.shimUnsupportedMessageInfo`.

address feedback + land

Fri, Apr 5, 5:45 PM
atul closed D11458: [lib] Handle `farcaster_mutual` case in `robotext/notificationTexts`.
Fri, Apr 5, 4:41 PM
atul committed rCOMM444cce2542c3: [lib] Handle `farcaster_mutual` case in `robotext/notificationTexts` (authored by atul).
[lib] Handle `farcaster_mutual` case in `robotext/notificationTexts`
Fri, Apr 5, 4:41 PM
atul updated the diff for D11458: [lib] Handle `farcaster_mutual` case in `robotext/notificationTexts`.

address feedback

Fri, Apr 5, 4:38 PM

Thu, Apr 4

atul accepted D11528: [lib] Introduce aux user store reducer and action types.
Thu, Apr 4, 1:45 PM
atul accepted D11561: [native] calculate snap points for connect farcaster bottom sheet.
Thu, Apr 4, 1:44 PM
atul accepted D11560: [native] implement connect farcaster bottom sheet ui.
Thu, Apr 4, 1:12 PM
atul accepted D11559: [native] introduce barebones connect farcaster bottom sheet to root navigator.
Thu, Apr 4, 1:10 PM
atul closed D11457: [lib] Fix `UpdateRelationshipMessageSpec.validator`.
Thu, Apr 4, 1:01 PM
atul committed rCOMM66a4e39bb7bf: [lib] Fix `UpdateRelationshipMessageSpec.validator` (authored by atul).
[lib] Fix `UpdateRelationshipMessageSpec.validator`
Thu, Apr 4, 1:01 PM
atul closed D11455: [lib] Update `rawMessageInfoFromClientDB` to support `RawUpdateRelationshipMessageInfo`.
Thu, Apr 4, 1:01 PM
atul committed rCOMMc9b68963398a: [lib] Update `rawMessageInfoFromClientDB` to support… (authored by atul).
[lib] Update `rawMessageInfoFromClientDB` to support…
Thu, Apr 4, 1:01 PM
atul closed D11452: [lib] Partially update `UpdateRelationshipMessageSpec` to support updated `UpdateRelationship` message type.
Thu, Apr 4, 1:01 PM
atul committed rCOMM99c020412fb6: [lib] Partially update `UpdateRelationshipMessageSpec` to support updated… (authored by atul).
[lib] Partially update `UpdateRelationshipMessageSpec` to support updated…
Thu, Apr 4, 1:00 PM
atul closed D11443: [lib] Update `messageContentFor[Client/Server]DB` to handle `UpdateRelationship`.
Thu, Apr 4, 1:00 PM
atul committed rCOMM6c7bca7377b6: [lib] Update `messageContentFor[Client/Server]DB` to handle `UpdateRelationship` (authored by atul).
[lib] Update `messageContentFor[Client/Server]DB` to handle `UpdateRelationship`
Thu, Apr 4, 1:00 PM