User Details
User Details
- User Since
- Dec 29 2020, 8:08 PM (142 w, 3 d)
- Roles
- Administrator
Thu, Sep 21
Thu, Sep 21
atul added inline comments to D9262: [lib] Add `ThreadActivityStore` to Redux.
atul updated the diff for D9262: [lib] Add `ThreadActivityStore` to Redux.
address feedback
atul published D9262: [lib] Add `ThreadActivityStore` to Redux for review.
atul updated the diff for D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma.
rebase
Wed, Sep 20
Wed, Sep 20
atul committed rCOMM1cf8c3d6ba22: Revert "[native] Temporary changes for staff release" (authored by atul).
Revert "[native] Temporary changes for staff release"
[native] `codeVersion` -> 264
[native] Temporary changes for staff release
[native] `codeVersion` -> 263
atul added reviewers for D9235: [lib] introduce createPendingPersonalThread function: ashoat, tomek.
atul added a comment to D9251: [keyserver] Remove unused exports in message-fetchers.js.
Looks good, left comments but they're purely personal preference so feel free to land as is
atul added inline comments to D9248: [native] Fix rescinds and badge-only notifs on iOS.
atul added a comment to D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma.
Was there maybe some corresponding keyserver change that needed to be deployed before this release or something?
atul published D9248: [native] Fix rescinds and badge-only notifs on iOS for review.
atul committed rCOMM125b29a6d73e: [iOS] Add `withEnableSampleProfiling(true)` to `makeRuntimeConfig` (authored by atul).
[iOS] Add `withEnableSampleProfiling(true)` to `makeRuntimeConfig`
atul updated the diff for D9233: [iOS] Add `withEnableSampleProfiling(true)` to `makeRuntimeConfig`.
toggle withEnableSampleProfiling on DEBUG
atul added a comment to D9233: [iOS] Add `withEnableSampleProfiling(true)` to `makeRuntimeConfig`.
atul added a comment to D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma.
Tue, Sep 19
Tue, Sep 19
atul committed rCOMMebb529b9ae7b: Revert "[native] Temporary changes for staff release" (authored by atul).
Revert "[native] Temporary changes for staff release"
[native] `codeVersion` -> 262
[native] Temporary changes for staff release
[native] `codeVersion` -> 261
atul committed rCOMMbb73b304a2e6: Bump webpki from 0.22.0 to 0.22.1 in /services/feature-flags (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump webpki from 0.22.0 to 0.22.1 in /services/feature-flags
atul committed rCOMMeb3e37ff76d6: Bump webpki from 0.22.0 to 0.22.1 in /services/backup (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump webpki from 0.22.0 to 0.22.1 in /services/backup
atul committed rCOMM5b994dbc623d: Bump webpki from 0.22.0 to 0.22.1 in /services/comm-services-lib (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump webpki from 0.22.0 to 0.22.1 in /services/comm-services-lib
atul committed rCOMM88f1887d900f: Bump webpki from 0.22.0 to 0.22.1 in /services/blob (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump webpki from 0.22.0 to 0.22.1 in /services/blob
atul committed rCOMM92f52ec682b5: Bump webpki from 0.22.0 to 0.22.1 in /services/tunnelbroker (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump webpki from 0.22.0 to 0.22.1 in /services/tunnelbroker
atul committed rCOMM50c9eb9535d9: Bump webpki from 0.22.0 to 0.22.1 in /services/reports (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump webpki from 0.22.0 to 0.22.1 in /services/reports
atul committed rCOMMe52697f28480: Bump webpki from 0.22.0 to 0.22.1 in /services/commtest (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump webpki from 0.22.0 to 0.22.1 in /services/commtest
atul committed rCOMMd2f9770dca2b: Bump electron from 25.3.0 to 25.8.1 (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump electron from 25.3.0 to 25.8.1
atul committed rCOMM55f60fee8c1a: Bump webpki from 0.22.0 to 0.22.1 in /services/identity (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump webpki from 0.22.0 to 0.22.1 in /services/identity
atul committed rCOMMb2deff08ea76: Bump apollo-server-core from 3.11.1 to 3.12.1 (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump apollo-server-core from 3.11.1 to 3.12.1
atul committed rCOMMcbe88c3eecd2: Bump rustls-webpki from 0.101.3 to 0.101.4 in /services/identity (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump rustls-webpki from 0.101.3 to 0.101.4 in /services/identity
atul committed rCOMM2d17a1619894: Bump activesupport from 6.1.7.3 to 6.1.7.6 in /native (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump activesupport from 6.1.7.3 to 6.1.7.6 in /native
atul committed rCOMM3796da87658b: Bump rustls-webpki in /keyserver/addons/rust-node-addon (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump rustls-webpki in /keyserver/addons/rust-node-addon
atul committed rCOMMe3acc63103fd: Bump rustls-webpki from 0.101.3 to 0.101.4 in /shared/grpc_clients (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump rustls-webpki from 0.101.3 to 0.101.4 in /shared/grpc_clients
atul committed rCOMMacd5e89c8ec8: Bump rustls-webpki from 0.100.1 to 0.100.2 in /services/tunnelbroker (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump rustls-webpki from 0.100.1 to 0.100.2 in /services/tunnelbroker
atul committed rCOMMf30690b547dd: [iOS] Set `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` flag to unblock… (authored by atul).
[iOS] Set `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` flag to unblock…
atul updated the diff for D9228: [iOS] Set `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` flag to unblock iOS build.
rebase and land
atul added a comment to D9233: [iOS] Add `withEnableSampleProfiling(true)` to `makeRuntimeConfig`.
(I think the profiler gets disabled on prod builds, I'll do a little more research)
atul added a comment to D9233: [iOS] Add `withEnableSampleProfiling(true)` to `makeRuntimeConfig`.
atul published D9233: [iOS] Add `withEnableSampleProfiling(true)` to `makeRuntimeConfig` for review.
atul published D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma for review.
@tomek Sorry, you’re totally right that this is useless. I tested performance with/without this diff in isolation and there was no difference.
Mon, Sep 18
Mon, Sep 18
atul committed rCOMM84b611f0316c: [native] Remove `boundChatListData` from `useThreadListSearch` dep list (authored by atul).
[native] Remove `boundChatListData` from `useThreadListSearch` dep list
atul committed rCOMM74c8424f88cc: [native] Consume `useThreadListSearch` in `ChatThreadList` (authored by atul).
[native] Consume `useThreadListSearch` in `ChatThreadList`
atul updated the diff for D9215: [native] Remove `boundChatListData` from `useThreadListSearch` dep list.
rebase around D9211 to land
atul updated the diff for D9212: [native] Consume `useThreadListSearch` in `ChatThreadList`.
rebase around D9211 to land
atul committed rCOMM90f88e7b7c08: [native] Add some basic memoization to `ChatThreadListSearch` (authored by atul).
[native] Add some basic memoization to `ChatThreadListSearch`
atul updated the diff for D9210: [native] Add some basic memoization to `ChatThreadListSearch`.
land
atul committed rCOMMb2d1a3f8e4f9: [native] Forward `searchInputRef` from `ChatThreadList` to… (authored by atul).
[native] Forward `searchInputRef` from `ChatThreadList` to…
atul committed rCOMM07a97b02cad6: [native] Move Reanimated code from `ChatThreadList` to `ChatThreadListSearch` (authored by atul).
[native] Move Reanimated code from `ChatThreadList` to `ChatThreadListSearch`
atul committed rCOMMa0967233d046: [native] Remove `renderSearch` in `ChatThreadList` and inline… (authored by atul).
[native] Remove `renderSearch` in `ChatThreadList` and inline…
atul committed rCOMMe9e030d6493b: [native] Move rest of Search views to `ChatThreadListSearch` (authored by atul).
[native] Move rest of Search views to `ChatThreadListSearch`
atul updated the diff for D9209: [native] Forward `searchInputRef` from `ChatThreadList` to `ChatThreadListSearch`.
merge conflicts
atul updated the diff for D9215: [native] Remove `boundChatListData` from `useThreadListSearch` dep list.
rebase
atul updated the diff for D9212: [native] Consume `useThreadListSearch` in `ChatThreadList`.
rebase
atul updated the diff for D9211: [native] Memoize `flatList` in `ChatThreadList`.
rebase
atul updated the diff for D9210: [native] Add some basic memoization to `ChatThreadListSearch`.
rebase
atul updated the diff for D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.
rebase
atul added inline comments to D9209: [native] Forward `searchInputRef` from `ChatThreadList` to `ChatThreadListSearch`.
atul updated the diff for D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.
address feedback: early-return
atul added inline comments to D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.
atul updated the diff for D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.
rebase
atul updated the diff for D9207: [native] Move Reanimated code from `ChatThreadList` to `ChatThreadListSearch`.
rebase
atul added inline comments to D9207: [native] Move Reanimated code from `ChatThreadList` to `ChatThreadListSearch`.
atul updated the diff for D9206: [native] Move rest of Search views to `ChatThreadListSearch`.
rebase after resolve merge conflict
atul added inline comments to D9206: [native] Move rest of Search views to `ChatThreadListSearch`.
atul requested review of D9211: [native] Memoize `flatList` in `ChatThreadList`.
Sun, Sep 17
Sun, Sep 17
atul added inline comments to D9206: [native] Move rest of Search views to `ChatThreadListSearch`.
atul committed rCOMMaa58fb3d076f: [native] Introduce naive `ChatThreadListSearch` component (authored by atul).
[native] Introduce naive `ChatThreadListSearch` component
atul updated the diff for D9205: [native] Introduce naive `ChatThreadListSearch` component.
type fn return values as mixed
atul added inline comments to D9205: [native] Introduce naive `ChatThreadListSearch` component.
[native] Memoize `ConnectedRemoteImage`
[native] Memoize `ThreadAncestorsLabel`
atul updated the diff for D9214: [native] Memoize `ConnectedRemoteImage`.
rebase and land