rebase and land

rebase and land

address feedback

rebase and land

Had to change text encoding in Phabricator to "see the difference," but looks good.

Don't think the plus-circle icon makes sense for "Change Role," but defer to @ted on that.

Label having a bg prop that expects a CSS variable is a weird API. Is there a way we can introduce a variant prop to Label instead and style accordingly within?

Accepting, but please take a look at the trailing space

whoa this looks smooth, first rotation animation?

rebase and alnd

Code change looks fine

I could alternatively define roleName outside the scope of this memo and then put it in the dependency array

Looks good, think we can skip classNames altogether for headingClassName though.

Looks like a straightforward move

Looks good overall, might be worth trying box-shadow instead of blur if it's easy... but feel free to land as-is if it takes too long to investigate + achieve the same effect

Maybe glow instead of blur? Kind of associate blur with being some sort of "filter" "above" some other content

Looks good

addressed feedback

rebase before addressing feedback

rebase and land

In D8056#239068, @ashoat wrote:

In D8056#239034, @atul wrote:

I can try to pull something generic out of CommunityCreationMembers and see if it can be used in other components where we have TagInput and UserList (ComposeSubchannel, AddUsersModal, etc) later in this stack.

That would be great

Do we really need another low-level component for this? Don't we have something we can reuse? If not, can't we refactor something / make it generic, rather than implementing a new one of these?

This is subjective, bt

(Looks like you added the Signal key in the update, did you mean to update the other entries as well?)

Re-requesting because I see no way of creating a dynamic style with classnames

Thanks for updating, looks good

If we only plan on exporting keyedCompetitorData, could we just add keys to competitorData and turn it from array -> keyed obj?

Looks good, can we avoid hard coding hex value being passed to ModalOverlay backgroundColor?