Page MenuHomePhabricator

atul (Atul)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Dec 29 2020, 8:08 PM (91 w, 1 d)
Roles
Administrator

Recent Activity

Today

atul accepted D5253: [native] created arrow component.
Wed, Sep 28, 5:20 PM
atul added a reviewer for D5239: [web] implemented search feature for Thread Picker: tomek.
Wed, Sep 28, 1:10 PM
atul closed D5240: [native] `await waitForCaptureURIUnload(...)` before disposing of temporary video thumbnails.
Wed, Sep 28, 1:04 PM
atul committed rCOMM5ba513238828: [native] `await waitForCaptureURIUnload(...)` before disposing of temporary… (authored by atul).
[native] `await waitForCaptureURIUnload(...)` before disposing of temporary…
Wed, Sep 28, 1:04 PM
atul accepted D5251: [native] memoized textStyle and styles.text.

Thanks for separating this out!

Wed, Sep 28, 1:02 PM
atul accepted D5252: [landing] removed old team members.

nice

Wed, Sep 28, 1:01 PM
atul updated the diff for D5240: [native] `await waitForCaptureURIUnload(...)` before disposing of temporary video thumbnails.

rebase before landing

Wed, Sep 28, 11:48 AM
atul accepted D5048: [native] Implement darker color tint to block quote container.

Looks good to me, adding @ashoat as blocking since he has much more context here

Wed, Sep 28, 11:39 AM
atul accepted D5107: Refactor lib/facts files from JSON to JS.

Looks good!

Wed, Sep 28, 11:30 AM
atul accepted D5230: [web] removed pagination logic from thread picker.

Sweet! Nice catching those no-longer-relevant CSS selectors as well

Wed, Sep 28, 11:14 AM
atul resigned from D5246: [Nix] Add localstack-down.

Resigning and adding @abosh as blocking. Anticipate you'll get some pushback on shell within writeShellApplication instead of external file

Wed, Sep 28, 11:13 AM
atul resigned from D5245: [Nix] Add localstack-up.

Resigning and adding @abosh as blocking. Anticipate you'll get some pushback on shell within writeShellApplication instead of external file

Wed, Sep 28, 11:12 AM
atul accepted D5244: [Nix] Add localstack cli to dev shell.
atuls-MacBook-Pro:comm atul$ which localstack
/nix/store/pw96frmr7l0ncj1zh8jjdnpdyrjami5c-python3.10-localstack-1.0.4/bin/localstack
Wed, Sep 28, 11:10 AM
atul added a comment to D5244: [Nix] Add localstack cli to dev shell.

Looks like the build isn't using all the cpu resources available to it

Wed, Sep 28, 10:54 AM
atul added a reviewer for D5048: [native] Implement darker color tint to block quote container: rohan.
Wed, Sep 28, 10:46 AM
atul added a reviewer for D5249: [web] Disable 'Delete' button for threads when the password input is empty: ginsu.
Wed, Sep 28, 10:46 AM
atul updated the summary of D5241: [native] "Flip the switch" to enable video messages.
Wed, Sep 28, 10:44 AM
atul updated the summary of D5241: [native] "Flip the switch" to enable video messages.
Wed, Sep 28, 10:44 AM
atul added inline comments to D5241: [native] "Flip the switch" to enable video messages.
Wed, Sep 28, 10:44 AM
atul requested changes to D5248: [native] added react-native-svg-transformer dev dependency.

I'd take a look at native/components/background-tab-illustration.react.js to see how we're integrating SVG assets in the native app today.

Wed, Sep 28, 9:33 AM
atul added a comment to D5244: [Nix] Add localstack cli to dev shell.

It's still taking a while to install nodejs-16.13.0, has that not been added to the cache yet for aarch64-darwin?

Wed, Sep 28, 8:48 AM
atul accepted D5243: [Nix] Update flake.lock.

Nix gates pass

Wed, Sep 28, 7:50 AM
atul requested changes to D5230: [web] removed pagination logic from thread picker.

Looks super close, let's remove LeftPager and RightPager in this diff as well.. couldn't find any other usage in the codebase.

Wed, Sep 28, 7:47 AM
atul requested changes to D5048: [native] Implement darker color tint to block quote container.

Requesting changes so @kamil's feedback can be addressed

Wed, Sep 28, 7:37 AM
atul closed D5242: [CI] Add `rust` installation step to pre-review Android Build CI.
Wed, Sep 28, 7:19 AM
atul committed rCOMM98be36344e65: [CI] Add `rust` installation step to pre-review Android Build CI (authored by atul).
[CI] Add `rust` installation step to pre-review Android Build CI
Wed, Sep 28, 7:19 AM

Yesterday

atul added a reviewer for D5107: Refactor lib/facts files from JSON to JS: ginsu.
Tue, Sep 27, 1:35 PM
atul added a reviewer for D5242: [CI] Add `rust` installation step to pre-review Android Build CI: Restricted Owners Package.
Tue, Sep 27, 1:34 PM
atul added a reviewer for D5048: [native] Implement darker color tint to block quote container: kamil.
Tue, Sep 27, 1:20 PM
atul accepted D5169: [native] Increase size of camera and gallery icons.

Looks great!

Tue, Sep 27, 1:10 PM
atul requested review of D5242: [CI] Add `rust` installation step to pre-review Android Build CI.
Tue, Sep 27, 12:56 PM
atul requested review of D5241: [native] "Flip the switch" to enable video messages.
Tue, Sep 27, 12:55 PM
atul updated the summary of D5240: [native] `await waitForCaptureURIUnload(...)` before disposing of temporary video thumbnails.
Tue, Sep 27, 10:19 AM
atul added a comment to D5107: Refactor lib/facts files from JSON to JS.

Can you squash the two together and then update this diff?

Tue, Sep 27, 10:06 AM
atul added a comment to D5107: Refactor lib/facts files from JSON to JS.

I think you might have created a new diff rather than amending the existing diff

Tue, Sep 27, 10:06 AM
atul requested review of D5240: [native] `await waitForCaptureURIUnload(...)` before disposing of temporary video thumbnails.
Tue, Sep 27, 9:58 AM
atul accepted D5219: [native] Unify thread settings accessibility.
Tue, Sep 27, 6:59 AM
atul added a reviewer for D5219: [native] Unify thread settings accessibility: ashoat. atul added 1 blocking reviewer(s) for D5219: [native] Unify thread settings accessibility: tomek.

Adding @tomek as blocking since he initially introduced the logic: https://phab.comm.dev/D545
Adding @ashoat as blocking since he pointed out the "discrepancy" between platforms: https://phab.comm.dev/D5082#150392

Tue, Sep 27, 6:42 AM

Mon, Sep 26

atul accepted D5229: [native] Warn if notif is too big after omiting messageInfo.
Mon, Sep 26, 7:36 PM
atul added a reviewer for D5229: [native] Warn if notif is too big after omiting messageInfo: marcin.
Mon, Sep 26, 7:33 PM
atul added inline comments to D5220: [web] Keep submit buttons always on the bottom of the `ThreadSettingsModal`.
Mon, Sep 26, 6:58 PM
atul accepted D5220: [web] Keep submit buttons always on the bottom of the `ThreadSettingsModal`.

Hm, at a high level is it the right abstraction to have errorMessage in SubmitButton but displayed outside of the button? Maybe we could borrow what we have on landing for the SubscriptionForm component and display the error within the button:

Mon, Sep 26, 6:50 PM
atul added reviewers for D5211: [web] Connect `ComposeSubchannel` modal with keyserver: ginsu, abosh.
Mon, Sep 26, 6:44 PM
atul added 1 blocking reviewer(s) for D5211: [web] Connect `ComposeSubchannel` modal with keyserver: tomek.

Setting @tomek as blocking on this one since he has more context

Mon, Sep 26, 6:43 PM
atul requested changes to D5169: [native] Increase size of camera and gallery icons.

Let's nudge the icons down a bit to get it centered vertically w/ the ChatInputBar.

Mon, Sep 26, 6:39 PM
atul added reviewers for D5230: [web] removed pagination logic from thread picker: rohan, abosh.
Mon, Sep 26, 6:28 PM
atul requested changes to D5230: [web] removed pagination logic from thread picker.

At a high level this looks good, but let's go through this component one more time and double check that everything related to pagination has been removed.

Mon, Sep 26, 6:22 PM
atul requested changes to D5225: [services] create ecr repository for identity service docker images.

Yeah, agree with @tomek... I think this diff needs a lot more context:

  1. A Linear task should exist for it
  2. There should be some explanation of what an AWS ECR repository is and why we need it (appears to be specifically for Docker images)
  3. Discussion of alternatives should be included (eg. Docker Hub)
Mon, Sep 26, 6:20 PM
atul accepted D5222: [web] Clear error message during switching between tabs in `ThreadSettingsModal`.

Based on the video you provided, should we also gray out the Delete button in the Delete tab if the password input field is empty?

Mon, Sep 26, 1:18 PM
atul added 1 blocking reviewer(s) for D5222: [web] Clear error message during switching between tabs in `ThreadSettingsModal`: tomek.
Mon, Sep 26, 1:17 PM
atul added a reviewer for D5187: [web] Introduce `ComposeSubchannel` modal: abosh.
Mon, Sep 26, 12:54 PM
atul added reviewers for D5187: [web] Introduce `ComposeSubchannel` modal: ginsu, rohan. atul added 1 blocking reviewer(s) for D5187: [web] Introduce `ComposeSubchannel` modal: tomek.
Mon, Sep 26, 12:54 PM
atul added inline comments to D5187: [web] Introduce `ComposeSubchannel` modal.
Mon, Sep 26, 12:53 PM
atul requested changes to D5187: [web] Introduce `ComposeSubchannel` modal.

At a high level, this diff is pretty big and the description is pretty short. It would have been good to split this into smaller diffs to make things easier to review. Maybe one diff for each component? (SubchannelSettings, SubchannelMembers, etc)

Mon, Sep 26, 12:39 PM
atul added a comment to D5187: [web] Introduce `ComposeSubchannel` modal.

but currently we don't have any similar icon in set

Mon, Sep 26, 10:48 AM
atul accepted D5185: [web] Make `AddMembersList` more universal.
Mon, Sep 26, 10:21 AM
atul foisted D5107: Refactor lib/facts files from JSON to JS upon rohan.
Mon, Sep 26, 9:58 AM
atul edited reviewers for D5225: [services] create ecr repository for identity service docker images, added: Restricted Owners Package; removed: atul.
Mon, Sep 26, 8:43 AM
atul removed a reviewer for D5225: [services] create ecr repository for identity service docker images: Restricted Owners Package.
Mon, Sep 26, 8:35 AM
atul added a reviewer for D5225: [services] create ecr repository for identity service docker images: Restricted Owners Package.
Mon, Sep 26, 8:34 AM

Sat, Sep 24

atul committed rCOMM97ec3389d650: Update `staff.json` (authored by atul).
Update `staff.json`
Sat, Sep 24, 7:36 AM

Fri, Sep 23

atul closed D5223: [flow] Add `(killall flow || pkill flow || true)` to `cleaninstall`.
Fri, Sep 23, 12:32 PM
atul committed rCOMM09c80b959990: [flow] Add `(killall flow || pkill flow || true)` to `cleaninstall` (authored by atul).
[flow] Add `(killall flow || pkill flow || true)` to `cleaninstall`
Fri, Sep 23, 12:32 PM
atul updated the diff for D5223: [flow] Add `(killall flow || pkill flow || true)` to `cleaninstall`.

rebase before landing

Fri, Sep 23, 12:32 PM
atul closed D5216: [native] Display thumbnail in `Multimedia` component for videos.
Fri, Sep 23, 12:31 PM
atul committed rCOMMd4179e26b988: [native] Display thumbnail in `Multimedia` component for videos (authored by atul).
[native] Display thumbnail in `Multimedia` component for videos
Fri, Sep 23, 12:31 PM
atul changed 2 blocking reviewer(s) for D5223: [flow] Add `(killall flow || pkill flow || true)` to `cleaninstall`, added 1: varun; removed 1: tomek.
Fri, Sep 23, 12:22 PM
atul updated the diff for D5216: [native] Display thumbnail in `Multimedia` component for videos.

rebase before landing

Fri, Sep 23, 12:04 PM
atul accepted D5221: [server] Script to move threads.
Fri, Sep 23, 11:52 AM
atul requested review of D5223: [flow] Add `(killall flow || pkill flow || true)` to `cleaninstall`.
Fri, Sep 23, 11:49 AM

Thu, Sep 22

atul requested review of D5216: [native] Display thumbnail in `Multimedia` component for videos.
Thu, Sep 22, 4:43 PM
atul planned changes to D5216: [native] Display thumbnail in `Multimedia` component for videos.
Thu, Sep 22, 12:17 PM
atul committed rCOMM2a32d90d865e: Bump jose from 2.0.5 to 2.0.6 (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump jose from 2.0.5 to 2.0.6
Thu, Sep 22, 11:40 AM
atul committed rCOMM661326798c90: Bump axum-core from 0.2.7 to 0.2.8 in /services/backup/blob_client (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).
Bump axum-core from 0.2.7 to 0.2.8 in /services/backup/blob_client
Thu, Sep 22, 11:40 AM
atul requested review of D5216: [native] Display thumbnail in `Multimedia` component for videos.
Thu, Sep 22, 9:50 AM
atul planned changes to D5216: [native] Display thumbnail in `Multimedia` component for videos.
Thu, Sep 22, 9:27 AM
atul requested review of D5216: [native] Display thumbnail in `Multimedia` component for videos.
Thu, Sep 22, 9:09 AM
atul added inline comments to D5215: Define type for <F>(serverCall: ActionFunc<F>) => F.
Thu, Sep 22, 7:53 AM
atul closed D5214: [CI] Bump GH Actions `ios_ci` job to `macos-12`.
Thu, Sep 22, 7:11 AM
atul committed rCOMM0c29c477a3e7: [CI] Bump GH Actions `ios_ci` job to `macos-12` (authored by atul).
[CI] Bump GH Actions `ios_ci` job to `macos-12`
Thu, Sep 22, 7:11 AM
atul requested review of D5214: [CI] Bump GH Actions `ios_ci` job to `macos-12`.
Thu, Sep 22, 7:05 AM
atul closed D5198: [keyserver] Introduce `getMediaMessageServerDBContentsFromMedia(...)`.
Thu, Sep 22, 6:51 AM
atul committed rCOMMff82d0f616b4: [keyserver] Introduce `getMediaMessageServerDBContentsFromMedia(...)` (authored by atul).
[keyserver] Introduce `getMediaMessageServerDBContentsFromMedia(...)`
Thu, Sep 22, 6:51 AM
atul added a comment to D5173: [services] Tunnelbroker - Update Protobuf file with the `ping`.

Why did the builds fail?

Thu, Sep 22, 6:28 AM
atul added inline comments to D5198: [keyserver] Introduce `getMediaMessageServerDBContentsFromMedia(...)`.
Thu, Sep 22, 6:14 AM
atul updated the diff for D5198: [keyserver] Introduce `getMediaMessageServerDBContentsFromMedia(...)`.

remove type annotation for mediaMessageContents

Thu, Sep 22, 6:10 AM
atul updated the diff for D5198: [keyserver] Introduce `getMediaMessageServerDBContentsFromMedia(...)`.

rebase before addressing feedback and before landing

Thu, Sep 22, 6:06 AM
atul closed D5197: [lib] Implement `messageContentForServerDB` for `messageTypes.MULTIMEDIA`.
Thu, Sep 22, 6:03 AM
atul committed rCOMM4597a9a14843: [lib] Implement `messageContentForServerDB` for `messageTypes.MULTIMEDIA` (authored by atul).
[lib] Implement `messageContentForServerDB` for `messageTypes.MULTIMEDIA`
Thu, Sep 22, 6:03 AM

Wed, Sep 21

atul updated the diff for D5197: [lib] Implement `messageContentForServerDB` for `messageTypes.MULTIMEDIA`.

rebase before landing

Wed, Sep 21, 2:04 PM
atul added a comment to D5197: [lib] Implement `messageContentForServerDB` for `messageTypes.MULTIMEDIA`.
In D5197#152670, @tomek wrote:

Is it safe for both server and client DB?

Should we have migrations on both platforms that update the values?

Wed, Sep 21, 2:03 PM
atul closed D5195: [keyserver] Construct `MULTIMEDIA` message media correctly in `rawMessageInfoFromRows(...)`.
Wed, Sep 21, 1:51 PM
atul committed rCOMM4e78512591e4: [keyserver] Construct `MULTIMEDIA` message media correctly in… (authored by atul).
[keyserver] Construct `MULTIMEDIA` message media correctly in…
Wed, Sep 21, 1:51 PM
atul updated the diff for D5195: [keyserver] Construct `MULTIMEDIA` message media correctly in `rawMessageInfoFromRows(...)`.

rebase before landing

Wed, Sep 21, 1:45 PM
atul closed D5193: [keyserver] Introduce `constructMediaFromMediaMessageContentsAndUploadRows`.
Wed, Sep 21, 1:39 PM
atul committed rCOMM12ac24c6b7b1: [keyserver] Introduce `constructMediaFromMediaMessageContentsAndUploadRows` (authored by atul).
[keyserver] Introduce `constructMediaFromMediaMessageContentsAndUploadRows`
Wed, Sep 21, 1:39 PM
atul updated the diff for D5193: [keyserver] Introduce `constructMediaFromMediaMessageContentsAndUploadRows`.

rebase before landing

Wed, Sep 21, 1:37 PM
atul closed D5191: [keyserver] Merge updated and legacy `multimediaMessageCreationResponder(...)`.
Wed, Sep 21, 1:07 PM
atul committed rCOMM243ec858b6f8: [keyserver] Merge updated and legacy `multimediaMessageCreationResponder(...)` (authored by atul).
[keyserver] Merge updated and legacy `multimediaMessageCreationResponder(...)`
Wed, Sep 21, 1:07 PM
atul updated the diff for D5191: [keyserver] Merge updated and legacy `multimediaMessageCreationResponder(...)`.

rebase before landing

Wed, Sep 21, 1:05 PM