Page MenuHomePhabricator

atul (Atul)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Dec 29 2020, 8:08 PM (127 w, 1 d)
Roles
Administrator

FS_JGHeXwAEZWmZ.jpg (700×500 px, 54 KB)

FS_JGHgXwAAsCf2.jpg (700×500 px, 46 KB)

FS_JGHdWYAEPW_t.jpg (700×500 px, 54 KB)

FS_JGHdXwAMHbdF.jpg (700×500 px, 53 KB)

Recent Activity

Today

atul accepted D8067: [web] Refactor the members modal to support any variety of role labels.
Thu, Jun 8, 2:03 PM
atul added a reverting change for rCOMM343fda9b18a1: [native] Temporary changes for staff release: rCOMM7a0b7ad94831: Revert "[native] Temporary changes for staff release".
Thu, Jun 8, 1:22 PM
atul committed rCOMM7a0b7ad94831: Revert "[native] Temporary changes for staff release" (authored by atul).
Revert "[native] Temporary changes for staff release"
Thu, Jun 8, 1:22 PM
atul committed rCOMM2c01d7ecd339: [native] `codeVersion` -> 224 (authored by atul).
[native] `codeVersion` -> 224
Thu, Jun 8, 1:22 PM
atul committed rCOMM343fda9b18a1: [native] Temporary changes for staff release (authored by atul).
[native] Temporary changes for staff release
Thu, Jun 8, 1:22 PM
atul committed rCOMM338be1daa551: [native] `codeVersion` -> 223 (authored by atul).
[native] `codeVersion` -> 223
Thu, Jun 8, 1:22 PM
atul closed D8131: Flip the switch to enable community creation.
Thu, Jun 8, 11:38 AM
atul committed rCOMM15cf01c11651: Flip the switch to enable community creation (authored by atul).
Flip the switch to enable community creation
Thu, Jun 8, 11:38 AM
atul updated the diff for D8131: Flip the switch to enable community creation.

rebase and land

Thu, Jun 8, 11:03 AM
atul closed D8130: [native] Navigate to newly created community after successful creation.
Thu, Jun 8, 10:52 AM
atul committed rCOMM8e53b360b3d7: [native] Navigate to newly created community after successful creation (authored by atul).
[native] Navigate to newly created community after successful creation
Thu, Jun 8, 10:52 AM
atul updated the diff for D8130: [native] Navigate to newly created community after successful creation.

rebase and land

Thu, Jun 8, 10:47 AM
atul closed D8129: [native] Introduce `addSelectedUsersToCommunity` to `CommunityCreationMembers`.
Thu, Jun 8, 10:40 AM
atul committed rCOMM7ca83617d0e2: [native] Introduce `addSelectedUsersToCommunity` to `CommunityCreationMembers` (authored by atul).
[native] Introduce `addSelectedUsersToCommunity` to `CommunityCreationMembers`
Thu, Jun 8, 10:40 AM
atul updated the diff for D8129: [native] Introduce `addSelectedUsersToCommunity` to `CommunityCreationMembers`.

address feedback

Thu, Jun 8, 10:28 AM
atul closed D8122: [native] Pass `threadID` of newly created community to `CommunityCreationMembers`.
Thu, Jun 8, 6:31 AM
atul committed rCOMMde8ff3bfad6e: [native] Pass `threadID` of newly created community to… (authored by atul).
[native] Pass `threadID` of newly created community to…
Thu, Jun 8, 6:31 AM
atul updated the diff for D8122: [native] Pass `threadID` of newly created community to `CommunityCreationMembers`.

rebase and land

Thu, Jun 8, 6:25 AM

Yesterday

atul accepted D8146: [lib] Use RegExp.source instead of RegExp.toString() in emojis.js.
Wed, Jun 7, 1:14 PM
atul accepted D8147: [lib] Unify duplicated avatar tcomb validators.
Wed, Jun 7, 1:14 PM
atul added inline comments to D8145: [lib] Make sure all default emojis pass onlyOneEmojiRegex.
Wed, Jun 7, 1:14 PM
atul accepted D8145: [lib] Make sure all default emojis pass onlyOneEmojiRegex.

Had to change text encoding in Phabricator to "see the difference," but looks good.

Wed, Jun 7, 1:13 PM
atul accepted D8135: [web] Show option to change role from the members modal.

Don't think the plus-circle icon makes sense for "Change Role," but defer to @ted on that.

Wed, Jun 7, 12:53 PM
atul requested changes to D8067: [web] Refactor the members modal to support any variety of role labels.

Label having a bg prop that expects a CSS variable is a weird API. Is there a way we can introduce a variant prop to Label instead and style accordingly within?

Wed, Jun 7, 12:50 PM
atul added inline comments to D8129: [native] Introduce `addSelectedUsersToCommunity` to `CommunityCreationMembers`.
Wed, Jun 7, 12:48 PM
atul accepted D8132: [landing] add faq section and request access section to keyserver page.

Accepting, but please take a look at the trailing space

Wed, Jun 7, 12:33 PM

Tue, Jun 6

atul accepted D8128: [landing] add rotation animation to keyserver faq icon.

whoa this looks smooth, first rotation animation?

Tue, Jun 6, 2:08 PM
atul accepted D8111: [lib] Stop setting dataLoaded from register / siweAuth actions.
Tue, Jun 6, 2:06 PM
atul accepted D8110: [native] Dispatch SET_DATA_LOADED action after registration completes.
Tue, Jun 6, 2:03 PM
atul accepted D8109: [native] Dispatch SET_DATA_LOADED action after SIWE completes.
Tue, Jun 6, 2:02 PM
atul accepted D8108: [web] Dispatch SET_DATA_LOADED action after SIWE completes.
Tue, Jun 6, 12:53 PM
atul accepted D8107: [lib] Introduce new SET_DATA_LOADED action.
Tue, Jun 6, 12:53 PM
atul accepted D8095: [landing] animate the keyserver faq section.
Tue, Jun 6, 12:47 PM
atul closed D8115: [native] Display "Skip"/"Done" button to exit community creation flow.
Tue, Jun 6, 12:33 PM
atul committed rCOMM40e91f42217a: [native] Display "Skip"/"Done" button to exit community creation flow (authored by atul).
[native] Display "Skip"/"Done" button to exit community creation flow
Tue, Jun 6, 12:33 PM
atul updated the diff for D8115: [native] Display "Skip"/"Done" button to exit community creation flow.

rebase and alnd

Tue, Jun 6, 11:30 AM
atul published D8131: Flip the switch to enable community creation for review.
Tue, Jun 6, 11:29 AM
atul published D8130: [native] Navigate to newly created community after successful creation for review.
Tue, Jun 6, 11:28 AM
atul requested review of D8129: [native] Introduce `addSelectedUsersToCommunity` to `CommunityCreationMembers`.
Tue, Jun 6, 11:19 AM
atul requested review of D8122: [native] Pass `threadID` of newly created community to `CommunityCreationMembers`.
Tue, Jun 6, 10:34 AM
atul requested review of D8115: [native] Display "Skip"/"Done" button to exit community creation flow.
Tue, Jun 6, 10:10 AM
atul accepted D8068: [native] Refactor the members list to support any variety of role labels.

Code change looks fine

Tue, Jun 6, 8:20 AM
atul requested changes to D8067: [web] Refactor the members modal to support any variety of role labels.

I could alternatively define roleName outside the scope of this memo and then put it in the dependency array

Tue, Jun 6, 8:15 AM
atul accepted D8093: [landing] introduce keyserver faq component.

Looks good, think we can skip classNames altogether for headingClassName though.

Tue, Jun 6, 8:08 AM
atul accepted D8087: [native] Fix userInfo calculation in UserAvatar.
Tue, Jun 6, 7:53 AM

Mon, Jun 5

atul accepted D8088: [native] Move some types from avatar-selection.react.js to registration-types.js.
Mon, Jun 5, 7:36 AM
atul accepted D8089: [native] Rename accountSelections to accountSelection.
Mon, Jun 5, 7:36 AM

Fri, Jun 2

atul accepted D8079: [landing] repurpose InfoBlock component.
Fri, Jun 2, 3:09 PM
atul accepted D8077: [landing] move hero section code into own component.

Looks like a straightforward move

Fri, Jun 2, 12:22 PM
atul accepted D8076: [landing] introduce glow effect for hero image.

Looks good overall, might be worth trying box-shadow instead of blur if it's easy... but feel free to land as-is if it takes too long to investigate + achieve the same effect

Fri, Jun 2, 12:21 PM
atul attached a referenced file: F569756: a3351f.png.
Fri, Jun 2, 12:19 PM
atul added inline comments to D8076: [landing] introduce glow effect for hero image.
Fri, Jun 2, 12:19 PM
atul added a comment to D8076: [landing] introduce glow effect for hero image.

Maybe glow instead of blur? Kind of associate blur with being some sort of "filter" "above" some other content

Fri, Jun 2, 12:17 PM
atul accepted D8075: [landing] redesign hero section layout.

Looks good

Fri, Jun 2, 12:14 PM
atul closed D8058: [native] Pass whether created community is `ANNOUNCEMENT` to `CommunityCreationMembers`.
Fri, Jun 2, 10:42 AM
atul committed rCOMM414dbe4650a0: [native] Pass whether created community is `ANNOUNCEMENT` to… (authored by atul).
[native] Pass whether created community is `ANNOUNCEMENT` to…
Fri, Jun 2, 10:42 AM
atul closed D8057: [native] Introduce `CommunityCreationContentContainer` component.
Fri, Jun 2, 9:20 AM
atul committed rCOMM3f6313aefb49: [native] Introduce `CommunityCreationContentContainer` component (authored by atul).
[native] Introduce `CommunityCreationContentContainer` component
Fri, Jun 2, 9:20 AM
atul added inline comments to D8057: [native] Introduce `CommunityCreationContentContainer` component.
Fri, Jun 2, 9:16 AM
atul updated the diff for D8057: [native] Introduce `CommunityCreationContentContainer` component.

addressed feedback

Fri, Jun 2, 9:15 AM
atul updated the diff for D8057: [native] Introduce `CommunityCreationContentContainer` component.

rebase before addressing feedback

Fri, Jun 2, 9:09 AM
atul closed D8056: [native] Barebones user selection in `CommunityCreationMembers`.
Fri, Jun 2, 9:03 AM
atul committed rCOMM9a3b372c57b2: [native] Barebones user selection in `CommunityCreationMembers` (authored by atul).
[native] Barebones user selection in `CommunityCreationMembers`
Fri, Jun 2, 9:03 AM
atul updated the diff for D8056: [native] Barebones user selection in `CommunityCreationMembers`.

rebase and land

Fri, Jun 2, 8:54 AM
atul added a comment to D8056: [native] Barebones user selection in `CommunityCreationMembers`.
In D8056#239034, @atul wrote:

I can try to pull something generic out of CommunityCreationMembers and see if it can be used in other components where we have TagInput and UserList (ComposeSubchannel, AddUsersModal, etc) later in this stack.

That would be great

Fri, Jun 2, 8:53 AM

Thu, Jun 1

atul published D8058: [native] Pass whether created community is `ANNOUNCEMENT` to `CommunityCreationMembers` for review.
Thu, Jun 1, 1:44 PM
atul added a comment to D8056: [native] Barebones user selection in `CommunityCreationMembers`.

Do we really need another low-level component for this? Don't we have something we can reuse? If not, can't we refactor something / make it generic, rather than implementing a new one of these?

Thu, Jun 1, 1:43 PM
atul requested review of D8057: [native] Introduce `CommunityCreationContentContainer` component.
Thu, Jun 1, 1:35 PM
atul requested review of D8056: [native] Barebones user selection in `CommunityCreationMembers`.
Thu, Jun 1, 1:33 PM
atul accepted D8047: [native] Make EditUserAvatar component conditionally navigate to registration screens.
Thu, Jun 1, 11:35 AM
atul accepted D8046: [native] Construct synthetic UserInfo to pass to EditUserAvatar.
Thu, Jun 1, 11:35 AM
atul accepted D8048: [native] Introduce avatarData state to hold pending avatar in AvatarSelection.
Thu, Jun 1, 11:23 AM
atul accepted D8049: [native] Default to ENS avatar for users that have one.
Thu, Jun 1, 11:23 AM
atul accepted D8044: [native] Introduce new RegistrationUserAvatarCameraModal screen for registration flow.
Thu, Jun 1, 11:22 AM
atul accepted D8043: [native] Introduce new EmojiAvatarSelection screen for registration flow.
Thu, Jun 1, 11:21 AM
atul accepted D8045: [lib] Introduce new GenericUserInfoWithAvatar type.
Thu, Jun 1, 11:21 AM
atul accepted D8042: [native] Replace savedEmojiAvatarSelector with savedEmojiAvatarFunc.
Thu, Jun 1, 11:15 AM
atul accepted D8041: [native] Introduce RegistrationMode in EditUserAvatarProvider.
Thu, Jun 1, 11:13 AM
atul accepted D8055: [landing] rename asset to imageAsset.
Thu, Jun 1, 11:11 AM
atul retitled D8054: [landing] remove deprecated info blocks from [landing] remove depricated info blocks to [landing] remove deprecated info blocks.
Thu, Jun 1, 11:10 AM
atul accepted D8054: [landing] remove deprecated info blocks.
Thu, Jun 1, 11:09 AM
atul accepted D8039: [landing] add feedback text to subscription form component.
Thu, Jun 1, 11:09 AM
atul accepted D8038: [landing] add feature cards to competitor comparison.
Thu, Jun 1, 11:07 AM
atul accepted D8034: [landing] introduce competitor comparison.
Thu, Jun 1, 11:06 AM

Wed, May 31

atul accepted D7915: [landing] redesign the subscription form component.
Wed, May 31, 1:13 PM
atul updated subscribers of D8034: [landing] introduce competitor comparison.

This is subjective, bt

Wed, May 31, 1:01 PM

Tue, May 30

atul added a comment to D8028: [landing] key competitor data.

(Looks like you added the Signal key in the update, did you mean to update the other entries as well?)

Tue, May 30, 11:30 AM
atul accepted D7993: [web] Add multimediaClassName prop to encrypted media components.
Tue, May 30, 9:35 AM
atul accepted D8023: [native] Make EmojiThreadAvatarCreation work with activeThreadSelector.
Tue, May 30, 9:35 AM
atul accepted D8022: [native] Use Alert from old useSaveThreadAvatar in new setThreadAvatar.
Tue, May 30, 9:34 AM
atul accepted D7994: [web] Add MediaGalleryItem component.

Re-requesting because I see no way of creating a dynamic style with classnames

Tue, May 30, 9:31 AM
atul accepted D8021: [native] Replace generic useSaveThreadAvatar with new generic setThreadAvatar.
Tue, May 30, 9:29 AM
atul accepted D8020: [native] Replace removeThreadAvatar with generic setThreadAvatar.
Tue, May 30, 9:27 AM
atul added inline comments to D8019: [native] Use Alert from old useSaveUserAvatar in new setUserAvatar.
Tue, May 30, 9:15 AM
atul accepted D8019: [native] Use Alert from old useSaveUserAvatar in new setUserAvatar.
Tue, May 30, 9:13 AM
atul accepted D8018: [native] Replace generic useSaveUserAvatar with new generic setUserAvatar.
Tue, May 30, 9:13 AM
atul accepted D8017: [native] Replace setENSUserAvatar and removeUserAvatar with generic setUserAvatar.
Tue, May 30, 9:12 AM
atul accepted D8025: [landing] introduce feature modal component.

Thanks for updating, looks good

Tue, May 30, 9:01 AM
atul accepted D8028: [landing] key competitor data.

If we only plan on exporting keyedCompetitorData, could we just add keys to competitorData and turn it from array -> keyed obj?

Tue, May 30, 8:58 AM
atul requested changes to D8025: [landing] introduce feature modal component.

Looks good, can we avoid hard coding hex value being passed to ModalOverlay backgroundColor?

Tue, May 30, 7:27 AM