Page MenuHomePhabricator

atul (Atul)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Dec 29 2020, 8:08 PM (205 w, 6 d)
Roles
Administrator

FS_JGHeXwAEZWmZ.jpg (700×500 px, 54 KB)

FS_JGHgXwAAsCf2.jpg (700×500 px, 46 KB)

FS_JGHdWYAEPW_t.jpg (700×500 px, 54 KB)

FS_JGHdXwAMHbdF.jpg (700×500 px, 53 KB)

Recent Activity

Oct 8 2024

atul closed D13561: [web] Flip the switch to strip member permissions from `web`.
Oct 8 2024, 2:05 PM
atul committed rCOMM82470964d9c9: [web] Flip the switch to strip member permissions from `web` (authored by atul).
[web] Flip the switch to strip member permissions from `web`
Oct 8 2024, 2:05 PM
atul closed D12790: [web] Introduce `web` migration to strip member permissions.
Oct 8 2024, 2:05 PM
atul committed rCOMM1aad44e6fb68: [web] Introduce `web` migration to strip member permissions (authored by atul).
[web] Introduce `web` migration to strip member permissions
Oct 8 2024, 2:05 PM
atul updated the diff for D13561: [web] Flip the switch to strip member permissions from `web`.

land

Oct 8 2024, 1:59 PM
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.

land

Oct 8 2024, 1:57 PM
atul updated the diff for D13561: [web] Flip the switch to strip member permissions from `web`.

exclude native placeholder migration

Oct 8 2024, 1:53 PM
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.

include native migration here (was previously in flip the switch)

Oct 8 2024, 1:51 PM
atul attached a referenced file: F2926333: Screenshot 2024-10-08 at 4.24.03 PM.png.
Oct 8 2024, 1:28 PM
atul attached a referenced file: F2926335: Screenshot 2024-10-08 at 4.24.24 PM.png.
Oct 8 2024, 1:28 PM
atul attached a referenced file: F2926336: Screenshot 2024-10-08 at 4.25.16 PM.png.
Oct 8 2024, 1:28 PM
atul attached a referenced file: F2926371: Screenshot 2024-10-08 at 4.25.38 PM.png.
Oct 8 2024, 1:28 PM
atul updated the summary of D13561: [web] Flip the switch to strip member permissions from `web`.
Oct 8 2024, 1:27 PM
atul updated the test plan for D12790: [web] Introduce `web` migration to strip member permissions.
Oct 8 2024, 1:27 PM
atul updated the test plan for D13561: [web] Flip the switch to strip member permissions from `web`.
Oct 8 2024, 12:40 PM
atul abandoned D13566: Ignore.
Oct 8 2024, 12:31 PM
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.

cast to migration function

Oct 8 2024, 12:29 PM
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.

update ThreadStoreWithMemberPermissions to include thick threads

Oct 8 2024, 12:26 PM
atul updated the diff for D13561: [web] Flip the switch to strip member permissions from `web`.

rebase

Oct 8 2024, 12:22 PM
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.

remove console log and change flowfixme to flowignore

Oct 8 2024, 12:13 PM
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.

rebase after type changes

Oct 8 2024, 12:04 PM

Oct 2 2024

atul added a comment to D12790: [web] Introduce `web` migration to strip member permissions.

(Will be available noon onwards tomorrow to work on this)

Oct 2 2024, 3:07 PM

Oct 1 2024

atul planned changes to D12790: [web] Introduce `web` migration to strip member permissions.

Will make some changes before landing eg

  • Go from FlowFixMe to something like FlowIgnore
  • Remove logs related skipping ThickThreads
Oct 1 2024, 7:17 PM
atul added a comment to D12790: [web] Introduce `web` migration to strip member permissions.

Okay this migration now appears to work.

Oct 1 2024, 3:44 PM
atul updated the diff for D13561: [web] Flip the switch to strip member permissions from `web`.

fix

Oct 1 2024, 3:40 PM
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.

update migration to work with new migration system

Oct 1 2024, 3:27 PM
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.

cut extraneous changes

Oct 1 2024, 3:08 PM
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.

workaround that works for now (DRAFT)

Oct 1 2024, 3:07 PM
atul updated the diff for D13566: Ignore.

blah

Oct 1 2024, 2:37 PM
atul requested review of D13566: Ignore.
Oct 1 2024, 1:36 PM
atul updated the diff for D13561: [web] Flip the switch to strip member permissions from `web`.

bumped native persist version and added no-op migration

Oct 1 2024, 12:04 PM
atul requested review of D13561: [web] Flip the switch to strip member permissions from `web`.
Oct 1 2024, 11:16 AM
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.

address feedback (any-cast stripMemberPermissionsFromRawThreadInfos instead of $FlowIgnore)

Oct 1 2024, 10:54 AM
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.

rebase

Oct 1 2024, 10:40 AM

Jul 20 2024

atul closed D12811: [native] Flip the switch to strip member permissions from `native`.
Jul 20 2024, 11:52 AM
atul committed rCOMMb7d5e9a1db09: [native] Flip the switch to strip member permissions from `native` (authored by atul).
[native] Flip the switch to strip member permissions from `native`
Jul 20 2024, 11:52 AM

Jul 19 2024

atul requested review of D12811: [native] Flip the switch to strip member permissions from `native`.
Jul 19 2024, 5:29 PM
atul closed D12789: [native] Introduce `native` migration to strip member permissions.
Jul 19 2024, 5:07 PM
atul committed rCOMM0748bce33c6f: [native] Introduce `native` migration to strip member permissions (authored by atul).
[native] Introduce `native` migration to strip member permissions
Jul 19 2024, 5:06 PM
atul updated the diff for D12789: [native] Introduce `native` migration to strip member permissions.

address feedback (any-cast stripMemberPermissionsFromRawThreadInfos instead of $FlowIgnore)

Jul 19 2024, 4:53 PM
atul closed D12799: [lib] Rename `deprecatedMinimallyEncodeRawThreadInfo` -> `minimallyEncodeRawThreadInfoWithMemberPermissions`.
Jul 19 2024, 4:37 PM
atul committed rCOMMd25e29a0be1e: [lib] Rename `deprecatedMinimallyEncodeRawThreadInfo` ->… (authored by atul).
[lib] Rename `deprecatedMinimallyEncodeRawThreadInfo` ->…
Jul 19 2024, 4:36 PM
atul updated the diff for D12799: [lib] Rename `deprecatedMinimallyEncodeRawThreadInfo` -> `minimallyEncodeRawThreadInfoWithMemberPermissions`.

rebase and land

Jul 19 2024, 4:28 PM

Jul 18 2024

atul requested review of D12799: [lib] Rename `deprecatedMinimallyEncodeRawThreadInfo` -> `minimallyEncodeRawThreadInfoWithMemberPermissions`.
Jul 18 2024, 3:04 PM
atul added a comment to D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.

Here's the followup diff I promised: D12799

Jul 18 2024, 2:48 PM
atul closed D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
Jul 18 2024, 2:45 PM
atul committed rCOMM3cd205451a32: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients (authored by atul).
[keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients
Jul 18 2024, 2:45 PM
atul updated the diff for D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.

land

Jul 18 2024, 2:42 PM
atul added inline comments to D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
Jul 18 2024, 2:41 PM
atul closed D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.
Jul 18 2024, 2:28 PM
atul committed rCOMMb84a90848053: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos` (authored by atul).
[lib] Introduce `stripMemberPermissionsFromRawThreadInfos`
Jul 18 2024, 2:28 PM
atul updated the diff for D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.

rebase before landing

Jul 18 2024, 2:20 PM
atul updated the diff for D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.

rebase BEFORE re-removing any-cast

Jul 18 2024, 2:18 PM
atul closed D12763: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo`.
Jul 18 2024, 2:17 PM
atul committed rCOMMc4089cbcf0e1: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo` (authored by atul).
[lib] Introduce `stripMemberPermissionsFromRawThreadInfo`
Jul 18 2024, 2:17 PM
atul updated the diff for D12763: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo`.

cherry-pick and land

Jul 18 2024, 2:10 PM
atul closed D12597: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`.
Jul 18 2024, 1:37 PM
atul committed rCOMM9fa6dd9ff9b7: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread` (authored by atul).
[lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`
Jul 18 2024, 1:37 PM
atul closed D12594: [lib] Change type of `ThinRawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`.
Jul 18 2024, 1:37 PM
atul committed rCOMM0561cfa7544f: [lib] Change type of `ThinRawThreadInfo.members` from… (authored by atul).
[lib] Change type of `ThinRawThreadInfo.members` from…
Jul 18 2024, 1:37 PM
atul updated the diff for D12597: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`.

cherry-pick and land

Jul 18 2024, 1:24 PM
atul added a comment to D12597: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`.

It's actually fine to land this as-is. If migration runs on RawThreadInfo that's already missing permissions, nothing will happen since stripPermissionsFromMemberInfo just won't really do anything:

14695f.png (550×1 px, 105 KB)

Jul 18 2024, 1:11 PM
atul added inline comments to D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
Jul 18 2024, 12:50 PM
atul added inline comments to D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
Jul 18 2024, 12:50 PM
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.

rebase

Jul 18 2024, 12:42 PM
atul updated the diff for D12789: [native] Introduce `native` migration to strip member permissions.

rebase

Jul 18 2024, 12:42 PM
atul updated the diff for D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.

rebase

Jul 18 2024, 12:41 PM
atul updated the diff for D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.

rebase

Jul 18 2024, 12:41 PM
atul updated the diff for D12763: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo`.

rebase

Jul 18 2024, 12:41 PM
atul updated the diff for D12597: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`.

rebase

Jul 18 2024, 12:40 PM
atul updated the diff for D12594: [lib] Change type of `ThinRawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`.

rebase

Jul 18 2024, 12:40 PM
atul abandoned D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.

Can drop this now, thanks @marcin !

Jul 18 2024, 12:39 PM
atul updated the diff for D12763: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo`.

cherry-pick and land

Jul 18 2024, 12:36 PM
atul closed D12755: [lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo`.
Jul 18 2024, 12:34 PM
atul committed rCOMM1dc8f0fe5186: [lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo` (authored by atul).
[lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo`
Jul 18 2024, 12:34 PM
atul updated the diff for D12755: [lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo`.

cherry-pick and land

Jul 18 2024, 12:25 PM
atul closed D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.
Jul 18 2024, 12:21 PM
atul committed rCOMM2ab735a4abc7: [lib] Deprecate `minimallyEncodeRawThreadInfo` (authored by atul).
[lib] Deprecate `minimallyEncodeRawThreadInfo`
Jul 18 2024, 12:21 PM
atul updated the diff for D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.

cherry-pick and land

Jul 18 2024, 12:12 PM
atul added a comment to D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.

This is purely rename diff, so safe to cherry-pick and land out of order.

Jul 18 2024, 12:12 PM
atul added a comment to D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.

Did you perhaps forget to remove the any-cast before diffing this up?

Jul 18 2024, 12:09 PM
atul updated the diff for D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.

remove extraneous any-cast

Jul 18 2024, 12:08 PM

Jul 17 2024

atul requested review of D12790: [web] Introduce `web` migration to strip member permissions.
Jul 17 2024, 4:25 PM
atul requested review of D12789: [native] Introduce `native` migration to strip member permissions.
Jul 17 2024, 4:19 PM
atul requested review of D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.
Jul 17 2024, 3:51 PM
atul added a comment to D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.

Updated test plan after some more testing.

Jul 17 2024, 3:02 PM
atul updated the test plan for D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
Jul 17 2024, 3:02 PM
atul updated the diff for D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.

fix logic, still need to do more testing

Jul 17 2024, 2:49 PM
atul added inline comments to D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
Jul 17 2024, 2:29 PM
atul planned changes to D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.

Lot of things that need to be fixed up here.

Jul 17 2024, 2:25 PM
atul updated the diff for D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.

rebase after addressing feedback in previous diffs in stack, still need to fix this diff up

Jul 17 2024, 2:25 PM
atul updated the diff for D12763: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo`.

move changes to stripMemberPermissionsFromRawThreadInfo into this diff

Jul 17 2024, 2:24 PM
atul updated the diff for D12755: [lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo`.

update diff with ESLint and validator unit test resolved.

Jul 17 2024, 2:19 PM
atul updated the diff for D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.

update to address ESLint and failing validator test. flow issue(s) still expected.

Jul 17 2024, 2:18 PM
atul updated the diff for D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.

rebase

Jul 17 2024, 2:17 PM
atul requested review of D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.

still would like to see the ESLint fix moved to the diff where the issue is introduced.

Jul 17 2024, 2:14 PM
atul updated the diff for D12597: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`.

fix ESLint issue

Jul 17 2024, 2:12 PM
atul updated the diff for D12597: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`.

rebase after landing validator fix

Jul 17 2024, 2:09 PM
atul updated the diff for D12594: [lib] Change type of `ThinRawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`.

rebase after landing validator fix.

Jul 17 2024, 2:08 PM
atul closed D12756: [lib] Move `stripPermissionsFromMemberInfo` out of `...-types.js` file.
Jul 17 2024, 2:05 PM