User Details
- User Since
- Dec 29 2020, 8:08 PM (205 w, 6 d)
- Roles
- Administrator
Oct 8 2024
land
land
exclude native placeholder migration
include native migration here (was previously in flip the switch)
cast to migration function
update ThreadStoreWithMemberPermissions to include thick threads
rebase
remove console log and change flowfixme to flowignore
rebase after type changes
Oct 2 2024
(Will be available noon onwards tomorrow to work on this)
Oct 1 2024
Will make some changes before landing eg
- Go from FlowFixMe to something like FlowIgnore
- Remove logs related skipping ThickThreads
Okay this migration now appears to work.
fix
update migration to work with new migration system
cut extraneous changes
workaround that works for now (DRAFT)
bumped native persist version and added no-op migration
address feedback (any-cast stripMemberPermissionsFromRawThreadInfos instead of $FlowIgnore)
rebase
Jul 20 2024
Jul 19 2024
address feedback (any-cast stripMemberPermissionsFromRawThreadInfos instead of $FlowIgnore)
rebase and land
Jul 18 2024
Here's the followup diff I promised: D12799
land
rebase before landing
rebase BEFORE re-removing any-cast
cherry-pick and land
cherry-pick and land
It's actually fine to land this as-is. If migration runs on RawThreadInfo that's already missing permissions, nothing will happen since stripPermissionsFromMemberInfo just won't really do anything:
rebase
rebase
rebase
rebase
rebase
rebase
rebase
Can drop this now, thanks @marcin !
cherry-pick and land
cherry-pick and land
cherry-pick and land
This is purely rename diff, so safe to cherry-pick and land out of order.
Did you perhaps forget to remove the any-cast before diffing this up?
remove extraneous any-cast
Jul 17 2024
Updated test plan after some more testing.
fix logic, still need to do more testing
Lot of things that need to be fixed up here.
rebase after addressing feedback in previous diffs in stack, still need to fix this diff up
move changes to stripMemberPermissionsFromRawThreadInfo into this diff
update diff with ESLint and validator unit test resolved.
update to address ESLint and failing validator test. flow issue(s) still expected.
rebase
still would like to see the ESLint fix moved to the diff where the issue is introduced.
fix ESLint issue
rebase after landing validator fix
rebase after landing validator fix.