User Details
- User Since
- Dec 29 2020, 8:08 PM (127 w, 1 d)
- Roles
- Administrator
Today
rebase and land
rebase and land
address feedback
rebase and land
Yesterday
Had to change text encoding in Phabricator to "see the difference," but looks good.
Don't think the plus-circle icon makes sense for "Change Role," but defer to @ted on that.
Label having a bg prop that expects a CSS variable is a weird API. Is there a way we can introduce a variant prop to Label instead and style accordingly within?
Accepting, but please take a look at the trailing space
Tue, Jun 6
whoa this looks smooth, first rotation animation?
rebase and alnd
Code change looks fine
I could alternatively define roleName outside the scope of this memo and then put it in the dependency array
Looks good, think we can skip classNames altogether for headingClassName though.
Mon, Jun 5
Fri, Jun 2
Looks like a straightforward move
Looks good overall, might be worth trying box-shadow instead of blur if it's easy... but feel free to land as-is if it takes too long to investigate + achieve the same effect
Maybe glow instead of blur? Kind of associate blur with being some sort of "filter" "above" some other content
addressed feedback
rebase before addressing feedback
rebase and land
Thu, Jun 1
Do we really need another low-level component for this? Don't we have something we can reuse? If not, can't we refactor something / make it generic, rather than implementing a new one of these?
Wed, May 31
This is subjective, bt
Tue, May 30
(Looks like you added the Signal key in the update, did you mean to update the other entries as well?)
Re-requesting because I see no way of creating a dynamic style with classnames
Thanks for updating, looks good
If we only plan on exporting keyedCompetitorData, could we just add keys to competitorData and turn it from array -> keyed obj?
Looks good, can we avoid hard coding hex value being passed to ModalOverlay backgroundColor?