atul (Atul)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since: Dec 29 2020, 8:08 PM (142 w, 3 d)
Roles: Administrator

Recent Activity
View All

Thu, Sep 21

atul added inline comments to D9262: [lib] Add `ThreadActivityStore` to Redux.

Thu, Sep 21, 2:37 PM

atul updated the diff for D9262: [lib] Add `ThreadActivityStore` to Redux.

fix

Thu, Sep 21, 2:33 PM

atul updated the diff for D9262: [lib] Add `ThreadActivityStore` to Redux.

address feedback

Thu, Sep 21, 2:30 PM

atul added a comment to D9262: [lib] Add `ThreadActivityStore` to Redux.

In D9262#272502, @ashoat wrote:

In the past, we would need to update websites-responders.js when adding a new field to Redux state. Now that Redux state for the web is fetched via an API call, is there a different place we should be updating?

Thu, Sep 21, 2:22 PM

atul published D9262: [lib] Add `ThreadActivityStore` to Redux for review.

Thu, Sep 21, 1:58 PM

atul updated the diff for D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma.

rebase

Thu, Sep 21, 10:55 AM

Wed, Sep 20

atul committed rCOMM1cf8c3d6ba22: Revert "[native] Temporary changes for staff release" (authored by atul).

Revert "[native] Temporary changes for staff release"

Wed, Sep 20, 2:35 PM

atul committed rCOMM9d0a6d545307: [native] `codeVersion` -> 264 (authored by atul).

[native] `codeVersion` -> 264

Wed, Sep 20, 2:35 PM

atul committed rCOMMe8bd73f1d8e1: [native] Temporary changes for staff release (authored by atul).

[native] Temporary changes for staff release

Wed, Sep 20, 2:35 PM

atul committed rCOMM87443cc76daf: [native] `codeVersion` -> 263 (authored by atul).

[native] `codeVersion` -> 263

Wed, Sep 20, 2:35 PM

atul added reviewers for D9235: [lib] introduce createPendingPersonalThread function: ashoat, tomek.

Adding @ashoat and @tomek here since I don't have a ton of context on pending threads

Wed, Sep 20, 1:54 PM

atul added a comment to D9251: [keyserver] Remove unused exports in message-fetchers.js.

In D9251#272216, @ashoat wrote:

Android failure is unrelated

Wed, Sep 20, 1:54 PM

atul accepted D9223: [nix] add logs to console while waiting for MariaDB to come up.

Looks good, left comments but they're purely personal preference so feel free to land as is

Wed, Sep 20, 1:52 PM

atul accepted D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.

Wed, Sep 20, 1:51 PM

atul accepted D9203: [web] introduce AppearanceChangeModal.

Wed, Sep 20, 1:50 PM

atul added inline comments to D9248: [native] Fix rescinds and badge-only notifs on iOS.

Wed, Sep 20, 10:45 AM

atul added a comment to D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma.

In D9227#272137, @ashoat wrote:

Can you create a GitHub issue on the Expo repo and link it here before landing?

Wed, Sep 20, 10:39 AM

atul accepted D9248: [native] Fix rescinds and badge-only notifs on iOS.

Was there maybe some corresponding keyserver change that needed to be deployed before this release or something?

Wed, Sep 20, 10:37 AM

atul published D9248: [native] Fix rescinds and badge-only notifs on iOS for review.

Wed, Sep 20, 10:36 AM

atul closed D9233: [iOS] Add `withEnableSampleProfiling(true)` to `makeRuntimeConfig`.

Wed, Sep 20, 10:31 AM

atul committed rCOMM125b29a6d73e: [iOS] Add `withEnableSampleProfiling(true)` to `makeRuntimeConfig` (authored by atul).

[iOS] Add `withEnableSampleProfiling(true)` to `makeRuntimeConfig`

Wed, Sep 20, 10:31 AM

atul updated the diff for D9233: [iOS] Add `withEnableSampleProfiling(true)` to `makeRuntimeConfig`.

toggle withEnableSampleProfiling on DEBUG

Wed, Sep 20, 10:24 AM

atul added a comment to D9233: [iOS] Add `withEnableSampleProfiling(true)` to `makeRuntimeConfig`.

In D9233#271801, @ashoat wrote:

Okay, please make sure that upstream React Native does this on all builds too before landing!

Wed, Sep 20, 10:21 AM

atul added a comment to D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma.

In D9227#271710, @ashoat wrote:

Is there a GitHub issue in Expo's GitHub repo for this?

Wed, Sep 20, 9:47 AM

Tue, Sep 19

atul committed rCOMMebb529b9ae7b: Revert "[native] Temporary changes for staff release" (authored by atul).

Revert "[native] Temporary changes for staff release"

Tue, Sep 19, 3:05 PM

atul committed rCOMM1393b9e9c983: [native] `codeVersion` -> 262 (authored by atul).

[native] `codeVersion` -> 262

Tue, Sep 19, 3:05 PM

atul committed rCOMMbc628b9e3b8d: [native] Temporary changes for staff release (authored by atul).

[native] Temporary changes for staff release

Tue, Sep 19, 3:05 PM

atul committed rCOMM208984aaf533: [native] `codeVersion` -> 261 (authored by atul).

[native] `codeVersion` -> 261

Tue, Sep 19, 3:05 PM

atul committed rCOMMbb73b304a2e6: Bump webpki from 0.22.0 to 0.22.1 in /services/feature-flags (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).

Bump webpki from 0.22.0 to 0.22.1 in /services/feature-flags

Tue, Sep 19, 2:58 PM

atul committed rCOMMeb3e37ff76d6: Bump webpki from 0.22.0 to 0.22.1 in /services/backup (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).

Bump webpki from 0.22.0 to 0.22.1 in /services/backup

Tue, Sep 19, 2:58 PM

atul committed rCOMM5b994dbc623d: Bump webpki from 0.22.0 to 0.22.1 in /services/comm-services-lib (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).

Bump webpki from 0.22.0 to 0.22.1 in /services/comm-services-lib

Tue, Sep 19, 2:58 PM

atul committed rCOMM88f1887d900f: Bump webpki from 0.22.0 to 0.22.1 in /services/blob (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).

Bump webpki from 0.22.0 to 0.22.1 in /services/blob

Tue, Sep 19, 2:58 PM

atul committed rCOMM92f52ec682b5: Bump webpki from 0.22.0 to 0.22.1 in /services/tunnelbroker (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).

Bump webpki from 0.22.0 to 0.22.1 in /services/tunnelbroker

Tue, Sep 19, 2:57 PM

atul committed rCOMM50c9eb9535d9: Bump webpki from 0.22.0 to 0.22.1 in /services/reports (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).

Bump webpki from 0.22.0 to 0.22.1 in /services/reports

Tue, Sep 19, 2:57 PM

atul committed rCOMMe52697f28480: Bump webpki from 0.22.0 to 0.22.1 in /services/commtest (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).

Bump webpki from 0.22.0 to 0.22.1 in /services/commtest

Tue, Sep 19, 2:56 PM

atul committed rCOMMd2f9770dca2b: Bump electron from 25.3.0 to 25.8.1 (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).

Bump electron from 25.3.0 to 25.8.1

Tue, Sep 19, 2:56 PM

atul committed rCOMM55f60fee8c1a: Bump webpki from 0.22.0 to 0.22.1 in /services/identity (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).

Bump webpki from 0.22.0 to 0.22.1 in /services/identity

Tue, Sep 19, 2:56 PM

atul committed rCOMMb2deff08ea76: Bump apollo-server-core from 3.11.1 to 3.12.1 (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).

Bump apollo-server-core from 3.11.1 to 3.12.1

Tue, Sep 19, 2:55 PM

atul committed rCOMMcbe88c3eecd2: Bump rustls-webpki from 0.101.3 to 0.101.4 in /services/identity (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).

Bump rustls-webpki from 0.101.3 to 0.101.4 in /services/identity

Tue, Sep 19, 2:55 PM

atul committed rCOMM2d17a1619894: Bump activesupport from 6.1.7.3 to 6.1.7.6 in /native (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).

Bump activesupport from 6.1.7.3 to 6.1.7.6 in /native

Tue, Sep 19, 2:54 PM

atul committed rCOMM3796da87658b: Bump rustls-webpki in /keyserver/addons/rust-node-addon (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).

Bump rustls-webpki in /keyserver/addons/rust-node-addon

Tue, Sep 19, 2:54 PM

atul committed rCOMMe3acc63103fd: Bump rustls-webpki from 0.101.3 to 0.101.4 in /shared/grpc_clients (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).

Bump rustls-webpki from 0.101.3 to 0.101.4 in /shared/grpc_clients

Tue, Sep 19, 2:54 PM

atul committed rCOMMacd5e89c8ec8: Bump rustls-webpki from 0.100.1 to 0.100.2 in /services/tunnelbroker (authored by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>).

Bump rustls-webpki from 0.100.1 to 0.100.2 in /services/tunnelbroker

Tue, Sep 19, 2:53 PM

atul closed D9228: [iOS] Set `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` flag to unblock iOS build.

Tue, Sep 19, 2:43 PM

atul committed rCOMMf30690b547dd: [iOS] Set `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` flag to unblock… (authored by atul).

[iOS] Set `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` flag to unblock…

Tue, Sep 19, 2:43 PM

atul updated the diff for D9228: [iOS] Set `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` flag to unblock iOS build.

rebase and land

Tue, Sep 19, 2:35 PM

atul added a comment to D9233: [iOS] Add `withEnableSampleProfiling(true)` to `makeRuntimeConfig`.

(I think the profiler gets disabled on prod builds, I'll do a little more research)

Tue, Sep 19, 1:48 PM

atul added a comment to D9233: [iOS] Add `withEnableSampleProfiling(true)` to `makeRuntimeConfig`.

In D9233#271796, @ashoat wrote:

It seems sketchy to do this in production, especially given it's undocumented. I'm worried about the potential impact on performance. Can we restrict this change to dev builds?

Tue, Sep 19, 1:47 PM

atul accepted D9232: [keyserver] Prevent creation of sidebars from pinned message robotext.

Tue, Sep 19, 1:40 PM

atul accepted D9231: [keyserver] Move sidebar-of-sidebar check earlier in createThread.

Tue, Sep 19, 1:39 PM

atul accepted D9230: [keyserver] Delete sidebars created from pinned message robotexts.

Tue, Sep 19, 1:38 PM

atul accepted D9229: [keyserver] Add ignorePermissions option to deleteThread.

Tue, Sep 19, 1:35 PM

atul published D9233: [iOS] Add `withEnableSampleProfiling(true)` to `makeRuntimeConfig` for review.

Tue, Sep 19, 1:31 PM

atul published D9228: [iOS] Set `_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION` flag to unblock iOS build for review.

Tue, Sep 19, 10:15 AM

atul published D9227: [patch] Patch `expo-modules-core` to unblock iOS build on macOS Sonoma for review.

Tue, Sep 19, 10:00 AM

atul abandoned D9211: [native] Memoize `flatList` in `ChatThreadList`.

@tomek Sorry, you’re totally right that this is useless. I tested performance with/without this diff in isolation and there was no difference.

Tue, Sep 19, 7:33 AM

Mon, Sep 18

atul closed D9215: [native] Remove `boundChatListData` from `useThreadListSearch` dep list.

Mon, Sep 18, 2:04 PM

atul committed rCOMM84b611f0316c: [native] Remove `boundChatListData` from `useThreadListSearch` dep list (authored by atul).

[native] Remove `boundChatListData` from `useThreadListSearch` dep list

Mon, Sep 18, 2:04 PM

atul closed D9212: [native] Consume `useThreadListSearch` in `ChatThreadList`.

Mon, Sep 18, 2:04 PM

atul committed rCOMM74c8424f88cc: [native] Consume `useThreadListSearch` in `ChatThreadList` (authored by atul).

[native] Consume `useThreadListSearch` in `ChatThreadList`

Mon, Sep 18, 2:04 PM

atul updated the diff for D9215: [native] Remove `boundChatListData` from `useThreadListSearch` dep list.

rebase around D9211 to land

Mon, Sep 18, 1:49 PM

atul updated the diff for D9212: [native] Consume `useThreadListSearch` in `ChatThreadList`.

rebase around D9211 to land

Mon, Sep 18, 1:48 PM

atul closed D9210: [native] Add some basic memoization to `ChatThreadListSearch`.

Mon, Sep 18, 1:46 PM

atul committed rCOMM90f88e7b7c08: [native] Add some basic memoization to `ChatThreadListSearch` (authored by atul).

[native] Add some basic memoization to `ChatThreadListSearch`

Mon, Sep 18, 1:46 PM

atul updated the diff for D9210: [native] Add some basic memoization to `ChatThreadListSearch`.

land

Mon, Sep 18, 1:45 PM

atul closed D9209: [native] Forward `searchInputRef` from `ChatThreadList` to `ChatThreadListSearch`.

Mon, Sep 18, 11:01 AM

atul committed rCOMMb2d1a3f8e4f9: [native] Forward `searchInputRef` from `ChatThreadList` to… (authored by atul).

[native] Forward `searchInputRef` from `ChatThreadList` to…

Mon, Sep 18, 11:01 AM

atul closed D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.

Mon, Sep 18, 11:01 AM

atul closed D9207: [native] Move Reanimated code from `ChatThreadList` to `ChatThreadListSearch`.

Mon, Sep 18, 11:01 AM

atul committed rCOMM07a97b02cad6: [native] Move Reanimated code from `ChatThreadList` to `ChatThreadListSearch` (authored by atul).

[native] Move Reanimated code from `ChatThreadList` to `ChatThreadListSearch`

Mon, Sep 18, 11:00 AM

atul committed rCOMMa0967233d046: [native] Remove `renderSearch` in `ChatThreadList` and inline… (authored by atul).

[native] Remove `renderSearch` in `ChatThreadList` and inline…

Mon, Sep 18, 11:00 AM

atul closed D9206: [native] Move rest of Search views to `ChatThreadListSearch`.

Mon, Sep 18, 11:00 AM

atul committed rCOMMe9e030d6493b: [native] Move rest of Search views to `ChatThreadListSearch` (authored by atul).

[native] Move rest of Search views to `ChatThreadListSearch`

Mon, Sep 18, 11:00 AM

atul updated the diff for D9209: [native] Forward `searchInputRef` from `ChatThreadList` to `ChatThreadListSearch`.

merge conflicts

Mon, Sep 18, 10:33 AM

atul updated the diff for D9215: [native] Remove `boundChatListData` from `useThreadListSearch` dep list.

rebase

Mon, Sep 18, 10:33 AM

atul updated the diff for D9212: [native] Consume `useThreadListSearch` in `ChatThreadList`.

rebase

Mon, Sep 18, 10:32 AM

atul updated the diff for D9211: [native] Memoize `flatList` in `ChatThreadList`.

rebase

Mon, Sep 18, 10:31 AM

atul updated the diff for D9210: [native] Add some basic memoization to `ChatThreadListSearch`.

rebase

Mon, Sep 18, 10:31 AM

atul updated the diff for D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.

rebase

Mon, Sep 18, 10:28 AM

atul added inline comments to D9209: [native] Forward `searchInputRef` from `ChatThreadList` to `ChatThreadListSearch`.

Mon, Sep 18, 10:27 AM

atul updated the diff for D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.

address feedback: early-return

Mon, Sep 18, 10:25 AM

atul added inline comments to D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.

Mon, Sep 18, 10:25 AM

atul updated the diff for D9208: [native] Remove `renderSearch` in `ChatThreadList` and inline `ChatThreadListSearch` directly.

rebase

Mon, Sep 18, 10:22 AM

atul updated the diff for D9207: [native] Move Reanimated code from `ChatThreadList` to `ChatThreadListSearch`.

rebase

Mon, Sep 18, 10:22 AM

atul added inline comments to D9207: [native] Move Reanimated code from `ChatThreadList` to `ChatThreadListSearch`.

Mon, Sep 18, 10:20 AM

atul updated the diff for D9206: [native] Move rest of Search views to `ChatThreadListSearch`.

rebase after resolve merge conflict

Mon, Sep 18, 10:20 AM

atul added inline comments to D9206: [native] Move rest of Search views to `ChatThreadListSearch`.

Mon, Sep 18, 9:16 AM

atul requested review of D9211: [native] Memoize `flatList` in `ChatThreadList`.

Mon, Sep 18, 9:15 AM

atul added a comment to D9211: [native] Memoize `flatList` in `ChatThreadList`.

In D9211#271261, @tomek wrote:

Have you tested if memoizing the list is beneficial? FlatList is already memoized internally (PureComponent) so wrapping it with memo shouldn't improve anything, but maybe I'm missing something.

Mon, Sep 18, 9:15 AM