atul (Atul)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since: Dec 29 2020, 8:08 PM (116 w, 4 d)
Roles: Administrator

FS_JGHeXwAEZWmZ.jpg (700×500 px, 54 KB)

FS_JGHgXwAAsCf2.jpg (700×500 px, 46 KB)

FS_JGHdWYAEPW_t.jpg (700×500 px, 54 KB)

FS_JGHdXwAMHbdF.jpg (700×500 px, 53 KB)

Recent Activity
View All

Yesterday

atul requested review of D7176: [keyserver] Don't gate `avatar` inclusion in `*LoggedInUserInfo` based on `codeVersion`.

Sat, Mar 25, 2:33 PM

Fri, Mar 24

atul updated the diff for D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.

fix

Fri, Mar 24, 2:00 PM

atul closed D7172: [cargo] Add `--release` flag to native library/tunnelbroker builds.

Fri, Mar 24, 12:30 PM

atul committed rCOMMf96f662517f4: [cargo] Add `--release` flag to native library/tunnelbroker builds (authored by atul).

[cargo] Add `--release` flag to native library/tunnelbroker builds

Fri, Mar 24, 12:30 PM

atul accepted D7173: Allow while(true) in the JS codebase.

Fri, Mar 24, 12:29 PM

atul added inline comments to D7120: Use notifications permission request API on Android 13 while keeping old behavior on older Androids..

Fri, Mar 24, 12:27 PM

atul updated the diff for D7172: [cargo] Add `--release` flag to native library/tunnelbroker builds.

rebase and land

Fri, Mar 24, 12:17 PM

atul added inline comments to D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.

Fri, Mar 24, 11:59 AM

atul updated the diff for D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.

don't include avatar if null

Fri, Mar 24, 11:57 AM

atul updated the summary of D7172: [cargo] Add `--release` flag to native library/tunnelbroker builds.

Fri, Mar 24, 11:47 AM

atul published D7172: [cargo] Add `--release` flag to native library/tunnelbroker builds for review.

Fri, Mar 24, 11:46 AM

atul added a comment to D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s.

Let's avoid setting avatar unless it exists, and only set it for a given UserInfo when that user calls the upstream methods to actually set their avatar. (At which point UPDATE_USER updates should help us avoid state inconsistencies.)

Fri, Mar 24, 11:37 AM

atul added a comment to D7164: [keyserver] Launch NSE for build 199 and above.

There shouldn't need to be any native release associated with this landing then, correct?

Fri, Mar 24, 11:33 AM

atul accepted D7164: [keyserver] Launch NSE for build 199 and above.

Fri, Mar 24, 11:33 AM

atul closed D7157: [keyserver] `JSON.parse()` stringified `avatar` in `fetchLoggedInUserInfo`.

Fri, Mar 24, 11:33 AM

atul committed rCOMM59208c2a222a: [keyserver] `JSON.parse()` stringified `avatar` in `fetchLoggedInUserInfo` (authored by atul).

[keyserver] `JSON.parse()` stringified `avatar` in `fetchLoggedInUserInfo`

Fri, Mar 24, 11:33 AM

atul updated the diff for D7157: [keyserver] `JSON.parse()` stringified `avatar` in `fetchLoggedInUserInfo`.

rebase and land

Fri, Mar 24, 11:32 AM

atul closed D7156: [lib] Update `CurrentUserInfo` on `updateUserAvatarActionTypes.success`.

Fri, Mar 24, 11:28 AM

atul committed rCOMM7927b6a593cb: [lib] Update `CurrentUserInfo` on `updateUserAvatarActionTypes.success` (authored by atul).

[lib] Update `CurrentUserInfo` on `updateUserAvatarActionTypes.success`

Fri, Mar 24, 11:28 AM

atul updated the diff for D7156: [lib] Update `CurrentUserInfo` on `updateUserAvatarActionTypes.success`.

rebase and land

Fri, Mar 24, 10:58 AM

atul resigned from D6930: [keyserver/lib] Set up responders, endpoints, and related functions to toggle a message pin.

Fri, Mar 24, 10:55 AM

atul resigned from D6929: [keyserver] Add a function to toggle the pin status of a message.

Fri, Mar 24, 10:54 AM

Thu, Mar 23

atul published D7162: [keyserver] Update `fetchUserInfos` to include `avatar`s in `GlobalUserInfo`s for review.

Thu, Mar 23, 5:30 PM

atul closed D7161: [ios] Add `--repo-update` to `pod install` command.

Thu, Mar 23, 2:08 PM

atul committed rCOMMe261fbedae47: [ios] Add `--repo-update` to `pod install` command (authored by atul).

[ios] Add `--repo-update` to `pod install` command

Thu, Mar 23, 2:08 PM

atul updated the diff for D7161: [ios] Add `--repo-update` to `pod install` command.

rebase and land

Thu, Mar 23, 2:07 PM

atul closed D7152: [keyserver] Introduce `updateUserAvatar` updater and use in `updateUserAvatarResponder`.

Thu, Mar 23, 1:42 PM

atul committed rCOMM50260a36931b: [keyserver] Introduce `updateUserAvatar` updater and use in… (authored by atul).

[keyserver] Introduce `updateUserAvatar` updater and use in…

Thu, Mar 23, 1:42 PM

atul updated the diff for D7152: [keyserver] Introduce `updateUserAvatar` updater and use in `updateUserAvatarResponder`.

rebase and land

Thu, Mar 23, 1:39 PM

atul updated the test plan for D7161: [ios] Add `--repo-update` to `pod install` command.

Thu, Mar 23, 1:38 PM

atul published D7161: [ios] Add `--repo-update` to `pod install` command for review.

Thu, Mar 23, 1:32 PM

atul added a comment to D7124: [web-db] add unit tests for draft store queries.

(Really great to see we're adding DB tests right off the bat)

Thu, Mar 23, 12:51 PM

atul added a comment to D5995: [native] clear database when malformation is detected.

Do you think we can get rid of these alerts now? Having to click through the alerts is kind of getting annoying on iOS Simulator.

Thu, Mar 23, 11:25 AM

atul updated the test plan for D7156: [lib] Update `CurrentUserInfo` on `updateUserAvatarActionTypes.success`.

Thu, Mar 23, 11:02 AM

atul updated the test plan for D7157: [keyserver] `JSON.parse()` stringified `avatar` in `fetchLoggedInUserInfo`.

Thu, Mar 23, 10:51 AM

atul published D7157: [keyserver] `JSON.parse()` stringified `avatar` in `fetchLoggedInUserInfo` for review.

Thu, Mar 23, 10:51 AM

atul published D7156: [lib] Update `CurrentUserInfo` on `updateUserAvatarActionTypes.success` for review.

Thu, Mar 23, 10:33 AM

Wed, Mar 22

atul published D7152: [keyserver] Introduce `updateUserAvatar` updater and use in `updateUserAvatarResponder` for review.

Wed, Mar 22, 11:21 PM

atul added a comment to D7126: [lib] Introduce `updateUserAvatar` to `user-actions`.

[will add screenshot shortly]

Wed, Mar 22, 10:09 PM

atul closed D7126: [lib] Introduce `updateUserAvatar` to `user-actions`.

Wed, Mar 22, 9:22 PM

atul committed rCOMM58a87534b387: [lib] Introduce `updateUserAvatar` to `user-actions` (authored by atul).

[lib] Introduce `updateUserAvatar` to `user-actions`

Wed, Mar 22, 9:22 PM

atul updated the diff for D7126: [lib] Introduce `updateUserAvatar` to `user-actions`.

rebase before landing

Wed, Mar 22, 9:19 PM

Tue, Mar 21

atul added a reverting change for rCOMM8b0ff97f2785: [native] Temporary changes for staff release: rCOMM56fdc906a28d: Revert "[native] Temporary changes for staff release".

Tue, Mar 21, 1:02 PM

atul committed rCOMM56fdc906a28d: Revert "[native] Temporary changes for staff release" (authored by atul).

Revert "[native] Temporary changes for staff release"

Tue, Mar 21, 1:01 PM

atul committed rCOMMd30d6383ffe2: [native] `codeVersion` -> 204 (authored by atul).

[native] `codeVersion` -> 204

Tue, Mar 21, 1:01 PM

atul committed rCOMM8b0ff97f2785: [native] Temporary changes for staff release (authored by atul).

[native] Temporary changes for staff release

Tue, Mar 21, 1:01 PM

atul committed rCOMMc707c5b9a7a6: [native] `codeVersion` -> 203 (authored by atul).

[native] `codeVersion` -> 203

Tue, Mar 21, 1:01 PM

atul requested review of D7126: [lib] Introduce `updateUserAvatar` to `user-actions`.

Tue, Mar 21, 9:38 AM

Mon, Mar 20

atul added a comment to D7111: [lib] Fix `TUnion`/`TInterface` imports.

Wonder if there's a way to catch this sort of thing with CI

Mon, Mar 20, 4:55 PM

atul closed D7111: [lib] Fix `TUnion`/`TInterface` imports.

Mon, Mar 20, 4:52 PM

atul committed rCOMM4935b4875f60: [lib] Fix `TUnion`/`TInterface` imports (authored by atul).

[lib] Fix `TUnion`/`TInterface` imports

Mon, Mar 20, 4:52 PM

atul closed D7109: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo` types.

Mon, Mar 20, 3:48 PM

atul committed rCOMMbcb8e9e4126e: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo`… (authored by atul).

[lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo`…

Mon, Mar 20, 3:48 PM

atul updated the diff for D7109: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo` types.

rebase and land

Mon, Mar 20, 3:45 PM

atul closed D7108: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding.

Mon, Mar 20, 3:26 PM

atul committed rCOMMe927714acf3f: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding (authored by atul).

[keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding

Mon, Mar 20, 3:26 PM

atul updated the diff for D7108: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding.

rebase and land

Mon, Mar 20, 3:23 PM

atul closed D7107: [lib] Introduce `updateUserAvatarRequestValidator`.

Mon, Mar 20, 3:19 PM

atul committed rCOMM4c6ac988e277: [lib] Introduce `updateUserAvatarRequestValidator` (authored by atul).

[lib] Introduce `updateUserAvatarRequestValidator`

Mon, Mar 20, 3:19 PM

atul updated the diff for D7107: [lib] Introduce `updateUserAvatarRequestValidator`.

rebase and land

Mon, Mar 20, 3:17 PM

atul accepted D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.

Mon, Mar 20, 3:10 PM

atul resigned from D6928: [keyserver] Introduce a new thread permission for pinning / unpinning messages.

Mon, Mar 20, 2:50 PM

atul added a comment to D7060: [lib] Introduce superblock padding.

In D7060#210983, @ashoat wrote:

{F436096}

Putting it in scripts/ sounds like a good idea to me!

Mon, Mar 20, 2:48 PM

atul requested changes to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.

One last change

Mon, Mar 20, 2:46 PM

atul added inline comments to D7054: [keyserver/lib] fetch avatar column from users table in fetchCurrentUserInfo.

Mon, Mar 20, 2:33 PM

atul added 1 blocking reviewer(s) for D7109: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo` types: ginsu.

Mon, Mar 20, 2:29 PM

atul published D7109: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo` types for review.

Mon, Mar 20, 2:29 PM

atul accepted D7105: Build files set-up for Android 13.

Mon, Mar 20, 1:29 PM

atul updated the diff for D7108: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding.

fix typo

Mon, Mar 20, 1:28 PM

atul published D7108: [keyserver] Introduce `updateUserAvatarResponder` endpoint scaffolding for review.

Mon, Mar 20, 1:08 PM

atul published D7107: [lib] Introduce `updateUserAvatarRequestValidator` for review.

Mon, Mar 20, 12:42 PM

atul closed D7098: [keyserver] Add `avatar` column to `threads` table of serverDB.

Mon, Mar 20, 7:37 AM

atul committed rCOMMc49378d39f63: [keyserver] Add `avatar` column to `threads` table of serverDB (authored by atul).

[keyserver] Add `avatar` column to `threads` table of serverDB

Mon, Mar 20, 7:37 AM

atul updated the diff for D7098: [keyserver] Add `avatar` column to `threads` table of serverDB.

rebase and land

Mon, Mar 20, 7:33 AM

atul closed D7097: [lib] Introduce `*AvatarDBContent` types.

Mon, Mar 20, 7:32 AM

atul committed rCOMM4fbb34a3f4cd: [lib] Introduce `*AvatarDBContent` types (authored by atul).

[lib] Introduce `*AvatarDBContent` types

Mon, Mar 20, 7:32 AM

atul updated the diff for D7097: [lib] Introduce `*AvatarDBContent` types.

address feedback (and sneak in ENSAvatarDBContent)

Mon, Mar 20, 7:21 AM

atul added inline comments to D7097: [lib] Introduce `*AvatarDBContent` types.

Mon, Mar 20, 7:18 AM

atul accepted D7061: [lib] Introduce combined padding interface.

Mon, Mar 20, 7:07 AM

Fri, Mar 17

atul accepted D7060: [lib] Introduce superblock padding.

The Notion doc was super helpful for understanding what's going on. Thanks for taking the time to write that all out.

Fri, Mar 17, 2:11 PM

atul added inline comments to D7059: [lib] Introduce PKCS#7 padding.

Fri, Mar 17, 1:08 PM

atul accepted D7059: [lib] Introduce PKCS#7 padding.

Thanks for including unit tests!

Fri, Mar 17, 1:01 PM

atul published D7098: [keyserver] Add `avatar` column to `threads` table of serverDB for review.

Fri, Mar 17, 12:51 PM

atul accepted D7091: [native] Fork Olm.

Fri, Mar 17, 12:49 PM

atul accepted D7089: [web][keyserver] Fork Olm.

Fri, Mar 17, 12:48 PM

atul added inline comments to D7097: [lib] Introduce `*AvatarDBContent` types.

Fri, Mar 17, 12:20 PM

atul published D7097: [lib] Introduce `*AvatarDBContent` types for review.

Fri, Mar 17, 12:19 PM

Thu, Mar 16

atul committed rCOMMa642904cfbf4: Revert "[native] Temporary changes for staff release" (authored by atul).

Revert "[native] Temporary changes for staff release"

Thu, Mar 16, 2:17 PM

atul committed rCOMM231f12c54514: [native] `codeVersion` -> 202 (authored by atul).

[native] `codeVersion` -> 202

Thu, Mar 16, 2:17 PM

atul committed rCOMMcd03dee294ec: [native] Temporary changes for staff release (authored by atul).

[native] Temporary changes for staff release

Thu, Mar 16, 2:17 PM

atul committed rCOMMdd2f634cda2d: [native] `codeVersion` -> 201 (authored by atul).

[native] `codeVersion` -> 201

Thu, Mar 16, 2:17 PM

atul accepted D7086: [lib] Add message type to "content must be defined" errors.

Thu, Mar 16, 2:00 PM

atul accepted D7085: [native] Add a C++ MessageSpec for SidebarSource.

Thu, Mar 16, 2:00 PM

atul added a reviewer for D7061: [lib] Introduce combined padding interface: tomek.

Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)

Thu, Mar 16, 1:37 PM

atul added a reviewer for D7060: [lib] Introduce superblock padding: tomek.

Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)

Thu, Mar 16, 1:37 PM

atul added a comment to D7059: [lib] Introduce PKCS#7 padding.

Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)

Thu, Mar 16, 1:36 PM

atul added a reviewer for D7059: [lib] Introduce PKCS#7 padding: tomek.

Thu, Mar 16, 1:36 PM

atul accepted D7080: [lib] Don't mention GENESIS in chat creation notifs.

Thu, Mar 16, 12:56 PM

atul accepted D7079: [lib] Don't refer to children of GENESIS as channels.

Thu, Mar 16, 12:56 PM

atul accepted D7084: [native] Remove length check when unpickling.

Thu, Mar 16, 12:55 PM