Feed Advanced Search
Oct 8 2024
Oct 8 2024
atul committed rCOMM82470964d9c9: [web] Flip the switch to strip member permissions from `web` (authored by atul).
[web] Flip the switch to strip member permissions from `web`
atul committed rCOMM1aad44e6fb68: [web] Introduce `web` migration to strip member permissions (authored by atul).
[web] Introduce `web` migration to strip member permissions
atul updated the diff for D13561: [web] Flip the switch to strip member permissions from `web`.
land
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.
land
atul updated the diff for D13561: [web] Flip the switch to strip member permissions from `web`.
exclude native placeholder migration
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.
include native migration here (was previously in flip the switch)
atul attached a referenced file: F2926333: Screenshot 2024-10-08 at 4.24.03 PM.png.
atul attached a referenced file: F2926335: Screenshot 2024-10-08 at 4.24.24 PM.png.
atul attached a referenced file: F2926336: Screenshot 2024-10-08 at 4.25.16 PM.png.
atul attached a referenced file: F2926371: Screenshot 2024-10-08 at 4.25.38 PM.png.
atul updated the summary of D13561: [web] Flip the switch to strip member permissions from `web`.
atul updated the test plan for D12790: [web] Introduce `web` migration to strip member permissions.
atul updated the test plan for D13561: [web] Flip the switch to strip member permissions from `web`.
atul abandoned D13566: Ignore.
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.
cast to migration function
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.
update ThreadStoreWithMemberPermissions to include thick threads
atul updated the diff for D13561: [web] Flip the switch to strip member permissions from `web`.
rebase
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.
remove console log and change flowfixme to flowignore
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.
rebase after type changes
Oct 2 2024
Oct 2 2024
atul added a comment to D12790: [web] Introduce `web` migration to strip member permissions.
(Will be available noon onwards tomorrow to work on this)
Oct 1 2024
Oct 1 2024
atul planned changes to D12790: [web] Introduce `web` migration to strip member permissions.
Will make some changes before landing eg
- Go from FlowFixMe to something like FlowIgnore
- Remove logs related skipping ThickThreads
atul added a comment to D12790: [web] Introduce `web` migration to strip member permissions.
Okay this migration now appears to work.
atul updated the diff for D13561: [web] Flip the switch to strip member permissions from `web`.
fix
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.
update migration to work with new migration system
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.
cut extraneous changes
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.
workaround that works for now (DRAFT)
atul requested review of D13566: Ignore.
atul updated the diff for D13561: [web] Flip the switch to strip member permissions from `web`.
bumped native persist version and added no-op migration
atul requested review of D13561: [web] Flip the switch to strip member permissions from `web`.
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.
address feedback (any-cast stripMemberPermissionsFromRawThreadInfos instead of $FlowIgnore)
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.
rebase
Jul 20 2024
Jul 20 2024
atul committed rCOMMb7d5e9a1db09: [native] Flip the switch to strip member permissions from `native` (authored by atul).
[native] Flip the switch to strip member permissions from `native`
Jul 19 2024
Jul 19 2024
atul requested review of D12811: [native] Flip the switch to strip member permissions from `native`.
atul committed rCOMM0748bce33c6f: [native] Introduce `native` migration to strip member permissions (authored by atul).
[native] Introduce `native` migration to strip member permissions
atul updated the diff for D12789: [native] Introduce `native` migration to strip member permissions.
address feedback (any-cast stripMemberPermissionsFromRawThreadInfos instead of $FlowIgnore)
atul committed rCOMMd25e29a0be1e: [lib] Rename `deprecatedMinimallyEncodeRawThreadInfo` ->… (authored by atul).
[lib] Rename `deprecatedMinimallyEncodeRawThreadInfo` ->…
atul updated the diff for D12799: [lib] Rename `deprecatedMinimallyEncodeRawThreadInfo` -> `minimallyEncodeRawThreadInfoWithMemberPermissions`.
rebase and land
Jul 18 2024
Jul 18 2024
atul added a comment to D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
Here's the followup diff I promised: D12799
atul committed rCOMM3cd205451a32: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients (authored by atul).
[keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients
atul updated the diff for D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
land
atul added inline comments to D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
atul committed rCOMMb84a90848053: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos` (authored by atul).
[lib] Introduce `stripMemberPermissionsFromRawThreadInfos`
atul updated the diff for D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.
rebase before landing
atul updated the diff for D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.
rebase BEFORE re-removing any-cast
atul committed rCOMMc4089cbcf0e1: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo` (authored by atul).
[lib] Introduce `stripMemberPermissionsFromRawThreadInfo`
atul updated the diff for D12763: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo`.
cherry-pick and land
atul committed rCOMM9fa6dd9ff9b7: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread` (authored by atul).
[lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`
atul committed rCOMM0561cfa7544f: [lib] Change type of `ThinRawThreadInfo.members` from… (authored by atul).
[lib] Change type of `ThinRawThreadInfo.members` from…
atul updated the diff for D12597: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`.
cherry-pick and land
atul added a comment to D12597: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`.
It's actually fine to land this as-is. If migration runs on RawThreadInfo that's already missing permissions, nothing will happen since stripPermissionsFromMemberInfo just won't really do anything:
atul added inline comments to D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
atul added inline comments to D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
atul updated the diff for D12790: [web] Introduce `web` migration to strip member permissions.
rebase
atul updated the diff for D12789: [native] Introduce `native` migration to strip member permissions.
rebase
atul updated the diff for D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.
rebase
atul updated the diff for D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
rebase
atul updated the diff for D12763: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo`.
rebase
atul updated the diff for D12597: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`.
rebase
atul updated the diff for D12594: [lib] Change type of `ThinRawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`.
rebase
Can drop this now, thanks @marcin !
atul updated the diff for D12763: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo`.
cherry-pick and land
atul committed rCOMM1dc8f0fe5186: [lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo` (authored by atul).
[lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo`
atul updated the diff for D12755: [lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo`.
cherry-pick and land
atul committed rCOMM2ab735a4abc7: [lib] Deprecate `minimallyEncodeRawThreadInfo` (authored by atul).
[lib] Deprecate `minimallyEncodeRawThreadInfo`
atul updated the diff for D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.
cherry-pick and land
atul added a comment to D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.
This is purely rename diff, so safe to cherry-pick and land out of order.
atul added a comment to D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.
Did you perhaps forget to remove the any-cast before diffing this up?
atul updated the diff for D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.
remove extraneous any-cast
Jul 17 2024
Jul 17 2024
atul requested review of D12790: [web] Introduce `web` migration to strip member permissions.
atul requested review of D12789: [native] Introduce `native` migration to strip member permissions.
atul requested review of D12788: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`.
atul added a comment to D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
Updated test plan after some more testing.
atul updated the test plan for D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
atul updated the diff for D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
fix logic, still need to do more testing
atul added inline comments to D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
atul planned changes to D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
Lot of things that need to be fixed up here.
atul updated the diff for D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.
rebase after addressing feedback in previous diffs in stack, still need to fix this diff up
atul updated the diff for D12763: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo`.
move changes to stripMemberPermissionsFromRawThreadInfo into this diff
atul updated the diff for D12755: [lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo`.
update diff with ESLint and validator unit test resolved.
atul updated the diff for D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.
update to address ESLint and failing validator test. flow issue(s) still expected.
atul updated the diff for D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.
rebase
atul requested review of D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.
still would like to see the ESLint fix moved to the diff where the issue is introduced.
atul updated the diff for D12597: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`.
fix ESLint issue
atul updated the diff for D12597: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`.
rebase after landing validator fix
atul updated the diff for D12594: [lib] Change type of `ThinRawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`.
rebase after landing validator fix.