fix
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Thu, Sep 21
address feedback
In D9262#272502, @ashoat wrote:In the past, we would need to update websites-responders.js when adding a new field to Redux state. Now that Redux state for the web is fetched via an API call, is there a different place we should be updating?
rebase
Wed, Sep 20
In D9251#272216, @ashoat wrote:Android failure is unrelated
Looks good, left comments but they're purely personal preference so feel free to land as is
In D9227#272137, @ashoat wrote:Can you create a GitHub issue on the Expo repo and link it here before landing?
Was there maybe some corresponding keyserver change that needed to be deployed before this release or something?
toggle withEnableSampleProfiling on DEBUG
In D9233#271801, @ashoat wrote:Okay, please make sure that upstream React Native does this on all builds too before landing!
In D9227#271710, @ashoat wrote:Is there a GitHub issue in Expo's GitHub repo for this?
Tue, Sep 19
rebase and land
(I think the profiler gets disabled on prod builds, I'll do a little more research)
In D9233#271796, @ashoat wrote:It seems sketchy to do this in production, especially given it's undocumented. I'm worried about the potential impact on performance. Can we restrict this change to dev builds?
@tomek Sorry, youāre totally right that this is useless. I tested performance with/without this diff in isolation and there was no difference.
Mon, Sep 18
rebase around D9211 to land
rebase around D9211 to land
land
merge conflicts
rebase
rebase
rebase
rebase
rebase
address feedback: early-return
rebase
rebase
rebase after resolve merge conflict
In D9211#271261, @tomek wrote:Have you tested if memoizing the list is beneficial? FlatList is already memoized internally (PureComponent) so wrapping it with memo shouldn't improve anything, but maybe I'm missing something.
Sun, Sep 17
type fn return values as mixed
rebase and land