Page MenuHomePhabricator
Feed Advanced Search

Today

atul updated the diff for D11752: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `MembersModal`.

rebase and land

Wed, Apr 24, 1:23 PM
atul updated the diff for D11751: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsMenu`.

land

Wed, Apr 24, 1:23 PM
atul updated the diff for D11750: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadMenu`.

land

Wed, Apr 24, 1:21 PM
atul updated the diff for D11749: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.

land

Wed, Apr 24, 1:21 PM
atul updated the diff for D11748: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.

land

Wed, Apr 24, 1:20 PM
atul updated the diff for D11747: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `EditThreadAvatar`.

land

Wed, Apr 24, 1:20 PM
atul updated the test plan for D11747: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `EditThreadAvatar`.
Wed, Apr 24, 1:18 PM
atul added a comment to D11747: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `EditThreadAvatar`.

I think you should consider having a test plan that actually verifies that this logic is correct.

Wed, Apr 24, 1:17 PM
atul closed D11746: [lib] Introduce `useThreadHasPermission` hook.
Wed, Apr 24, 1:00 PM
atul committed rCOMM2e193ebaa76c: [lib] Introduce `useThreadHasPermission` hook (authored by atul).
[lib] Introduce `useThreadHasPermission` hook
Wed, Apr 24, 1:00 PM
atul updated the diff for D11746: [lib] Introduce `useThreadHasPermission` hook.

memoize return value of useThreadHasPermission

Wed, Apr 24, 12:57 PM
atul updated the diff for D11746: [lib] Introduce `useThreadHasPermission` hook.

rebase before addressing feedback

Wed, Apr 24, 12:44 PM
atul added inline comments to D11746: [lib] Introduce `useThreadHasPermission` hook.
Wed, Apr 24, 12:42 PM
atul closed D11742: [lib] Pull `filterOutDisabledPermissions(permissionsBitmask)` out of `getCurrentUser`.
Wed, Apr 24, 12:38 PM
atul committed rCOMMec961262c8c1: [lib] Pull `filterOutDisabledPermissions(permissionsBitmask)` out of… (authored by atul).
[lib] Pull `filterOutDisabledPermissions(permissionsBitmask)` out of…
Wed, Apr 24, 12:38 PM
atul updated the diff for D11742: [lib] Pull `filterOutDisabledPermissions(permissionsBitmask)` out of `getCurrentUser`.

land trivial

Wed, Apr 24, 12:24 PM
atul closed D11741: [lib] Simplify `threadMemberHasPermission()`.
Wed, Apr 24, 12:23 PM
atul committed rCOMM24c5c5fc270d: [lib] Simplify `threadMemberHasPermission()` (authored by atul).
[lib] Simplify `threadMemberHasPermission()`
Wed, Apr 24, 12:23 PM
atul attached a referenced file: F1654016: 851623.png.
Wed, Apr 24, 12:22 PM
atul added inline comments to D11742: [lib] Pull `filterOutDisabledPermissions(permissionsBitmask)` out of `getCurrentUser`.
Wed, Apr 24, 12:22 PM
atul updated the diff for D11741: [lib] Simplify `threadMemberHasPermission()`.

land trivial

Wed, Apr 24, 12:14 PM
atul closed D11740: [lib] Rename `getMinimallyEncodedCurrentUser` -> `getCurrentUser`.
Wed, Apr 24, 11:00 AM
atul committed rCOMM748e7c47a7e0: [lib] Rename `getMinimallyEncodedCurrentUser` -> `getCurrentUser` (authored by atul).
[lib] Rename `getMinimallyEncodedCurrentUser` -> `getCurrentUser`
Wed, Apr 24, 11:00 AM
atul updated the diff for D11740: [lib] Rename `getMinimallyEncodedCurrentUser` -> `getCurrentUser`.

land trivial

Wed, Apr 24, 10:59 AM

Yesterday

atul requested review of D11754: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.
Tue, Apr 23, 3:14 PM
atul requested review of D11753: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings*`.
Tue, Apr 23, 2:05 PM
atul requested review of D11752: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `MembersModal`.
Tue, Apr 23, 1:53 PM
atul requested review of D11751: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsMenu`.
Tue, Apr 23, 1:52 PM
atul requested review of D11750: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadMenu`.
Tue, Apr 23, 1:51 PM
atul requested review of D11749: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.
Tue, Apr 23, 1:43 PM
atul requested review of D11748: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.
Tue, Apr 23, 1:34 PM
atul requested review of D11747: [web] Replace `threadHasPermission` with `useThreadHasPermission` in `EditThreadAvatar`.
Tue, Apr 23, 1:07 PM
atul requested review of D11746: [lib] Introduce `useThreadHasPermission` hook.
Tue, Apr 23, 12:51 PM
atul requested review of D11742: [lib] Pull `filterOutDisabledPermissions(permissionsBitmask)` out of `getCurrentUser`.
Tue, Apr 23, 11:11 AM
atul requested review of D11741: [lib] Simplify `threadMemberHasPermission()`.
Tue, Apr 23, 11:09 AM
atul requested review of D11740: [lib] Rename `getMinimallyEncodedCurrentUser` -> `getCurrentUser`.
Tue, Apr 23, 10:57 AM

Mon, Apr 22

atul closed D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field.
Mon, Apr 22, 6:34 PM
atul committed rCOMMbbac2afa8f62: [web][native][keyserver] Flip the switch to enable `specialRole` field (authored by atul).
[web][native][keyserver] Flip the switch to enable `specialRole` field
Mon, Apr 22, 6:34 PM
atul updated the diff for D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field.

change web minCodeVersion to NEXT_CODE_VERSION

Mon, Apr 22, 6:25 PM
atul updated the diff for D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field.

amend

Mon, Apr 22, 6:23 PM
atul closed D11188: [web] Redux migration to patch in `specialRole` field.
Mon, Apr 22, 1:31 PM
atul committed rCOMMfd79433a5873: [web] Redux migration to patch in `specialRole` field (authored by atul).
[web] Redux migration to patch in `specialRole` field
Mon, Apr 22, 1:31 PM
atul reopened D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field.
Mon, Apr 22, 1:31 PM
atul added a comment to D11188: [web] Redux migration to patch in `specialRole` field.

Did another test run and things appeared to work as expected.

Mon, Apr 22, 1:28 PM
atul updated the diff for D11188: [web] Redux migration to patch in `specialRole` field.

increment version after testing

Mon, Apr 22, 1:13 PM
atul updated the diff for D11188: [web] Redux migration to patch in `specialRole` field.

replace invariant in migration with null/undefined check, will re-test before landing

Mon, Apr 22, 12:47 PM
atul updated the diff for D11188: [web] Redux migration to patch in `specialRole` field.

remove version change from web migration

Mon, Apr 22, 12:43 PM
atul closed D11099: [native] Redux migration to patch in `specialRole` field.
Mon, Apr 22, 12:33 PM
atul committed rCOMM3722aa4c9ae6: [native] Redux migration to patch in `specialRole` field (authored by atul).
[native] Redux migration to patch in `specialRole` field
Mon, Apr 22, 12:33 PM
atul updated the diff for D11099: [native] Redux migration to patch in `specialRole` field.

land native

Mon, Apr 22, 12:27 PM
atul added a reverting change for D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field: rCOMM560e48ea3541: Revert "[web][native][keyserver] Flip the switch to enable `specialRole` field".
Mon, Apr 22, 12:26 PM
atul added a reverting change for rCOMMddd4c2b39b04: [web][native][keyserver] Flip the switch to enable `specialRole` field: rCOMM560e48ea3541: Revert "[web][native][keyserver] Flip the switch to enable `specialRole` field".
Mon, Apr 22, 12:26 PM
atul committed rCOMM560e48ea3541: Revert "[web][native][keyserver] Flip the switch to enable `specialRole` field" (authored by atul).
Revert "[web][native][keyserver] Flip the switch to enable `specialRole` field"
Mon, Apr 22, 12:26 PM
atul added inline comments to D11188: [web] Redux migration to patch in `specialRole` field.
Mon, Apr 22, 12:16 PM
atul closed D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field.
Mon, Apr 22, 12:12 PM
atul committed rCOMMddd4c2b39b04: [web][native][keyserver] Flip the switch to enable `specialRole` field (authored by atul).
[web][native][keyserver] Flip the switch to enable `specialRole` field
Mon, Apr 22, 12:12 PM
atul updated the diff for D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field.

land

Mon, Apr 22, 12:10 PM
atul added inline comments to D11188: [web] Redux migration to patch in `specialRole` field.
Mon, Apr 22, 11:34 AM
atul added inline comments to D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field.
Mon, Apr 22, 11:26 AM
atul updated the diff for D11204: [web][native][keyserver] Flip the switch to enable `specialRole` field.

amend

Mon, Apr 22, 11:20 AM
atul updated the diff for D11188: [web] Redux migration to patch in `specialRole` field.

amend

Mon, Apr 22, 11:19 AM
atul updated the diff for D11188: [web] Redux migration to patch in `specialRole` field.

amend

Mon, Apr 22, 11:14 AM
atul updated the diff for D11099: [native] Redux migration to patch in `specialRole` field.

also bump codeversions

Mon, Apr 22, 10:53 AM
atul updated the diff for D11099: [native] Redux migration to patch in `specialRole` field.

amend

Mon, Apr 22, 10:50 AM
atul reopened D11099: [native] Redux migration to patch in `specialRole` field.
Mon, Apr 22, 10:42 AM
atul requested review of D11712: [lib] Shim unsupported messages for `web`/`desktop`.
Mon, Apr 22, 10:31 AM
atul accepted D11707: [keyserver] Send farcaster_mutual UPDATE_RELATIONSHIP message when establishing Farcaster relationship.

Change looks good, but we should probably land something like D11712 first so web/desktop clients receive shimmed UNSUPPORTED messages?

Mon, Apr 22, 10:16 AM

Fri, Apr 19

atul accepted D11683: [native] implement UI for selecting a farcaster channel.
Fri, Apr 19, 2:01 PM
atul closed D11681: [keyserver] Remove `UPDATE_RELATIONSHIP.farcaster_mutual` messages from KeyserverDB.
Fri, Apr 19, 11:56 AM
atul committed rCOMMfd6440e367d5: [keyserver] Remove `UPDATE_RELATIONSHIP.farcaster_mutual` messages from… (authored by atul).
[keyserver] Remove `UPDATE_RELATIONSHIP.farcaster_mutual` messages from…
Fri, Apr 19, 11:56 AM
atul updated the diff for D11681: [keyserver] Remove `UPDATE_RELATIONSHIP.farcaster_mutual` messages from KeyserverDB.

rebase and land

Fri, Apr 19, 11:49 AM
atul closed D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.
Fri, Apr 19, 11:41 AM
atul committed rCOMM6a7fc7095ba9: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages (authored by atul).
[web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages
Fri, Apr 19, 11:41 AM
atul updated the diff for D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

rebase and alnd

Fri, Apr 19, 11:40 AM
atul closed D11669: [native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.
Fri, Apr 19, 11:37 AM
atul committed rCOMMbf26a3ce015a: [native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages (authored by atul).
[native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages
Fri, Apr 19, 11:37 AM
atul updated the diff for D11669: [native] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

rebase and land

Fri, Apr 19, 11:23 AM

Thu, Apr 18

atul added a comment to D11681: [keyserver] Remove `UPDATE_RELATIONSHIP.farcaster_mutual` messages from KeyserverDB.

@ashoat, would it make sense to backup prod DB before deploying this migration to keyserver as a precaution?

Thu, Apr 18, 1:46 PM
atul added inline comments to D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.
Thu, Apr 18, 1:41 PM
atul updated the diff for D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

fix typo + remove second invaraint

Thu, Apr 18, 1:40 PM
atul updated the diff for D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

get rid of first invariant

Thu, Apr 18, 1:38 PM
atul attached a referenced file: F1574319: fbacb2.png.
Thu, Apr 18, 1:37 PM
atul attached a referenced file: F1574322: 3f0434.png.
Thu, Apr 18, 1:37 PM
atul added inline comments to D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.
Thu, Apr 18, 1:37 PM
atul closed D11624: [lib] Fix `farcasterRelationshipRequestValidator`.
Thu, Apr 18, 1:26 PM
atul committed rCOMM003bf69d1b44: [lib] Fix `farcasterRelationshipRequestValidator` (authored by atul).
[lib] Fix `farcasterRelationshipRequestValidator`
Thu, Apr 18, 1:26 PM
atul closed D11612: [lib] Update `updateRelationshipInputValidator` to be union of `[traditional/farcaster]RelationshipRequestValidator`.
Thu, Apr 18, 1:26 PM
atul closed D11611: [keyserver] Update `updateRelationshipsResponder` to handle `RelationshipRequest`.
Thu, Apr 18, 1:26 PM
atul committed rCOMM811b86e47c66: [lib] Update `updateRelationshipInputValidator` to be union of `… (authored by atul).
[lib] Update `updateRelationshipInputValidator` to be union of `…
Thu, Apr 18, 1:26 PM
atul committed rCOMMa4d6f0cb4057: [keyserver] Update `updateRelationshipsResponder` to handle… (authored by atul).
[keyserver] Update `updateRelationshipsResponder` to handle…
Thu, Apr 18, 1:26 PM
atul closed D11610: [keyserver] Narrow `updateRelationshipInputValidator` to exclude `farcaster` action.
Thu, Apr 18, 1:26 PM
atul closed D11609: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action.
Thu, Apr 18, 1:26 PM
atul committed rCOMM8eef17ad3a41: [keyserver] Narrow `updateRelationshipInputValidator` to exclude `farcaster`… (authored by atul).
[keyserver] Narrow `updateRelationshipInputValidator` to exclude `farcaster`…
Thu, Apr 18, 1:26 PM
atul committed rCOMM1638313148ad: [lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action (authored by atul).
[lib] Narrow `TraditionalRelationshipRequest` to exclude 'farcaster' action
Thu, Apr 18, 1:26 PM
atul closed D11606: [lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest` with `userIDsToFID`.
Thu, Apr 18, 1:26 PM
atul committed rCOMM6e98c6bfd206: [lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest`… (authored by atul).
[lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest`…
Thu, Apr 18, 1:26 PM
atul updated the diff for D11624: [lib] Fix `farcasterRelationshipRequestValidator`.

rebase and land

Thu, Apr 18, 1:21 PM
atul updated the diff for D11612: [lib] Update `updateRelationshipInputValidator` to be union of `[traditional/farcaster]RelationshipRequestValidator`.

rebase and alnd

Thu, Apr 18, 1:21 PM
atul updated the diff for D11611: [keyserver] Update `updateRelationshipsResponder` to handle `RelationshipRequest`.

rebase and land

Thu, Apr 18, 1:21 PM
atul updated the diff for D11610: [keyserver] Narrow `updateRelationshipInputValidator` to exclude `farcaster` action.

rebase and land

Thu, Apr 18, 1:20 PM