HomePhabricator
Diffusion Comm 3cd205451a32

[keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients

Tags
None
Referenced Files
F2296843: aac4a5.png
Jul 18 2024, 2:45 PM
File Not Attached
F2296839: 9dfcd0.png
Jul 18 2024, 2:45 PM
File Not Attached
Subscribers
None

Description

[keyserver] Strip member.permissions for FUTURE_CODE_VERSION clients

Summary:
Add stripMemberPermissions option to rawThreadInfoFromServerThreadInfo to strip member permissions for new clients.


Depends on D12763

Test Plan:
Did some basic testing where I hardcoded stripMemberPermissions being passed to rawThreadInfoFromServerThreadInfo and set breakpoints to check output.

Will do additional testing with validators + after getting basic client migration working.

With stripMemberPermissions=false:

9dfcd0.png (1×2 px, 558 KB)

(can observe that each of the two members have permissions field set to string)

With stripMemberPermissions=true:

aac4a5.png (1×2 px, 411 KB)

Reviewers: ashoat, tomek

Reviewed By: ashoat

Differential Revision: https://phab.comm.dev/D12779

Details

Provenance
atulAuthored on Jul 18 2024, 2:29 PM
Reviewer
ashoat
Differential Revision
D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients
Parents
rCOMMb84a90848053: [lib] Introduce `stripMemberPermissionsFromRawThreadInfos`
Branches
Unknown
Tags
Unknown