This utility will be helpful in rawThreadInfoFromServerThreadInfo and client migrations.
Depends on D12758
Details
Details
Added basic unit test, will continue testing implicitly with rest of stack.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Love that you included tests! A bit confused about the invariant not matching the types – a couple questions inline
| lib/utils/member-info-utils.js | ||
|---|---|---|
| 19 ↗ | (On Diff #42306) | If we only expect to use this with ThinRawThreadInfo, why aren't we passing that type in here? |
| 20 ↗ | (On Diff #42306) | Shouldn't we at least be able to return ThinRawThreadInfo given the invariant below? |
| lib/utils/member-info-utils.js | ||
|---|---|---|
| 19 ↗ | (On Diff #42306) | Sorry, the changes to stripMemberPermissionsFromRawThreadInfo types got mistakenly included in another commit. Will move back into this commit. Will need to go through and rebase whole stack because of various ESLint issues which didn't seem to surface when I was running yarn eslint:all locally. |