[lib] Add `flow` suppression to `deprecatedDecodeMinimallyEncodedRawThreadInfo`
ClosedPublic
Actions

Authored by atul on Jun 27 2024, 2:16 PM.

Details

Reviewers

ashoat

Commits

rCOMMeae3437bda18: [lib] Add `flow` suppression to `deprecatedDecodeMinimallyEncodedRawThreadInfo`

Summary

Add flow suppression in deprecatedDecodeMinimallyEncodedRawThreadInfo before call to decodeMinimallyEncodedMemberInfo.

This code path will only be encountered during legacy migrations where member permissions ARE persisted so flow "issues" aren't relevant going forward because deprecatedDecodeMinimallyEncodedRawThreadInfo should never be called anywhere new.

This gets us down to 2 flow issues, both with minimallyEncodeRawThreadInfo.

Depends on D12599

Test Plan

Close reading, there are no logic changes... just flow suppressions to account for differing representation of RawThreadInfo.members

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jun 27 2024, 2:16 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 27 2024, 2:16 PM

atul published this revision for review.Jun 27 2024, 2:16 PM

Harbormaster failed remote builds in B29976: Diff 41775!Jun 27 2024, 2:28 PM

I think it's better to have type suppressions than to have to maintain the old set of types indefinitely. This makes sense to me

This revision is now accepted and ready to land.Jul 1 2024, 1:09 PM

resolve merge conflicts

Harbormaster failed remote builds in B30233: Diff 42156!Jul 9 2024, 11:19 AM

In D12601#357386, @ashoat wrote:

I think it's better to have type suppressions than to have to maintain the old set of types indefinitely. This makes sense to me

Sweet, that will make things a lot easier... especially with rawThreadInfoFromServerThreadInfo. Was having a lot of flow trouble previously trying to type that as ?LegacyThinRawThreadInfo | ?ThinRawThreadInfo | ?ThinRawThreadInfoWithMemberPermissions