Page MenuHomePhabricator
Differential D12755

[lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo`
ClosedPublic
Actions

Authored by atul on Jul 15 2024, 11:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 3:51 PM
Unknown Object (File)
Fri, Nov 1, 9:30 PM
Unknown Object (File)
Wed, Oct 23, 7:22 PM
Unknown Object (File)
Wed, Oct 23, 7:22 PM
Unknown Object (File)
Wed, Oct 23, 7:22 PM
Unknown Object (File)
Wed, Oct 23, 7:22 PM
Unknown Object (File)
Wed, Oct 23, 7:22 PM
Unknown Object (File)
Oct 22 2024, 7:34 PM
View All 60 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM1dc8f0fe5186: [lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo`
Summary

Add flow suppression to deprecatedMinimallyEncodeRawThreadInfo because it will only be called in contexts where member permissions do exist.

This function is only used in legacy migrations and in rawThreadInfoFromServerThreadInfo.

Depends on D12733

Test Plan

Close reading, there are no logic changes... just flow suppressions to account for differing representation of RawThreadInfo.members

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jul 15 2024, 11:38 AM
atul published this revision for review.Jul 15 2024, 11:39 AM
atul mentioned this in D12733: [lib] Deprecate `minimallyEncodeRawThreadInfo`.Jul 15 2024, 11:50 AM
Harbormaster failed remote builds in B30335: Diff 42297!Jul 15 2024, 11:53 AM
atul added a child revision: D12756: [lib] Move `stripPermissionsFromMemberInfo` out of `...-types.js` file.Jul 15 2024, 12:04 PM
ashoat requested changes to this revision.Jul 17 2024, 12:05 PM

Can you fix the CI issues please? The practice of immediately publishing your diff before waiting for CI should only be used for urgent diffs, and if you submit a diff for review with CI issues you should explain / justify why

This revision now requires changes to proceed.Jul 17 2024, 12:05 PM
ashoat mentioned this in D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.Jul 17 2024, 12:31 PM
atul updated this revision to Diff 42413.Jul 17 2024, 2:19 PM

update diff with ESLint and validator unit test resolved.

Harbormaster completed remote builds in B30437: Diff 42413.Jul 17 2024, 2:45 PM
ashoat accepted this revision.Jul 18 2024, 10:12 AM

Thank you!!

This revision is now accepted and ready to land.Jul 18 2024, 10:12 AM
atul updated this revision to Diff 42482.Jul 18 2024, 12:25 PM

cherry-pick and land

This revision was landed with ongoing or failed builds.Jul 18 2024, 12:34 PM
Closed by commit rCOMM1dc8f0fe5186: [lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM1dc8f0fe5186: [lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo`.
Harbormaster completed remote builds in B30481: Diff 42482.Jul 18 2024, 12:42 PM

Revision Contents
Changeset List

Diff 42483

View Options

lib/types/minimally-encoded-thread-permissions-types.js

Loading...