[lib] Fix construction of `RawThreadInfo` in `createPendingThread`
AbandonedPublic
Actions

Authored by atul on Jun 18 2024, 8:27 PM.

Details

Reviewers

ashoat
ginsu
tomek

Summary

Part of resolving the flow issues introduced in D12469.

Depends on D12470

Test Plan

NA, went from ~36 -> ~26 flow issues.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 18 2024, 8:27 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 18 2024, 8:40 PM

Harbormaster failed remote builds in B29767: Diff 41477!

atul requested review of this revision.Jun 19 2024, 1:42 PM

atul added a child revision: D12502: [lib] Resolve `flow` issues in `getRelativeMemberInfos`.Jun 19 2024, 8:27 PM

Abandoning in favor of stack starting with D12594 because lots of things have changed and there's not really 1:1 correspondence with old stack and new stack so I don't think it makes sense to update in place, change a bunch of child/parent diff relationships, etc.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

14 lines

Diff 41477

View Options

lib/shared/thread-utils.js

Show First 20 Lines • Show All 95 Lines • ▼ Show 20 Lines	const unboundStyles = {
okButton: {		okButton: {
backgroundColor: 'purpleButton',		backgroundColor: 'purpleButton',
borderRadius: 8,		borderRadius: 8,
},		},
};		};

export type NUXTipsOverlayParams = {		export type NUXTipsOverlayParams = {
+tipKey: NUXTip,		+tipKey: NUXTip,
+tooltipLocation: 'above' \| 'below' \| 'absolute',
};		};

export type NUXTipsOverlayProps<Route: NUXTipRouteNames> = {		export type NUXTipsOverlayProps<Route: NUXTipRouteNames> = {
+navigation: AppNavigationProp<Route>,		+navigation: AppNavigationProp<Route>,
+route: NavigationRoute<Route>,		+route: NavigationRoute<Route>,
};		};

const marginVertical: number = 20;		const marginVertical: number = 20;
▲ Show 20 Lines • Show All 80 Lines • ▼ Show 20 Lines	const onTipContainerLayout = React.useCallback(
} else {		} else {
const minWidth = width + 2 * extraRightSpace;		const minWidth = width + 2 * extraRightSpace;
tipHorizontalOffset.setValue((actualWidth - minWidth) / 2);		tipHorizontalOffset.setValue((actualWidth - minWidth) / 2);
}		}
},		},
[dimensions.width, initialCoordinates, tipHorizontalOffset],		[dimensions.width, initialCoordinates, tipHorizontalOffset],
);		);

const { tooltipLocation } = route.params;		const tipParams = getNUXTipParams(route.params.tipKey);
		const { tooltipLocation } = tipParams;

const baseTipContainerStyle = React.useMemo(() => {		const baseTipContainerStyle = React.useMemo(() => {
const { y, x, height, width } = initialCoordinates;		const { y, x, height, width } = initialCoordinates;

const style: WritableAnimatedStyleObj = {		const style: WritableAnimatedStyleObj = {
position: 'absolute',		position: 'absolute',
alignItems: 'center',		alignItems: 'center',
};		};
▲ Show 20 Lines • Show All 165 Lines • ▼ Show 20 Lines	function NUXTipsOverlay(props: NUXTipsOverlayProps<Route>) {
let triangleUp = null;		let triangleUp = null;
if (tooltipLocation === 'above') {		if (tooltipLocation === 'above') {
triangleDown = <View style={[styles.triangleDown, triangleStyle]} />;		triangleDown = <View style={[styles.triangleDown, triangleStyle]} />;
} else if (tooltipLocation === 'below') {		} else if (tooltipLocation === 'below') {
triangleUp = <View style={[styles.triangleUp, triangleStyle]} />;		triangleUp = <View style={[styles.triangleUp, triangleStyle]} />;
}		}

const onPressOk = React.useCallback(() => {		const onPressOk = React.useCallback(() => {
const callbackParams = getNUXTipParams(route.params.tipKey);		const { nextTip, exitingCallback } = tipParams;

const {
nextTip,
tooltipLocation: nextLocation,
nextRouteName,
exitingCallback,
} = callbackParams;
goBackOnce();		goBackOnce();

if (exitingCallback) {		if (exitingCallback) {
exitingCallback?.(navigation);		exitingCallback?.(navigation);
}		}

if (!nextTip \|\| !nextRouteName) {		if (!nextTip) {
return;		return;
}		}
		const { routeName } = getNUXTipParams(nextTip);

navigation.navigate<NUXTipRouteNames>({		navigation.navigate<NUXTipRouteNames>({
name: nextRouteName,		name: routeName,
params: {		params: {
tipKey: nextTip,		tipKey: nextTip,
tooltipLocation: nextLocation,
},		},
});		});
}, [goBackOnce, navigation, route.params.tipKey]);		}, [goBackOnce, navigation, tipParams]);

const button = React.useMemo(		const button = React.useMemo(
() =>		() =>
ButtonComponent ? (		ButtonComponent ? (
<View style={contentContainerStyle}>		<View style={contentContainerStyle}>
<Animated.View		<Animated.View
style={buttonStyle}		style={buttonStyle}
exiting={FadeOut.duration(animationDuration)}		exiting={FadeOut.duration(animationDuration)}
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines

[lib] Fix construction of `RawThreadInfo` in `createPendingThread`AbandonedPublicActions