Page MenuHomePhabricator
Differential D12472

[lib] Fix construction of `RawThreadInfo` in `createPendingThread`
AbandonedPublic
Actions

Authored by atul on Jun 18 2024, 8:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 1:51 PM
Unknown Object (File)
Feb 21 2025, 2:33 PM
Unknown Object (File)
Feb 20 2025, 7:27 PM
Unknown Object (File)
Feb 1 2025, 5:35 AM
Unknown Object (File)
Feb 1 2025, 5:34 AM
Unknown Object (File)
Jan 23 2025, 5:36 AM
Unknown Object (File)
Dec 19 2024, 7:02 AM
Unknown Object (File)
Dec 19 2024, 7:02 AM
View All 50 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Summary

Part of resolving the flow issues introduced in D12469.

Depends on D12470

Test Plan

NA, went from ~36 -> ~26 flow issues.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 18 2024, 8:27 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 18 2024, 8:40 PM
Harbormaster failed remote builds in B29767: Diff 41477!
atul requested review of this revision.Jun 19 2024, 1:42 PM
atul added a child revision: D12502: [lib] Resolve `flow` issues in `getRelativeMemberInfos`.Jun 19 2024, 8:27 PM
atul abandoned this revision.Jun 27 2024, 12:33 PM

Abandoning in favor of stack starting with D12594 because lots of things have changed and there's not really 1:1 correspondence with old stack and new stack so I don't think it makes sense to update in place, change a bunch of child/parent diff relationships, etc.

Revision Contents
Changeset List

PathSize
lib/
shared/
14 lines

Diff 41477

View Options

lib/shared/thread-utils.js

fn main() { fn main() {
tonic_build::compile_protos("../../shared/protos/identity.proto") tonic_build::compile_protos("../../shared/protos/identity.proto")
.unwrap_or_else(|e| panic!("Failed to compile protos {:?}", e)); .unwrap_or_else(|e| panic!("Failed to compile identity protos {:?}", e));
tonic_build::compile_protos("../../shared/protos/blob.proto")
.unwrap_or_else(|e| panic!("Failed to compile blob protos {:?}", e));
let _cxx_build = let _cxx_build =
cxx_build::bridge("src/lib.rs").flag_if_supported("-std=c++14"); cxx_build::bridge("src/lib.rs").flag_if_supported("-std=c++14");
println!("cargo:rerun-if-changed=src/hello.c"); println!("cargo:rerun-if-changed=src/hello.c");
} }