Differential D12756
[lib] Move `stripPermissionsFromMemberInfo` out of `...-types.js` file Authored by atul on Jul 15 2024, 12:04 PM. Tags None Referenced Files
Subscribers None
Details We're going to create some "higher order" utility functions using stripPermissionsFromMemberInfo, so figured it would make sense to pull out of types file and into its own utility file. For context, we're going to want to mirror the utility files in special-roles.js where we can patch RawThreadInfo and RawThreadInfos all in one go. This will make the changes to rawThreadInfoFromServerThreadInfo and the client migrations easier. Depends on D12755 This is just a move diff, unit tests still pass. Note: There's still a validator unit test that is expected to fail. Going to address that now that flow stuff is reolved.
Diff Detail
Event TimelineComment Actions Actually it seems to be explained in the Test Plan:
Looks like it's addressed in D12758 Comment Actions Ran yarn eslint:all, yarn flow:all, and yarn jest:all locally and confirmed that they all passed without issue. Will wait for ESLint & Flow & Jest workflow to pass before landing. |