Paths

Table of Contentst

Differential D12469

[lib] Change type of `RawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`
Needs RevisionPublic
Actions

Authored by atul on Tue, Jun 18, 1:26 PM.

Tags

None

Referenced Files

	F2120899: D12469.id41468.diff
	Wed, Jun 26, 3:24 PM

	Unknown Object (File)
	Tue, Jun 25, 7:36 PM

	Unknown Object (File)
	Mon, Jun 24, 7:59 PM

	Unknown Object (File)
	Sun, Jun 23, 7:13 PM

	Unknown Object (File)
	Wed, Jun 19, 4:48 AM

	Unknown Object (File)
	Wed, Jun 19, 4:48 AM

	Unknown Object (File)
	Wed, Jun 19, 4:48 AM

Subscribers

None

Details

Reviewers

ashoat
ginsu
tomek

Summary

This diff just makes the change to RawThreadInfo and introduces a bunch of flow issues which will be addressed in the rest of the stack.

Test Plan

NA, will land along with rest of stack to ensure no flow issues.

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Tue, Jun 18, 1:26 PM

atul added a child revision: D12470: [lib] Remove `member.permissions` from `RawThreadInfo` test data.Tue, Jun 18, 1:33 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Jun 18, 1:38 PM

Harbormaster failed remote builds in B29759: Diff 41467!

atul requested review of this revision.Tue, Jun 18, 1:42 PM

Flow errors

This revision now requires changes to proceed.Tue, Jun 18, 2:18 PM

atul mentioned this in D12472: [lib] Fix construction of `RawThreadInfo` in `createPendingThread`.Tue, Jun 18, 8:27 PM

atul mentioned this in D12502: [lib] Resolve `flow` issues in `getRelativeMemberInfos`.Wed, Jun 19, 8:27 PM

Revision Contents
Changeset List

Path

Size

lib/

types/

minimally-encoded-thread-permissions-types.js

2 lines

Diff 41467

lib/types/minimally-encoded-thread-permissions-types.js

Loading...