[lib] Change type of `ThinRawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`
Needs ReviewPublic
Actions

Authored by atul on Thu, Jun 27, 12:31 PM.

Details

Reviewers

ashoat

Summary

Start of stack replacing stack that started with D12469.

This diff makes the change to ThinRawThreadInfo.members which intentionally introduces flow issues which will be addressed in the rest of the stack.

Also snuck in stripping out MemberInfo.permissions from test data to reduce flow noise.

We're at 5 flow issues instead of the ~64 we had after D12469. Think this is largely due to stack ending in D12496, but will check each of the places with flow issues in previous stack to make sure nothing is broken quietly.

Depends on D12554

Test Plan

NA, flow.

This change ONLY changes flow types. We still need to update validators, persisted data, keyserver endpoint, client migrations, etc. which will be handled in subsequent diffs.

Diff Detail

Repository

rCOMM Comm

Branch

july26 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Thu, Jun 27, 12:31 PM

Herald added a subscriber: tomek. · View Herald TranscriptThu, Jun 27, 12:31 PM

atul mentioned this in D12469: [lib] Change type of `RawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`.Thu, Jun 27, 12:32 PM

atul mentioned this in D12470: [lib] Remove `member.permissions` from `RawThreadInfo` test data.

atul mentioned this in D12472: [lib] Fix construction of `RawThreadInfo` in `createPendingThread`.

atul mentioned this in D12502: [lib] Resolve `flow` issues in `getRelativeMemberInfos`.

atul mentioned this in D12557: [lib] Change return type of `minimallyEncodeRawThreadInfo` to `RawThreadInfoWithMemberPermissions`.Thu, Jun 27, 12:37 PM

atul mentioned this in D12573: [lib] Change `decodeMinimallyEncodedRawThreadInfo` argument type to `RawThreadInfoWithMemberPermissions`.

atul mentioned this in D12574: [native] Add `$FlowIgnore` annotation to migration 61.

Some reminders to myself from abandoned stack that stack starting with this diff will replace:

https://phab.comm.dev/D12557#356476
https://phab.comm.dev/D12574#356485

will need to update validator AND make sure we have validators for previous/new ThinRawThreadInfo.members included in convertClientDBThreadInfoToRawThreadInfo to avoid breaking clients. This is crucial because convertClientDBThreadInfoToRawThreadInfo is run once upon client upgrade before migrations in persist.jsare run. This is what broke things with removing .isDefault migration.