Paths

Table of Contentst

-
lib/
-
permissions/
-
minimally-encoded-raw-thread-info-validators.js
-
utils/
-
thread-ops-utils.js

[lib] Fix up client ThreadStore validation
ClosedPublic
Actions

Authored by ashoat on Jun 19 2024, 5:16 PM.

Details

Reviewers

kamil
marcin

Commits

rCOMMf006ec332ed1: [lib] Fix up client ThreadStore validation

Summary

I noticed we use tcomb validators on the client side here, so I figured it would be good to fix them before we insert any ThickRawThreadInfos into SQLite.

Depends on D12495

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 19 2024, 5:16 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 19 2024, 5:16 PM

ashoat mentioned this in D12495: [lib] Introduce RawThickThreadInfo type.Jun 19 2024, 5:26 PM

Harbormaster completed remote builds in B29800: Diff 41532.Jun 19 2024, 6:32 PM

ashoat requested review of this revision.Jun 19 2024, 6:32 PM

marcin added a child revision: D12539: Utilise subscription from ThickMemberInfo when building a notif.Jun 21 2024, 4:46 AM

marcin accepted this revision.Jun 24 2024, 10:20 AM

This revision is now accepted and ready to land.Jun 24 2024, 10:20 AM

Closed by commit rCOMMf006ec332ed1: [lib] Fix up client ThreadStore validation (authored by ashoat). · Explain WhyJun 26 2024, 11:39 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMf006ec332ed1: [lib] Fix up client ThreadStore validation.

atul mentioned this in D12594: [lib] Change type of `ThinRawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`.Jun 27 2024, 12:31 PM

atul mentioned this in rCOMM0561cfa7544f: [lib] Change type of `ThinRawThreadInfo.members` from….Jul 18 2024, 1:37 PM

Revision Contents
Changeset List

Path

Size

lib/

permissions/

minimally-encoded-raw-thread-info-validators.js

15 lines

utils/

thread-ops-utils.js

6 lines

Diff 41733

View Options

lib/permissions/minimally-encoded-raw-thread-info-validators.js

#pragma once		#pragma once

#include "../CryptoTools/Persist.h"		#include "../CryptoTools/Persist.h"
#include "entities/CommunityInfo.h"		#include "entities/CommunityInfo.h"
#include "entities/Draft.h"		#include "entities/Draft.h"
		#include "entities/IntegrityThreadHash.h"
#include "entities/KeyserverInfo.h"		#include "entities/KeyserverInfo.h"
#include "entities/Message.h"		#include "entities/Message.h"
#include "entities/MessageStoreThread.h"		#include "entities/MessageStoreThread.h"
#include "entities/MessageToDevice.h"		#include "entities/MessageToDevice.h"
#include "entities/OlmPersistAccount.h"		#include "entities/OlmPersistAccount.h"
#include "entities/OlmPersistSession.h"		#include "entities/OlmPersistSession.h"
#include "entities/PersistItem.h"		#include "entities/PersistItem.h"
#include "entities/Report.h"		#include "entities/Report.h"
▲ Show 20 Lines • Show All 59 Lines • ▼ Show 20 Lines	public:
virtual void replaceKeyserver(const KeyserverInfo &keyserver_info) const = 0;		virtual void replaceKeyserver(const KeyserverInfo &keyserver_info) const = 0;
virtual void removeKeyservers(const std::vector<std::string> &ids) const = 0;		virtual void removeKeyservers(const std::vector<std::string> &ids) const = 0;
virtual void removeAllKeyservers() const = 0;		virtual void removeAllKeyservers() const = 0;
virtual std::vector<KeyserverInfo> getAllKeyservers() const = 0;		virtual std::vector<KeyserverInfo> getAllKeyservers() const = 0;
virtual void replaceCommunity(const CommunityInfo &community_info) const = 0;		virtual void replaceCommunity(const CommunityInfo &community_info) const = 0;
virtual void removeCommunities(const std::vector<std::string> &ids) const = 0;		virtual void removeCommunities(const std::vector<std::string> &ids) const = 0;
virtual void removeAllCommunities() const = 0;		virtual void removeAllCommunities() const = 0;
virtual std::vector<CommunityInfo> getAllCommunities() const = 0;		virtual std::vector<CommunityInfo> getAllCommunities() const = 0;
		virtual void replaceIntegrityThreadHashes(
		const std::vector<IntegrityThreadHash> &thread_hashes) const = 0;
		virtual void
		removeIntegrityThreadHashes(const std::vector<std::string> &ids) const = 0;
		virtual void removeAllIntegrityThreadHashes() const = 0;
		virtual std::vector<IntegrityThreadHash>
		getAllIntegrityThreadHashes() const = 0;
virtual void beginTransaction() const = 0;		virtual void beginTransaction() const = 0;
virtual void commitTransaction() const = 0;		virtual void commitTransaction() const = 0;
virtual void rollbackTransaction() const = 0;		virtual void rollbackTransaction() const = 0;
virtual int getContentAccountID() const = 0;		virtual int getContentAccountID() const = 0;
virtual int getNotifsAccountID() const = 0;		virtual int getNotifsAccountID() const = 0;
virtual std::vector<OlmPersistSession> getOlmPersistSessionsData() const = 0;		virtual std::vector<OlmPersistSession> getOlmPersistSessionsData() const = 0;
virtual std::optional<std::string>		virtual std::optional<std::string>
getOlmPersistAccountData(int accountID) const = 0;		getOlmPersistAccountData(int accountID) const = 0;
▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines