[lib] Introduce thickThreadTypes and ThickThreadType
ClosedPublic
Actions

Authored by ashoat on Wed, Jun 19, 5:09 PM.

Details

Reviewers

kamil
marcin

Commits

rCOMM2dd79253cac8: [lib] Introduce thickThreadTypes and ThickThreadType

Summary

These 3 thread types will cover all of the initial thick thread types.

Depends on D12487

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Wed, Jun 19, 5:09 PM

Herald added a subscriber: tomek. · View Herald TranscriptWed, Jun 19, 5:09 PM

ashoat added a child revision: D12489: [keyserver][lib] Update thread type assertion functions for thick/thread distinction.Wed, Jun 19, 5:10 PM

Harbormaster completed remote builds in B29792: Diff 41524.Wed, Jun 19, 5:52 PM

ashoat requested review of this revision.Wed, Jun 19, 5:52 PM

kamil accepted this revision.Thu, Jun 20, 2:19 AM

This revision is now accepted and ready to land.Thu, Jun 20, 2:19 AM

inka added a subscriber: inka.Fri, Jun 21, 5:56 AM

inka added inline comments.

lib/types/thread-types-enum.js
43–44 ↗	(On Diff #41524)	This comment should probably not reference `COMMUNITY_SECRET_SUBTHREAD` anymore

ashoat added inline comments.Wed, Jun 26, 11:23 AM

lib/types/thread-types-enum.js
43–44 ↗	(On Diff #41524)	Good catch!!

Closed by commit rCOMM2dd79253cac8: [lib] Introduce thickThreadTypes and ThickThreadType (authored by ashoat). · Explain WhyWed, Jun 26, 11:39 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM2dd79253cac8: [lib] Introduce thickThreadTypes and ThickThreadType.

Revision Contents
Changeset List

Path

Size

lib/

types/

thread-types-enum.js

21 lines

Diff 41725

View Options

lib/types/thread-types-enum.js

[lib] Introduce thickThreadTypes and ThickThreadTypeClosedPublicActions