[lib] Factor out defaultSubscription in createPendingThread
ClosedPublic
Actions

Authored by ashoat on Jun 19 2024, 5:14 PM.

Details

Reviewers

kamil
marcin
ginsu

Commits

rCOMM6f96acf98c3e: [lib] Factor out defaultSubscription in createPendingThread

Summary

I might want to revist this after @ginsu lands his related diff.

Depends on D12493

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 19 2024, 5:14 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 19 2024, 5:14 PM

ashoat added a child revision: D12495: [lib] Introduce RawThickThreadInfo type.Jun 19 2024, 5:15 PM

Harbormaster completed remote builds in B29798: Diff 41530.Jun 19 2024, 6:21 PM

ashoat requested review of this revision.Jun 19 2024, 6:21 PM

In D12459, I introduce defaultSubscription into subscription-types.js. Once I land that diff, might be good to use defaultSubscription from there

marcin accepted this revision.Jun 20 2024, 8:17 AM

This revision is now accepted and ready to land.Jun 20 2024, 8:17 AM

Closed by commit rCOMM6f96acf98c3e: [lib] Factor out defaultSubscription in createPendingThread (authored by ashoat). · Explain WhyJun 26 2024, 11:39 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6f96acf98c3e: [lib] Factor out defaultSubscription in createPendingThread.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

15 lines

Diff 41731

View Options

lib/shared/thread-utils.js

Show First 20 Lines • Show All 119 Lines • ▼ Show 20 Lines	versionBroadcast.onmessage = (event: MessageEvent) => {
}		}
};		};

// Start initializing the shared worker immediately		// Start initializing the shared worker immediately
void getCommSharedWorker();		void getCommSharedWorker();

const queryClient = new QueryClient();		const queryClient = new QueryClient();

const wagmiConfig = getWagmiConfig({ includeInjectedWallet: true });		const wagmiConfig = getWagmiConfig([
		'injected',
		'rainbow',
		'metamask',
		'coinbase',
		'walletconnect',
		]);

type BaseProps = {		type BaseProps = {
+location: {		+location: {
+pathname: string,		+pathname: string,
...		...
},		},
};		};
type Props = {		type Props = {
▲ Show 20 Lines • Show All 432 Lines • Show Last 20 Lines

[lib] Factor out defaultSubscription in createPendingThreadClosedPublicActions