[lib] Factor out defaultSubscription in createPendingThread
ClosedPublic
Actions

Authored by ashoat on Jun 19 2024, 5:14 PM.

Details

Reviewers

kamil
marcin
ginsu

Commits

rCOMM6f96acf98c3e: [lib] Factor out defaultSubscription in createPendingThread

Summary

I might want to revist this after @ginsu lands his related diff.

Depends on D12493

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 19 2024, 5:14 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 19 2024, 5:14 PM

ashoat added a child revision: D12495: [lib] Introduce RawThickThreadInfo type.Jun 19 2024, 5:15 PM

Harbormaster completed remote builds in B29798: Diff 41530.Jun 19 2024, 6:21 PM

ashoat requested review of this revision.Jun 19 2024, 6:21 PM

In D12459, I introduce defaultSubscription into subscription-types.js. Once I land that diff, might be good to use defaultSubscription from there

marcin accepted this revision.Jun 20 2024, 8:17 AM

This revision is now accepted and ready to land.Jun 20 2024, 8:17 AM

Closed by commit rCOMM6f96acf98c3e: [lib] Factor out defaultSubscription in createPendingThread (authored by ashoat). · Explain WhyJun 26 2024, 11:39 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6f96acf98c3e: [lib] Factor out defaultSubscription in createPendingThread.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

15 lines

Diff 41731

View Options

lib/shared/thread-utils.js

#pragma once		#pragma once

#include "../CryptoTools/Persist.h"		#include "../CryptoTools/Persist.h"
#include "entities/CommunityInfo.h"		#include "entities/CommunityInfo.h"
#include "entities/Draft.h"		#include "entities/Draft.h"
		#include "entities/IntegrityThreadHash.h"
#include "entities/KeyserverInfo.h"		#include "entities/KeyserverInfo.h"
#include "entities/Message.h"		#include "entities/Message.h"
#include "entities/MessageStoreThread.h"		#include "entities/MessageStoreThread.h"
#include "entities/MessageToDevice.h"		#include "entities/MessageToDevice.h"
#include "entities/OlmPersistAccount.h"		#include "entities/OlmPersistAccount.h"
#include "entities/OlmPersistSession.h"		#include "entities/OlmPersistSession.h"
#include "entities/PersistItem.h"		#include "entities/PersistItem.h"
#include "entities/Report.h"		#include "entities/Report.h"
▲ Show 20 Lines • Show All 59 Lines • ▼ Show 20 Lines	public:
virtual void replaceKeyserver(const KeyserverInfo &keyserver_info) const = 0;		virtual void replaceKeyserver(const KeyserverInfo &keyserver_info) const = 0;
virtual void removeKeyservers(const std::vector<std::string> &ids) const = 0;		virtual void removeKeyservers(const std::vector<std::string> &ids) const = 0;
virtual void removeAllKeyservers() const = 0;		virtual void removeAllKeyservers() const = 0;
virtual std::vector<KeyserverInfo> getAllKeyservers() const = 0;		virtual std::vector<KeyserverInfo> getAllKeyservers() const = 0;
virtual void replaceCommunity(const CommunityInfo &community_info) const = 0;		virtual void replaceCommunity(const CommunityInfo &community_info) const = 0;
virtual void removeCommunities(const std::vector<std::string> &ids) const = 0;		virtual void removeCommunities(const std::vector<std::string> &ids) const = 0;
virtual void removeAllCommunities() const = 0;		virtual void removeAllCommunities() const = 0;
virtual std::vector<CommunityInfo> getAllCommunities() const = 0;		virtual std::vector<CommunityInfo> getAllCommunities() const = 0;
		virtual void replaceIntegrityThreadHashes(
		const std::vector<IntegrityThreadHash> &thread_hashes) const = 0;
		virtual void
		removeIntegrityThreadHashes(const std::vector<std::string> &ids) const = 0;
		virtual void removeAllIntegrityThreadHashes() const = 0;
		virtual std::vector<IntegrityThreadHash>
		getAllIntegrityThreadHashes() const = 0;
virtual void beginTransaction() const = 0;		virtual void beginTransaction() const = 0;
virtual void commitTransaction() const = 0;		virtual void commitTransaction() const = 0;
virtual void rollbackTransaction() const = 0;		virtual void rollbackTransaction() const = 0;
virtual int getContentAccountID() const = 0;		virtual int getContentAccountID() const = 0;
virtual int getNotifsAccountID() const = 0;		virtual int getNotifsAccountID() const = 0;
virtual std::vector<OlmPersistSession> getOlmPersistSessionsData() const = 0;		virtual std::vector<OlmPersistSession> getOlmPersistSessionsData() const = 0;
virtual std::optional<std::string>		virtual std::optional<std::string>
getOlmPersistAccountData(int accountID) const = 0;		getOlmPersistAccountData(int accountID) const = 0;
▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines

[lib] Factor out defaultSubscription in createPendingThreadClosedPublicActions