Page MenuHomePhabricator

Introduce EncryptedNotifUtilsAPI and implement it on the keyserver
ClosedPublic

Authored by marcin on Jun 11 2024, 10:36 AM.
Tags
None
Referenced Files
F3148355: D12396.id42025.diff
Mon, Nov 4, 10:25 AM
Unknown Object (File)
Sun, Nov 3, 6:46 PM
Unknown Object (File)
Sat, Nov 2, 4:13 PM
Unknown Object (File)
Fri, Nov 1, 7:00 PM
Unknown Object (File)
Tue, Oct 22, 8:06 AM
Unknown Object (File)
Mon, Oct 21, 12:59 PM
Unknown Object (File)
Fri, Oct 18, 1:11 PM
Unknown Object (File)
Wed, Oct 16, 1:41 AM
Subscribers

Details

Summary

This differential introduces EncryptedNotifUtilsAPI. It serves the same purpose as olmAPI or sqliteAPI. During notification generation and encryption we will use the same utilities on all platforms but their implementations will be platform specific. This diff implements it for keyserver only for now. Future diffs will implement it on native and web as well.

Test Plan
  1. Flow
  2. Test all notifs for all platforms and large notifs as well.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lib/types/notif-types.js
2 ↗(On Diff #41213)

Nit: you seem to have accidentally cut a line break here

I would consider registering config for keyserver to be able to use encryptedNotifUtilsAPI directly - passing it as a param trough all these functions makes it messy. In the future, we'll also want sqliteAPI to be implemented on keyserver, but this is something we can discuss in the Linear follow-up task because right now Config type is designed specifically for web & native.

This revision is now accepted and ready to land.Jun 19 2024, 3:15 PM

I would consider registering config for keyserver to be able to use encryptedNotifUtilsAPI directly - passing it as a param trough all these functions makes it messy. In the future, we'll also want sqliteAPI to be implemented on keyserver, but this is something we can discuss in the Linear follow-up task because right now Config type is designed specifically for web & native.

Created: https://linear.app/comm/issue/ENG-8681/extend-config-type-so-that-it-can-be-used-on-the-kesyerver to track.