Page MenuHomePhabricator
Differential D12490

[lib] Add support for thick threads to baseCreatePendingSidebar
ClosedPublic
Actions

Authored by ashoat on Jun 19 2024, 5:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 5, 3:20 AM
Unknown Object (File)
Mon, Feb 24, 10:10 PM
Unknown Object (File)
Fri, Feb 21, 3:58 PM
Unknown Object (File)
Feb 16 2025, 4:13 PM
Unknown Object (File)
Feb 5 2025, 6:16 AM
Unknown Object (File)
Feb 1 2025, 5:36 AM
Unknown Object (File)
Feb 1 2025, 5:36 AM
Unknown Object (File)
Feb 1 2025, 5:34 AM
View All 61 Files
Subscribers
tomek

Details

Reviewers
kamil
marcin
Commits
rCOMMf4cabe77e2a0: [lib] Add support for thick threads to baseCreatePendingSidebar
Summary

We'll use a different thread type for sidebars in thick threads.

Additional changes will be necessary in createPendingThread, but I'll handle those separately in a later diff.

Depends on D12489

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
12 lines
types/
5 lines

Diff 41727

View Options

lib/shared/sidebar-utils.js

Show All 24 Lines "devDependencies": {
"@babel/cli": "^7.23.4", "@babel/cli": "^7.23.4",
"@babel/core": "^7.23.7", "@babel/core": "^7.23.7",
"@babel/node": "^7.22.19", "@babel/node": "^7.22.19",
"@babel/plugin-syntax-dynamic-import": "^7.8.3", "@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-class-properties": "^7.23.3", "@babel/plugin-transform-class-properties": "^7.23.3",
"@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4", "@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4",
"@babel/plugin-transform-object-rest-spread": "^7.23.4", "@babel/plugin-transform-object-rest-spread": "^7.23.4",
"@babel/plugin-transform-optional-chaining": "^7.23.4", "@babel/plugin-transform-optional-chaining": "^7.23.4",
"@babel/plugin-transform-private-methods": "^7.24.1",
"@babel/plugin-transform-runtime": "^7.23.7", "@babel/plugin-transform-runtime": "^7.23.7",
"@babel/preset-env": "^7.23.7", "@babel/preset-env": "^7.23.7",
"@babel/preset-flow": "^7.23.3", "@babel/preset-flow": "^7.23.3",
"@babel/preset-react": "^7.23.3", "@babel/preset-react": "^7.23.3",
"babel-jest": "^29.7.0", "babel-jest": "^29.7.0",
"babel-plugin-transform-import-meta": "2.2.1", "babel-plugin-transform-import-meta": "2.2.1",
"chokidar-cli": "^2.1.0", "chokidar-cli": "^2.1.0",
"concurrently": "^5.3.0", "concurrently": "^5.3.0",
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines
View Options

lib/types/thread-types-enum.js

Show All 24 Lines "devDependencies": {
"@babel/cli": "^7.23.4", "@babel/cli": "^7.23.4",
"@babel/core": "^7.23.7", "@babel/core": "^7.23.7",
"@babel/node": "^7.22.19", "@babel/node": "^7.22.19",
"@babel/plugin-syntax-dynamic-import": "^7.8.3", "@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-class-properties": "^7.23.3", "@babel/plugin-transform-class-properties": "^7.23.3",
"@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4", "@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4",
"@babel/plugin-transform-object-rest-spread": "^7.23.4", "@babel/plugin-transform-object-rest-spread": "^7.23.4",
"@babel/plugin-transform-optional-chaining": "^7.23.4", "@babel/plugin-transform-optional-chaining": "^7.23.4",
"@babel/plugin-transform-private-methods": "^7.24.1",
"@babel/plugin-transform-runtime": "^7.23.7", "@babel/plugin-transform-runtime": "^7.23.7",
"@babel/preset-env": "^7.23.7", "@babel/preset-env": "^7.23.7",
"@babel/preset-flow": "^7.23.3", "@babel/preset-flow": "^7.23.3",
"@babel/preset-react": "^7.23.3", "@babel/preset-react": "^7.23.3",
"babel-jest": "^29.7.0", "babel-jest": "^29.7.0",
"babel-plugin-transform-import-meta": "2.2.1", "babel-plugin-transform-import-meta": "2.2.1",
"chokidar-cli": "^2.1.0", "chokidar-cli": "^2.1.0",
"concurrently": "^5.3.0", "concurrently": "^5.3.0",
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines