Paths

Table of Contentst

Differential D12397

Move notification creaction and encryption to lib except for APNs noifs.
Needs ReviewPublic
Actions

Authored by marcin on Tue, Jun 11, 10:39 AM.

Tags

None

Referenced Files

	F2032876: D12397.id41214.diff
	Tue, Jun 18, 3:45 AM

	F2032852: D12397.id.diff
	Tue, Jun 18, 3:45 AM

	F2032831: D12397.diff
	Tue, Jun 18, 3:44 AM

	F2025922: D12397.diff
	Mon, Jun 17, 12:53 PM

Subscribers

Details

Reviewers

kamil
tomek

Summary

This differential uses EncryptedNotifsUtilsAPI to move notif generation and encryption to lib. APNs notifs are exception since in this case we will need to implement new types, creation and encryption from scratch instead of just smart copy-paste. It will be handled in separate diff.

Test Plan

Flow
Test all notifs for all platform and large notifs as well.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Tue, Jun 11, 10:39 AM

Herald added a subscriber: ashoat. · View Herald TranscriptTue, Jun 11, 10:39 AM

marcin added a parent revision: D12396: Introduce EncryptedNotifUtilsAPI and implement it on the keyserver.Tue, Jun 11, 10:40 AM

marcin added a child revision: D12398: Rename cookieID -> cryptoID and deviceToken -> deliveryID.Tue, Jun 11, 10:45 AM

Harbormaster completed remote builds in B29605: Diff 41214.Tue, Jun 11, 10:56 AM

marcin requested review of this revision.Tue, Jun 11, 10:56 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

364 lines

6 lines

306 lines

7 lines

	lib/		push/
	keyserver/	src/	push/

210 lines

lib/

push/

notif-creators.js

360 lines

types/

7 lines

Diff 41214

keyserver/src/push/crypto.js

Loading...

keyserver/src/push/rescind.js

Loading...

keyserver/src/push/send.js

Loading...

keyserver/src/push/utils.js

Loading...

lib/push/crypto.js

Loading...

lib/push/notif-creators.js

Loading...

lib/types/notif-types.js

Loading...