[keyserver] Remove threadTypes.LOCAL from newThreadRequestInputValidator
ClosedPublic
Actions

Authored by ashoat on Wed, Jun 19, 5:06 PM.

Details

Reviewers

kamil
marcin

Commits

rCOMMe0b423d3b444: [keyserver] Remove threadTypes.LOCAL from newThreadRequestInputValidator

Summary

Currently, LOCAL is the same value as COMMUNITY_SECRET_SUBTHREAD, so no changes should occur to validation as a result of this diff.

In a later diff, I'll reassign LOCAL to a new constant. Going forward, LOCAL will be used for thick threads only, which should never be created by a keyserver. So it makes sense to leave this out of newThreadRequestInputValidator.

Depends on D12482

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Wed, Jun 19, 5:06 PM

Herald added a subscriber: tomek. · View Herald TranscriptWed, Jun 19, 5:06 PM

ashoat added a child revision: D12484: [lib][native][web] createNewThread -> createNewThinThread.Wed, Jun 19, 5:06 PM

Harbormaster completed remote builds in B29787: Diff 41519.Wed, Jun 19, 5:24 PM

ashoat requested review of this revision.Wed, Jun 19, 5:24 PM

kamil accepted this revision.Thu, Jun 20, 2:10 AM

This revision is now accepted and ready to land.Thu, Jun 20, 2:10 AM

Closed by commit rCOMMe0b423d3b444: [keyserver] Remove threadTypes.LOCAL from newThreadRequestInputValidator (authored by ashoat). · Explain WhyWed, Jun 26, 11:39 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe0b423d3b444: [keyserver] Remove threadTypes.LOCAL from newThreadRequestInputValidator.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

thread-responders.js

1 line

Diff 41719

View Options

keyserver/src/responders/thread-responders.js

[keyserver] Remove threadTypes.LOCAL from newThreadRequestInputValidatorClosedPublicActions