Page MenuHomePhabricator

Implement notification types, creation and encryption for APNs notifications
Needs ReviewPublic

Authored by marcin on Thu, Jun 13, 9:05 AM.
Tags
None
Referenced Files
F2032878: D12429.id41292.diff
Tue, Jun 18, 3:45 AM
F2032854: D12429.id.diff
Tue, Jun 18, 3:45 AM
F2032829: D12429.diff
Tue, Jun 18, 3:44 AM
F2025949: D12429.diff
Mon, Jun 17, 1:08 PM
Subscribers

Details

Reviewers
kamil
tomek
Summary

This differential implements our own types for APNs notifications as well as notif construction and encryption.

Test Plan

In order to test this code we need to hack the keyserver since in order to send APNs notif we need apn.Notification object anyway (it is required by node-apn lib). The steps are:

  1. Apply this patch: https://gist.github.com/marcinwasowicz/1af0a2958830fd9eb080e639779b1628. It makes the keyserver use our own types and new code to build the notification but before sending it creates custom apn.Notification object and overwrites its headers and compile methods to return data from our own notification.
  2. Test that APNs notifications, rescind and badge updates work for both iOS and macos
  3. Flow (unrelatedly).

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-8282
Lint
No Lint Coverage
Unit
No Test Coverage