Page MenuHomePhabricator

Add encryptedNotifUtilsAPI on client platforms with mock encryption.
Needs ReviewPublic

Authored by marcin on Tue, Jun 25, 5:31 AM.
Tags
None
Referenced Files
F2137557: D12572.id41696.diff
Fri, Jun 28, 6:25 PM
Unknown Object (File)
Thu, Jun 27, 12:50 PM
Unknown Object (File)
Wed, Jun 26, 8:52 AM
Subscribers

Details

Reviewers
kamil
tomek
Summary

This differential introduces encryptedNotifUtilsAPI on the client platforms to smoothly use function from lib/push. Encryption implementation is mocked and will be replaced once we tackle notif session initialization.

Test Plan

Test plan for D12464 but without adding encrytpedNotifUtilsAPI implementation to the patch.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-8410
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin added inline comments.
native/push/encrypted-notif-utils-api.js
29

Current code for uploading data to blob service is tightly coupled to the ksyerver uploads table and expo-file-system library which I don't think it the case for e2e notifs so this code would require some refactoring to support e2e notifs case. We could move the current code that is on the keyserver to lib but this code uses fetch library. However @bartek told me that it might not work well on native. Therefore given the fact that we haven't even started notif session intialization between clients (which is far more important) I am willing to cut a scope here. Returning error message from this funciton won't crash notif generation and delivery. It will just be delivered without message infos if it exceeds push service limit.