Page MenuHomePhabricator

[lib] Temporarily switch LOCAL to COMMUNITY_SECRET_SUBTHREAD for pending threads
ClosedPublic

Authored by ashoat on Wed, Jun 19, 5:08 PM.
Tags
None
Referenced Files
F2124991: D12487.diff
Wed, Jun 26, 11:49 PM
F2116453: D12487.id41523.diff
Wed, Jun 26, 9:23 AM
Unknown Object (File)
Tue, Jun 25, 3:38 PM
Unknown Object (File)
Mon, Jun 24, 11:30 PM
Unknown Object (File)
Sun, Jun 23, 8:22 PM
Unknown Object (File)
Sun, Jun 23, 12:41 AM
Unknown Object (File)
Thu, Jun 20, 5:29 PM
Unknown Object (File)
Thu, Jun 20, 5:26 PM
Subscribers

Details

Summary

These two constants were hardcoded to be the same value. I used LOCAL instead of COMMUNITY_SECRET_SUBTHREAD in this case as a reminder to the author that we should be created thick threads here instead of thin threads eventually.

I'm ready to introduce a separate constant for LOCAL, but we'll need to do some additional work before we're able to switch to using it for new pending threads. For now I'll move this code to continue to use the same constant (COMMUNITY_SECRET_SUBTHREAD, which will stay as 4), but I'll return it back to using threadTypes.LOCAL once we're ready.

Depends on D12486

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable