Paths

Table of Contentst

Differential D12398

Rename cookieID -> cryptoID and deviceToken -> deliveryID
Needs ReviewPublic
Actions

Authored by marcin on Tue, Jun 11, 10:45 AM.

Tags

None

Referenced Files

	F2032877: D12398.id41215.diff
	Tue, Jun 18, 3:45 AM

	F2032853: D12398.id.diff
	Tue, Jun 18, 3:45 AM

	F2032830: D12398.diff
	Tue, Jun 18, 3:44 AM

	F2026133: D12398.diff
	Mon, Jun 17, 2:36 PM

	F2025207: D12398.diff
	Mon, Jun 17, 8:05 AM

Subscribers

Details

Reviewers

kamil
tomek

Summary

This differential renames cookieID -> cryptoID and deviceToken -> deliveryID in keyserver and lib push related files. After moving notif generation and encryption to lib deviceToken and cookieID are no longer valid they should be replaced with something more generic.

Test Plan

Flow
Test all notifs for all platforms and large notifs as well.

Diff Detail

Repository

Branch

marcin/eng-8282

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Tue, Jun 11, 10:45 AM

Herald added a subscriber: ashoat. · View Herald TranscriptTue, Jun 11, 10:45 AM

marcin added a parent revision: D12397: Move notification creaction and encryption to lib except for APNs noifs..Tue, Jun 11, 10:45 AM

Harbormaster completed remote builds in B29606: Diff 41215.Tue, Jun 11, 11:02 AM

marcin requested review of this revision.Tue, Jun 11, 11:02 AM

marcin added a child revision: D12427: Move android rescinds and badge updates to lib.Thu, Jun 13, 8:51 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

36 lines

22 lines

64 lines

2 lines

18 lines

lib/

push/

78 lines

notif-creators.js

24 lines

types/

10 lines

Diff 41215

keyserver/src/push/crypto.js

Loading...

keyserver/src/push/rescind.js

Loading...

keyserver/src/push/send.js

Loading...

keyserver/src/push/types.js

Loading...

keyserver/src/push/utils.js

Loading...

lib/push/crypto.js

Loading...

lib/push/notif-creators.js

Loading...

lib/types/notif-types.js

Loading...