deliveryID
AcceptedPublic
Actions

Authored by marcin on Tue, Jun 11, 10:45 AM.

Details

Reviewers

kamil
tomek

Summary

This differential renames cookieID -> cryptoID and deviceToken -> deliveryID in keyserver and lib push related files. After moving notif generation and encryption to lib deviceToken and cookieID are no longer valid they should be replaced with something more generic.

Test Plan

Flow
Test all notifs for all platforms and large notifs as well.

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-8282

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Tue, Jun 11, 10:45 AM

Herald added a subscriber: ashoat. · View Herald TranscriptTue, Jun 11, 10:45 AM

marcin added a parent revision: D12397: Move notification creaction and encryption to lib except for APNs noifs..Tue, Jun 11, 10:45 AM

Harbormaster completed remote builds in B29606: Diff 41215.Tue, Jun 11, 11:02 AM

marcin requested review of this revision.Tue, Jun 11, 11:02 AM

marcin added a child revision: D12427: Move android rescinds and badge updates to lib.Thu, Jun 13, 8:51 AM

Probably you know it better so up to you but for me recipientID seems better than cryptoID

This revision is now accepted and ready to land.Wed, Jun 19, 3:32 PM

Probably you know it better so up to you but for me recipientID seems better than cryptoID

cryptoID is the id of the olm session to use to encrypt notification. On the native olm sessions will be matched by deviceID which will also be the id of the recipient. But on the keyserver recipientID would rather mean deviceToken, byt encryption is done based on cookieID.