Page MenuHomePhabricator

Utilise subscription from ThickMemberInfo when building a notif
Needs ReviewPublic

Authored by marcin on Fri, Jun 21, 4:09 AM.
Tags
None
Referenced Files
F2122220: D12539.diff
Wed, Jun 26, 5:03 PM
F2120004: D12539.id41603.diff
Wed, Jun 26, 1:46 PM
Unknown Object (File)
Tue, Jun 25, 4:43 PM
Unknown Object (File)
Tue, Jun 25, 3:43 PM
Unknown Object (File)
Sun, Jun 23, 10:55 AM
Unknown Object (File)
Fri, Jun 21, 5:28 AM
Unknown Object (File)
Fri, Jun 21, 5:28 AM
Unknown Object (File)
Fri, Jun 21, 5:28 AM
Subscribers

Details

Reviewers
kamil
tomek
Summary

This differential extracts a common logic that uses thread subscription, user role and mentioning to decide whether to send a notif. Moreover this logic is used in the client-send code.

Test Plan
  1. Test that chat muting and user mentioning (also for ENS users) works on the keyserver from the notif perspective.
  2. To test the client, apply patch from D12477 and then:
    1. Without any changes there should be no notif payloads generated.
    2. Play around with hardcoding different configurations of thread subscriptions and examine content of generated notifs.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage