Page MenuHomePhabricator
Differential D12490

[lib] Add support for thick threads to baseCreatePendingSidebar
ClosedPublic
Actions

Authored by ashoat on Jun 19 2024, 5:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 5:44 AM
Unknown Object (File)
Wed, Apr 16, 9:12 AM
Unknown Object (File)
Wed, Apr 16, 4:05 AM
Unknown Object (File)
Tue, Apr 15, 7:54 PM
Unknown Object (File)
Tue, Apr 15, 5:18 AM
Unknown Object (File)
Sat, Apr 12, 5:12 AM
Unknown Object (File)
Mon, Apr 7, 8:29 PM
Unknown Object (File)
Mar 5 2025, 3:20 AM
View All 68 Files
Subscribers
tomek

Details

Reviewers
kamil
marcin
Commits
rCOMMf4cabe77e2a0: [lib] Add support for thick threads to baseCreatePendingSidebar
Summary

We'll use a different thread type for sidebars in thick threads.

Additional changes will be necessary in createPendingThread, but I'll handle those separately in a later diff.

Depends on D12489

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
12 lines
types/
5 lines

Diff 41727

View Options

lib/shared/sidebar-utils.js

Show All 13 Lines
import type { ClientReportCreationRequest } from './report-types.js'; import type { ClientReportCreationRequest } from './report-types.js';
import type { ClientDBThreadInfo, ThreadStore } from './thread-types.js'; import type { ClientDBThreadInfo, ThreadStore } from './thread-types.js';
import type { UserInfos } from './user-types.js'; import type { UserInfos } from './user-types.js';
import type { import type {
ClientDBCommunityInfo, ClientDBCommunityInfo,
ClientDBCommunityStoreOperation, ClientDBCommunityStoreOperation,
CommunityStoreOperation, CommunityStoreOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { ClientDBIntegrityThreadHash } from '../ops/integrity-store-ops.js'; import type {
ClientDBIntegrityThreadHash,
ClientDBIntegrityStoreOperation,
} from '../ops/integrity-store-ops.js';
import type { import type {
ClientDBKeyserverInfo, ClientDBKeyserverInfo,
ClientDBKeyserverStoreOperation, ClientDBKeyserverStoreOperation,
KeyserverStoreOperation, KeyserverStoreOperation,
} from '../ops/keyserver-store-ops.js'; } from '../ops/keyserver-store-ops.js';
import type { import type {
ClientDBMessageStoreOperation, ClientDBMessageStoreOperation,
MessageStoreOperation, MessageStoreOperation,
Show All 24 Lines
export type ClientDBStoreOperations = { export type ClientDBStoreOperations = {
+draftStoreOperations?: $ReadOnlyArray<ClientDBDraftStoreOperation>, +draftStoreOperations?: $ReadOnlyArray<ClientDBDraftStoreOperation>,
+threadStoreOperations?: $ReadOnlyArray<ClientDBThreadStoreOperation>, +threadStoreOperations?: $ReadOnlyArray<ClientDBThreadStoreOperation>,
+messageStoreOperations?: $ReadOnlyArray<ClientDBMessageStoreOperation>, +messageStoreOperations?: $ReadOnlyArray<ClientDBMessageStoreOperation>,
+reportStoreOperations?: $ReadOnlyArray<ClientDBReportStoreOperation>, +reportStoreOperations?: $ReadOnlyArray<ClientDBReportStoreOperation>,
+keyserverStoreOperations?: $ReadOnlyArray<ClientDBKeyserverStoreOperation>, +keyserverStoreOperations?: $ReadOnlyArray<ClientDBKeyserverStoreOperation>,
+communityStoreOperations?: $ReadOnlyArray<ClientDBCommunityStoreOperation>, +communityStoreOperations?: $ReadOnlyArray<ClientDBCommunityStoreOperation>,
+integrityStoreOperations?: $ReadOnlyArray<ClientDBIntegrityStoreOperation>,
}; };
export type ClientDBStore = { export type ClientDBStore = {
+messages: $ReadOnlyArray<ClientDBMessageInfo>, +messages: $ReadOnlyArray<ClientDBMessageInfo>,
+drafts: $ReadOnlyArray<ClientDBDraftInfo>, +drafts: $ReadOnlyArray<ClientDBDraftInfo>,
+threads: $ReadOnlyArray<ClientDBThreadInfo>, +threads: $ReadOnlyArray<ClientDBThreadInfo>,
+messageStoreThreads: $ReadOnlyArray<ClientDBThreadMessageInfo>, +messageStoreThreads: $ReadOnlyArray<ClientDBThreadMessageInfo>,
+reports: $ReadOnlyArray<ClientDBReport>, +reports: $ReadOnlyArray<ClientDBReport>,
Show All 17 Lines
View Options

lib/types/thread-types-enum.js

Show All 13 Lines
import type { ClientReportCreationRequest } from './report-types.js'; import type { ClientReportCreationRequest } from './report-types.js';
import type { ClientDBThreadInfo, ThreadStore } from './thread-types.js'; import type { ClientDBThreadInfo, ThreadStore } from './thread-types.js';
import type { UserInfos } from './user-types.js'; import type { UserInfos } from './user-types.js';
import type { import type {
ClientDBCommunityInfo, ClientDBCommunityInfo,
ClientDBCommunityStoreOperation, ClientDBCommunityStoreOperation,
CommunityStoreOperation, CommunityStoreOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { ClientDBIntegrityThreadHash } from '../ops/integrity-store-ops.js'; import type {
ClientDBIntegrityThreadHash,
ClientDBIntegrityStoreOperation,
} from '../ops/integrity-store-ops.js';
import type { import type {
ClientDBKeyserverInfo, ClientDBKeyserverInfo,
ClientDBKeyserverStoreOperation, ClientDBKeyserverStoreOperation,
KeyserverStoreOperation, KeyserverStoreOperation,
} from '../ops/keyserver-store-ops.js'; } from '../ops/keyserver-store-ops.js';
import type { import type {
ClientDBMessageStoreOperation, ClientDBMessageStoreOperation,
MessageStoreOperation, MessageStoreOperation,
Show All 24 Lines
export type ClientDBStoreOperations = { export type ClientDBStoreOperations = {
+draftStoreOperations?: $ReadOnlyArray<ClientDBDraftStoreOperation>, +draftStoreOperations?: $ReadOnlyArray<ClientDBDraftStoreOperation>,
+threadStoreOperations?: $ReadOnlyArray<ClientDBThreadStoreOperation>, +threadStoreOperations?: $ReadOnlyArray<ClientDBThreadStoreOperation>,
+messageStoreOperations?: $ReadOnlyArray<ClientDBMessageStoreOperation>, +messageStoreOperations?: $ReadOnlyArray<ClientDBMessageStoreOperation>,
+reportStoreOperations?: $ReadOnlyArray<ClientDBReportStoreOperation>, +reportStoreOperations?: $ReadOnlyArray<ClientDBReportStoreOperation>,
+keyserverStoreOperations?: $ReadOnlyArray<ClientDBKeyserverStoreOperation>, +keyserverStoreOperations?: $ReadOnlyArray<ClientDBKeyserverStoreOperation>,
+communityStoreOperations?: $ReadOnlyArray<ClientDBCommunityStoreOperation>, +communityStoreOperations?: $ReadOnlyArray<ClientDBCommunityStoreOperation>,
+integrityStoreOperations?: $ReadOnlyArray<ClientDBIntegrityStoreOperation>,
}; };
export type ClientDBStore = { export type ClientDBStore = {
+messages: $ReadOnlyArray<ClientDBMessageInfo>, +messages: $ReadOnlyArray<ClientDBMessageInfo>,
+drafts: $ReadOnlyArray<ClientDBDraftInfo>, +drafts: $ReadOnlyArray<ClientDBDraftInfo>,
+threads: $ReadOnlyArray<ClientDBThreadInfo>, +threads: $ReadOnlyArray<ClientDBThreadInfo>,
+messageStoreThreads: $ReadOnlyArray<ClientDBThreadMessageInfo>, +messageStoreThreads: $ReadOnlyArray<ClientDBThreadMessageInfo>,
+reports: $ReadOnlyArray<ClientDBReport>, +reports: $ReadOnlyArray<ClientDBReport>,
Show All 17 Lines