We want to freeze existing logic for use in migration and rawThreadInfoFromServerThreadInfo while making it clear that it shouldn't be used in the future.
Depends on D12597
Details
Details
- Reviewers
ashoat - Commits
- rCOMM2ab735a4abc7: [lib] Deprecate `minimallyEncodeRawThreadInfo`
Just a rename.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Just two questions:
We want to freeze existing logic for use in migration and rawThreadInfoFromServerThreadInfo while making it clear that it shouldn't be used in the future.
First: is rawThreadInfoFromServerThreadInfo just for the shimming logic that handles old clients?
Second: it looks like there's a Flow error here that doesn't show up in the parent diff. Any context?
Comment Actions
First: is rawThreadInfoFromServerThreadInfo just for the shimming logic that handles old clients?
Yes, so we can construct RawThreadInfo with member permissions for clients that still expect them. We will construct "new" RawThreadInfos by stripping out member permissions using same utility function that'll be used in client migrations.
Second: it looks like there's a Flow error here that doesn't show up in the parent diff. Any context?
Let me check
Comment Actions
Second: it looks like there's a Flow error here that doesn't show up in the parent diff. Any context?
The one flow issue I'm seeing is the following:
which is resolved in D12755
Comment Actions
Actually I must've gotten confused about the CI. I'm actually not seeing any Flow issues, but there do appear to be ESLint issues.
Can you get this green before you pass back to me?