Page MenuHomePhabricator
Differential D12733

[lib] Deprecate `minimallyEncodeRawThreadInfo`
ClosedPublic
Actions

Authored by atul on Jul 11 2024, 1:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 19, 2:50 PM
Unknown Object (File)
Tue, Mar 11, 2:38 PM
Unknown Object (File)
Fri, Mar 7, 3:54 AM
Unknown Object (File)
Mon, Mar 3, 6:20 AM
Unknown Object (File)
Mon, Mar 3, 6:20 AM
Unknown Object (File)
Mon, Mar 3, 6:20 AM
Unknown Object (File)
Mon, Mar 3, 6:20 AM
Unknown Object (File)
Fri, Feb 28, 12:41 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM2ab735a4abc7: [lib] Deprecate `minimallyEncodeRawThreadInfo`
Summary

We want to freeze existing logic for use in migration and rawThreadInfoFromServerThreadInfo while making it clear that it shouldn't be used in the future.

Depends on D12597

Test Plan

Just a rename.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jul 11 2024, 1:27 PM
Herald added a subscriber: tomek. · View Herald TranscriptJul 11 2024, 1:27 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 11 2024, 1:40 PM
Harbormaster failed remote builds in B30294: Diff 42242!
atul requested review of this revision.Jul 11 2024, 2:16 PM
ashoat requested changes to this revision.Jul 11 2024, 5:20 PM

Just two questions:

We want to freeze existing logic for use in migration and rawThreadInfoFromServerThreadInfo while making it clear that it shouldn't be used in the future.

First: is rawThreadInfoFromServerThreadInfo just for the shimming logic that handles old clients?

Second: it looks like there's a Flow error here that doesn't show up in the parent diff. Any context?

This revision now requires changes to proceed.Jul 11 2024, 5:20 PM
atul edited parent revisions, added: D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`; removed: D12597: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`.Jul 15 2024, 11:31 AM
atul added a child revision: D12755: [lib] Add `flow` suppression to `deprecatedMinimallyEncodeRawThreadInfo`.Jul 15 2024, 11:38 AM
atul added a comment.Jul 15 2024, 11:48 AM

First: is rawThreadInfoFromServerThreadInfo just for the shimming logic that handles old clients?

Yes, so we can construct RawThreadInfo with member permissions for clients that still expect them. We will construct "new" RawThreadInfos by stripping out member permissions using same utility function that'll be used in client migrations.

Second: it looks like there's a Flow error here that doesn't show up in the parent diff. Any context?

Let me check

atul requested review of this revision.Jul 15 2024, 11:50 AM

Second: it looks like there's a Flow error here that doesn't show up in the parent diff. Any context?

The one flow issue I'm seeing is the following:

f33e9f.png (1×2 px, 1001 KB)

which is resolved in D12755

ashoat requested changes to this revision.Jul 17 2024, 12:03 PM

Actually I must've gotten confused about the CI. I'm actually not seeing any Flow issues, but there do appear to be ESLint issues.

Can you get this green before you pass back to me?

This revision now requires changes to proceed.Jul 17 2024, 12:03 PM
atul updated this revision to Diff 42412.Jul 17 2024, 2:18 PM
atul added a parent revision: D12597: [lib] Fix construction of `ThinRawThreadInfo` in `createPendingThread`.

update to address ESLint and failing validator test. flow issue(s) still expected.

Harbormaster failed remote builds in B30436: Diff 42412!Jul 17 2024, 2:30 PM
ashoat accepted this revision.Jul 18 2024, 10:18 AM
This revision is now accepted and ready to land.Jul 18 2024, 10:18 AM
atul added a comment.Jul 18 2024, 12:12 PM

This is purely rename diff, so safe to cherry-pick and land out of order.

atul updated this revision to Diff 42480.Jul 18 2024, 12:12 PM

cherry-pick and land

This revision was landed with ongoing or failed builds.Jul 18 2024, 12:21 PM
Closed by commit rCOMM2ab735a4abc7: [lib] Deprecate `minimallyEncodeRawThreadInfo` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM2ab735a4abc7: [lib] Deprecate `minimallyEncodeRawThreadInfo`.
Harbormaster completed remote builds in B30480: Diff 42480.Jul 18 2024, 12:28 PM

Revision Contents
Changeset List

Diff 42481

View Options

lib/permissions/minimally-encoded-thread-permissions.test.js

Show All 17 Linesset(NATIVE_HDRS
"ReportStoreOperations.h" "ReportStoreOperations.h"
"DraftStoreOperations.h" "DraftStoreOperations.h"
"UserStoreOperations.h" "UserStoreOperations.h"
"KeyserverStoreOperations.h" "KeyserverStoreOperations.h"
"CommunityStoreOperations.h" "CommunityStoreOperations.h"
"IntegrityStoreOperations.h" "IntegrityStoreOperations.h"
"SyncedMetadataStoreOperations.h" "SyncedMetadataStoreOperations.h"
"AuxUserStoreOperations.h" "AuxUserStoreOperations.h"
"ThreadActivityStoreOperations.h"
) )
set(NATIVE_SRCS set(NATIVE_SRCS
"CommCoreModule.cpp" "CommCoreModule.cpp"
"CommUtilsModule.cpp" "CommUtilsModule.cpp"
"CommRustModule.cpp" "CommRustModule.cpp"
"CommConstants.cpp" "CommConstants.cpp"
) )
▲ Show 20 Lines • Show All 50 Lines • ▼ Show 20 Linesset(DATA_STORES_HDRS
${_data_stores_path}/MessageStore.h ${_data_stores_path}/MessageStore.h
${_data_stores_path}/ReportStore.h ${_data_stores_path}/ReportStore.h
${_data_stores_path}/UserStore.h ${_data_stores_path}/UserStore.h
${_data_stores_path}/KeyserverStore.h ${_data_stores_path}/KeyserverStore.h
${_data_stores_path}/CommunityStore.h ${_data_stores_path}/CommunityStore.h
${_data_stores_path}/IntegrityStore.h ${_data_stores_path}/IntegrityStore.h
${_data_stores_path}/SyncedMetadataStore.h ${_data_stores_path}/SyncedMetadataStore.h
${_data_stores_path}/AuxUserStore.h ${_data_stores_path}/AuxUserStore.h
${_data_stores_path}/ThreadActivityStore.h
) )
set(DATA_STORES_SRCS set(DATA_STORES_SRCS
${_data_stores_path}/DraftStore.cpp ${_data_stores_path}/DraftStore.cpp
${_data_stores_path}/ThreadStore.cpp ${_data_stores_path}/ThreadStore.cpp
${_data_stores_path}/MessageStore.cpp ${_data_stores_path}/MessageStore.cpp
${_data_stores_path}/ReportStore.cpp ${_data_stores_path}/ReportStore.cpp
${_data_stores_path}/UserStore.cpp ${_data_stores_path}/UserStore.cpp
${_data_stores_path}/KeyserverStore.cpp ${_data_stores_path}/KeyserverStore.cpp
${_data_stores_path}/CommunityStore.cpp ${_data_stores_path}/CommunityStore.cpp
${_data_stores_path}/IntegrityStore.cpp ${_data_stores_path}/IntegrityStore.cpp
${_data_stores_path}/SyncedMetadataStore.cpp ${_data_stores_path}/SyncedMetadataStore.cpp
${_data_stores_path}/AuxUserStore.cpp ${_data_stores_path}/AuxUserStore.cpp
${_data_stores_path}/ThreadActivityStore.cpp
) )
set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities) set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities)
set(BACKUP_OP_HDRS set(BACKUP_OP_HDRS
${_backup_op_path}/BackupOperationsExecutor.h ${_backup_op_path}/BackupOperationsExecutor.h
) )
set(BACKUP_OP_SRCS set(BACKUP_OP_SRCS
${_backup_op_path}/BackupOperationsExecutor.cpp ${_backup_op_path}/BackupOperationsExecutor.cpp
Show All 25 Lines
View Options

lib/shared/redux/deprecated-update-roles-and-permissions.js

Show All 17 Linesset(NATIVE_HDRS
"ReportStoreOperations.h" "ReportStoreOperations.h"
"DraftStoreOperations.h" "DraftStoreOperations.h"
"UserStoreOperations.h" "UserStoreOperations.h"
"KeyserverStoreOperations.h" "KeyserverStoreOperations.h"
"CommunityStoreOperations.h" "CommunityStoreOperations.h"
"IntegrityStoreOperations.h" "IntegrityStoreOperations.h"
"SyncedMetadataStoreOperations.h" "SyncedMetadataStoreOperations.h"
"AuxUserStoreOperations.h" "AuxUserStoreOperations.h"
"ThreadActivityStoreOperations.h"
) )
set(NATIVE_SRCS set(NATIVE_SRCS
"CommCoreModule.cpp" "CommCoreModule.cpp"
"CommUtilsModule.cpp" "CommUtilsModule.cpp"
"CommRustModule.cpp" "CommRustModule.cpp"
"CommConstants.cpp" "CommConstants.cpp"
) )
▲ Show 20 Lines • Show All 50 Lines • ▼ Show 20 Linesset(DATA_STORES_HDRS
${_data_stores_path}/MessageStore.h ${_data_stores_path}/MessageStore.h
${_data_stores_path}/ReportStore.h ${_data_stores_path}/ReportStore.h
${_data_stores_path}/UserStore.h ${_data_stores_path}/UserStore.h
${_data_stores_path}/KeyserverStore.h ${_data_stores_path}/KeyserverStore.h
${_data_stores_path}/CommunityStore.h ${_data_stores_path}/CommunityStore.h
${_data_stores_path}/IntegrityStore.h ${_data_stores_path}/IntegrityStore.h
${_data_stores_path}/SyncedMetadataStore.h ${_data_stores_path}/SyncedMetadataStore.h
${_data_stores_path}/AuxUserStore.h ${_data_stores_path}/AuxUserStore.h
${_data_stores_path}/ThreadActivityStore.h
) )
set(DATA_STORES_SRCS set(DATA_STORES_SRCS
${_data_stores_path}/DraftStore.cpp ${_data_stores_path}/DraftStore.cpp
${_data_stores_path}/ThreadStore.cpp ${_data_stores_path}/ThreadStore.cpp
${_data_stores_path}/MessageStore.cpp ${_data_stores_path}/MessageStore.cpp
${_data_stores_path}/ReportStore.cpp ${_data_stores_path}/ReportStore.cpp
${_data_stores_path}/UserStore.cpp ${_data_stores_path}/UserStore.cpp
${_data_stores_path}/KeyserverStore.cpp ${_data_stores_path}/KeyserverStore.cpp
${_data_stores_path}/CommunityStore.cpp ${_data_stores_path}/CommunityStore.cpp
${_data_stores_path}/IntegrityStore.cpp ${_data_stores_path}/IntegrityStore.cpp
${_data_stores_path}/SyncedMetadataStore.cpp ${_data_stores_path}/SyncedMetadataStore.cpp
${_data_stores_path}/AuxUserStore.cpp ${_data_stores_path}/AuxUserStore.cpp
${_data_stores_path}/ThreadActivityStore.cpp
) )
set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities) set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities)
set(BACKUP_OP_HDRS set(BACKUP_OP_HDRS
${_backup_op_path}/BackupOperationsExecutor.h ${_backup_op_path}/BackupOperationsExecutor.h
) )
set(BACKUP_OP_SRCS set(BACKUP_OP_SRCS
${_backup_op_path}/BackupOperationsExecutor.cpp ${_backup_op_path}/BackupOperationsExecutor.cpp
Show All 25 Lines
View Options

lib/shared/thread-utils.js

Show All 17 Linesset(NATIVE_HDRS
"ReportStoreOperations.h" "ReportStoreOperations.h"
"DraftStoreOperations.h" "DraftStoreOperations.h"
"UserStoreOperations.h" "UserStoreOperations.h"
"KeyserverStoreOperations.h" "KeyserverStoreOperations.h"
"CommunityStoreOperations.h" "CommunityStoreOperations.h"
"IntegrityStoreOperations.h" "IntegrityStoreOperations.h"
"SyncedMetadataStoreOperations.h" "SyncedMetadataStoreOperations.h"
"AuxUserStoreOperations.h" "AuxUserStoreOperations.h"
"ThreadActivityStoreOperations.h"
) )
set(NATIVE_SRCS set(NATIVE_SRCS
"CommCoreModule.cpp" "CommCoreModule.cpp"
"CommUtilsModule.cpp" "CommUtilsModule.cpp"
"CommRustModule.cpp" "CommRustModule.cpp"
"CommConstants.cpp" "CommConstants.cpp"
) )
▲ Show 20 Lines • Show All 50 Lines • ▼ Show 20 Linesset(DATA_STORES_HDRS
${_data_stores_path}/MessageStore.h ${_data_stores_path}/MessageStore.h
${_data_stores_path}/ReportStore.h ${_data_stores_path}/ReportStore.h
${_data_stores_path}/UserStore.h ${_data_stores_path}/UserStore.h
${_data_stores_path}/KeyserverStore.h ${_data_stores_path}/KeyserverStore.h
${_data_stores_path}/CommunityStore.h ${_data_stores_path}/CommunityStore.h
${_data_stores_path}/IntegrityStore.h ${_data_stores_path}/IntegrityStore.h
${_data_stores_path}/SyncedMetadataStore.h ${_data_stores_path}/SyncedMetadataStore.h
${_data_stores_path}/AuxUserStore.h ${_data_stores_path}/AuxUserStore.h
${_data_stores_path}/ThreadActivityStore.h
) )
set(DATA_STORES_SRCS set(DATA_STORES_SRCS
${_data_stores_path}/DraftStore.cpp ${_data_stores_path}/DraftStore.cpp
${_data_stores_path}/ThreadStore.cpp ${_data_stores_path}/ThreadStore.cpp
${_data_stores_path}/MessageStore.cpp ${_data_stores_path}/MessageStore.cpp
${_data_stores_path}/ReportStore.cpp ${_data_stores_path}/ReportStore.cpp
${_data_stores_path}/UserStore.cpp ${_data_stores_path}/UserStore.cpp
${_data_stores_path}/KeyserverStore.cpp ${_data_stores_path}/KeyserverStore.cpp
${_data_stores_path}/CommunityStore.cpp ${_data_stores_path}/CommunityStore.cpp
${_data_stores_path}/IntegrityStore.cpp ${_data_stores_path}/IntegrityStore.cpp
${_data_stores_path}/SyncedMetadataStore.cpp ${_data_stores_path}/SyncedMetadataStore.cpp
${_data_stores_path}/AuxUserStore.cpp ${_data_stores_path}/AuxUserStore.cpp
${_data_stores_path}/ThreadActivityStore.cpp
) )
set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities) set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities)
set(BACKUP_OP_HDRS set(BACKUP_OP_HDRS
${_backup_op_path}/BackupOperationsExecutor.h ${_backup_op_path}/BackupOperationsExecutor.h
) )
set(BACKUP_OP_SRCS set(BACKUP_OP_SRCS
${_backup_op_path}/BackupOperationsExecutor.cpp ${_backup_op_path}/BackupOperationsExecutor.cpp
Show All 25 Lines
View Options

lib/types/minimally-encoded-thread-permissions-types.js

Show All 17 Linesset(NATIVE_HDRS
"ReportStoreOperations.h" "ReportStoreOperations.h"
"DraftStoreOperations.h" "DraftStoreOperations.h"
"UserStoreOperations.h" "UserStoreOperations.h"
"KeyserverStoreOperations.h" "KeyserverStoreOperations.h"
"CommunityStoreOperations.h" "CommunityStoreOperations.h"
"IntegrityStoreOperations.h" "IntegrityStoreOperations.h"
"SyncedMetadataStoreOperations.h" "SyncedMetadataStoreOperations.h"
"AuxUserStoreOperations.h" "AuxUserStoreOperations.h"
"ThreadActivityStoreOperations.h"
) )
set(NATIVE_SRCS set(NATIVE_SRCS
"CommCoreModule.cpp" "CommCoreModule.cpp"
"CommUtilsModule.cpp" "CommUtilsModule.cpp"
"CommRustModule.cpp" "CommRustModule.cpp"
"CommConstants.cpp" "CommConstants.cpp"
) )
▲ Show 20 Lines • Show All 50 Lines • ▼ Show 20 Linesset(DATA_STORES_HDRS
${_data_stores_path}/MessageStore.h ${_data_stores_path}/MessageStore.h
${_data_stores_path}/ReportStore.h ${_data_stores_path}/ReportStore.h
${_data_stores_path}/UserStore.h ${_data_stores_path}/UserStore.h
${_data_stores_path}/KeyserverStore.h ${_data_stores_path}/KeyserverStore.h
${_data_stores_path}/CommunityStore.h ${_data_stores_path}/CommunityStore.h
${_data_stores_path}/IntegrityStore.h ${_data_stores_path}/IntegrityStore.h
${_data_stores_path}/SyncedMetadataStore.h ${_data_stores_path}/SyncedMetadataStore.h
${_data_stores_path}/AuxUserStore.h ${_data_stores_path}/AuxUserStore.h
${_data_stores_path}/ThreadActivityStore.h
) )
set(DATA_STORES_SRCS set(DATA_STORES_SRCS
${_data_stores_path}/DraftStore.cpp ${_data_stores_path}/DraftStore.cpp
${_data_stores_path}/ThreadStore.cpp ${_data_stores_path}/ThreadStore.cpp
${_data_stores_path}/MessageStore.cpp ${_data_stores_path}/MessageStore.cpp
${_data_stores_path}/ReportStore.cpp ${_data_stores_path}/ReportStore.cpp
${_data_stores_path}/UserStore.cpp ${_data_stores_path}/UserStore.cpp
${_data_stores_path}/KeyserverStore.cpp ${_data_stores_path}/KeyserverStore.cpp
${_data_stores_path}/CommunityStore.cpp ${_data_stores_path}/CommunityStore.cpp
${_data_stores_path}/IntegrityStore.cpp ${_data_stores_path}/IntegrityStore.cpp
${_data_stores_path}/SyncedMetadataStore.cpp ${_data_stores_path}/SyncedMetadataStore.cpp
${_data_stores_path}/AuxUserStore.cpp ${_data_stores_path}/AuxUserStore.cpp
${_data_stores_path}/ThreadActivityStore.cpp
) )
set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities) set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities)
set(BACKUP_OP_HDRS set(BACKUP_OP_HDRS
${_backup_op_path}/BackupOperationsExecutor.h ${_backup_op_path}/BackupOperationsExecutor.h
) )
set(BACKUP_OP_SRCS set(BACKUP_OP_SRCS
${_backup_op_path}/BackupOperationsExecutor.cpp ${_backup_op_path}/BackupOperationsExecutor.cpp
Show All 25 Lines
View Options

native/redux/persist.js

Loading...