Page MenuHomePhabricator
Differential D12470

[lib] Remove `member.permissions` from `RawThreadInfo` test data
AbandonedPublic
Actions

Authored by atul on Jun 18 2024, 1:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 18, 8:13 AM
Unknown Object (File)
Thu, Apr 17, 10:08 PM
Unknown Object (File)
Wed, Apr 16, 10:03 PM
Unknown Object (File)
Wed, Apr 9, 5:49 PM
Unknown Object (File)
Tue, Apr 8, 10:42 PM
Unknown Object (File)
Thu, Apr 3, 10:34 AM
Unknown Object (File)
Mar 10 2025, 7:30 PM
Unknown Object (File)
Feb 21 2025, 2:33 PM
View All 52 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Summary

There are places in unit tests where we construct RawThreadInfo.members and include permissions field. This diff just handles removing the permissions field from test data to reduce flow issues from ~64 -> ~36.

Depends on D12469

Test Plan

NA, reduced flow issues and tests continue to pass

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 18 2024, 1:33 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 18 2024, 1:46 PM
Harbormaster failed remote builds in B29760: Diff 41468!
atul requested review of this revision.Jun 18 2024, 4:03 PM
atul added a child revision: D12472: [lib] Fix construction of `RawThreadInfo` in `createPendingThread`.Jun 18 2024, 8:27 PM
atul abandoned this revision.Jun 27 2024, 12:33 PM

Abandoning in favor of stack starting with D12594 because lots of things have changed and there's not really 1:1 correspondence with old stack and new stack so I don't think it makes sense to update in place, change a bunch of child/parent diff relationships, etc.

Revision Contents
Changeset List

Diff 41468

View Options

lib/permissions/minimally-encoded-thread-permissions-test-data.js

Show First 20 Lines • Show All 217 Lines • ▼ Show 20 Lines return createPromiseAsJSIValue(
jsiStringToRustString(accessToken, innerRt), jsiStringToRustString(accessToken, innerRt),
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
}); });
} }
jsi::Value CommRustModule::getOutboundKeysForUserDevice( jsi::Value CommRustModule::getOutboundKeysForUser(
jsi::Runtime &rt, jsi::Runtime &rt,
jsi::String authUserID, jsi::String authUserID,
jsi::String authDeviceID, jsi::String authDeviceID,
jsi::String authAccessToken, jsi::String authAccessToken,
jsi::String userID, jsi::String userID) {
jsi::String deviceID) {
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [&, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [&, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); promise, this->jsInvoker_, innerRt);
identityGetOutboundKeysForUserDevice( identityGetOutboundKeysForUser(
jsiStringToRustString(authUserID, innerRt), jsiStringToRustString(authUserID, innerRt),
jsiStringToRustString(authDeviceID, innerRt), jsiStringToRustString(authDeviceID, innerRt),
jsiStringToRustString(authAccessToken, innerRt), jsiStringToRustString(authAccessToken, innerRt),
jsiStringToRustString(userID, innerRt), jsiStringToRustString(userID, innerRt),
jsiStringToRustString(deviceID, innerRt),
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
}); });
} }
jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) { jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) {
Show All 14 Lines
View Options

lib/permissions/special-roles.test.js

Show First 20 Lines • Show All 217 Lines • ▼ Show 20 Lines return createPromiseAsJSIValue(
jsiStringToRustString(accessToken, innerRt), jsiStringToRustString(accessToken, innerRt),
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
}); });
} }
jsi::Value CommRustModule::getOutboundKeysForUserDevice( jsi::Value CommRustModule::getOutboundKeysForUser(
jsi::Runtime &rt, jsi::Runtime &rt,
jsi::String authUserID, jsi::String authUserID,
jsi::String authDeviceID, jsi::String authDeviceID,
jsi::String authAccessToken, jsi::String authAccessToken,
jsi::String userID, jsi::String userID) {
jsi::String deviceID) {
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [&, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [&, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); promise, this->jsInvoker_, innerRt);
identityGetOutboundKeysForUserDevice( identityGetOutboundKeysForUser(
jsiStringToRustString(authUserID, innerRt), jsiStringToRustString(authUserID, innerRt),
jsiStringToRustString(authDeviceID, innerRt), jsiStringToRustString(authDeviceID, innerRt),
jsiStringToRustString(authAccessToken, innerRt), jsiStringToRustString(authAccessToken, innerRt),
jsiStringToRustString(userID, innerRt), jsiStringToRustString(userID, innerRt),
jsiStringToRustString(deviceID, innerRt),
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
}); });
} }
jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) { jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) {
Show All 14 Lines
View Options

lib/reducers/calendar-filters-reducer.test.js

Show First 20 Lines • Show All 217 Lines • ▼ Show 20 Lines return createPromiseAsJSIValue(
jsiStringToRustString(accessToken, innerRt), jsiStringToRustString(accessToken, innerRt),
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
}); });
} }
jsi::Value CommRustModule::getOutboundKeysForUserDevice( jsi::Value CommRustModule::getOutboundKeysForUser(
jsi::Runtime &rt, jsi::Runtime &rt,
jsi::String authUserID, jsi::String authUserID,
jsi::String authDeviceID, jsi::String authDeviceID,
jsi::String authAccessToken, jsi::String authAccessToken,
jsi::String userID, jsi::String userID) {
jsi::String deviceID) {
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [&, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [&, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); promise, this->jsInvoker_, innerRt);
identityGetOutboundKeysForUserDevice( identityGetOutboundKeysForUser(
jsiStringToRustString(authUserID, innerRt), jsiStringToRustString(authUserID, innerRt),
jsiStringToRustString(authDeviceID, innerRt), jsiStringToRustString(authDeviceID, innerRt),
jsiStringToRustString(authAccessToken, innerRt), jsiStringToRustString(authAccessToken, innerRt),
jsiStringToRustString(userID, innerRt), jsiStringToRustString(userID, innerRt),
jsiStringToRustString(deviceID, innerRt),
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
}); });
} }
jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) { jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) {
Show All 14 Lines
View Options

lib/reducers/integrity-reducer.test.js

Show First 20 Lines • Show All 217 Lines • ▼ Show 20 Lines return createPromiseAsJSIValue(
jsiStringToRustString(accessToken, innerRt), jsiStringToRustString(accessToken, innerRt),
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
}); });
} }
jsi::Value CommRustModule::getOutboundKeysForUserDevice( jsi::Value CommRustModule::getOutboundKeysForUser(
jsi::Runtime &rt, jsi::Runtime &rt,
jsi::String authUserID, jsi::String authUserID,
jsi::String authDeviceID, jsi::String authDeviceID,
jsi::String authAccessToken, jsi::String authAccessToken,
jsi::String userID, jsi::String userID) {
jsi::String deviceID) {
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [&, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [&, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); promise, this->jsInvoker_, innerRt);
identityGetOutboundKeysForUserDevice( identityGetOutboundKeysForUser(
jsiStringToRustString(authUserID, innerRt), jsiStringToRustString(authUserID, innerRt),
jsiStringToRustString(authDeviceID, innerRt), jsiStringToRustString(authDeviceID, innerRt),
jsiStringToRustString(authAccessToken, innerRt), jsiStringToRustString(authAccessToken, innerRt),
jsiStringToRustString(userID, innerRt), jsiStringToRustString(userID, innerRt),
jsiStringToRustString(deviceID, innerRt),
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
}); });
} }
jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) { jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) {
Show All 14 Lines
View Options

lib/shared/thread-utils.test.js

Loading...