Paths

Table of Contentst

Differential D12543

[keyserver] Use `threadIsWithBlockedUserOnlyWithoutAdminRoleCheck` instead of `threadFrozenDueToBlock` in `checkThreadsFrozen`
Needs ReviewPublic
Actions

Authored by atul on Fri, Jun 21, 2:39 PM.

Details

Reviewers

ashoat

Summary

Context: https://linear.app/comm/issue/ENG-7249/update-checkthreadsfrozen

We do sequential fetchThreadInfos to get communityThreadInfos so we can determine whether there is an admin without "sketchy" CHANGE_ROLE permission check.

Depends on D12502

Test Plan

flow + set some breakpoints and observed correct behavior:

Diff Detail

Repository

rCOMM Comm

Branch

july26 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Fri, Jun 21, 2:39 PM

atul published this revision for review.Fri, Jun 21, 2:39 PM

Harbormaster failed remote builds in B29881: Diff 41624!Fri, Jun 21, 2:52 PM

atul added a child revision: D12554: [lib] Remove `threadFrozenDueToBlock`, `threadOrParentThreadHasAdminRole` and `memberHadAdminPowers`.Mon, Jun 24, 10:40 AM

atul mentioned this in D12556: [lib] Remove `threadOrParentThreadHasAdminRole` and `memberHadAdminPowers`.Mon, Jun 24, 10:42 AM

rebase outside of flow stack

fix import

atul edited the test plan for this revision. (Show Details)Wed, Jun 26, 1:47 PM

atul removed a parent revision: D12502: [lib] Resolve `flow` issues in `getRelativeMemberInfos`.

Harbormaster failed remote builds in B29941: Diff 41735!Wed, Jun 26, 1:52 PM

Harbormaster completed remote builds in B29943: Diff 41737.Wed, Jun 26, 2:00 PM

atul removed reviewers: ginsu, tomek.Thu, Jun 27, 1:45 PM

atul added a parent revision: D12502: [lib] Resolve `flow` issues in `getRelativeMemberInfos`.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

thread-permission-fetchers.js

55 lines

lib/

shared/

thread-utils.js

3 lines

Diff 41737

View Options

keyserver/src/fetchers/thread-permission-fetchers.js