[lib] Move `stripPermissionsFromMemberInfo` out of `...-types.js` file
ClosedPublic
Actions

Authored by atul on Jul 15 2024, 12:04 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMMdc0975f965cb: [lib] Move `stripPermissionsFromMemberInfo` out of `...-types.js` file

Summary

We're going to create some "higher order" utility functions using stripPermissionsFromMemberInfo, so figured it would make sense to pull out of types file and into its own utility file.

For context, we're going to want to mirror the utility files in special-roles.js where we can patch RawThreadInfo and RawThreadInfos all in one go. This will make the changes to rawThreadInfoFromServerThreadInfo and the client migrations easier.

Depends on D12755

Test Plan

This is just a move diff, unit tests still pass. Note: There's still a validator unit test that is expected to fail. Going to address that now that flow stuff is reolved.

Diff Detail

Repository

rCOMM Comm

Branch

july9 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jul 15 2024, 12:04 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 15 2024, 12:22 PM

Harbormaster failed remote builds in B30337: Diff 42299!

atul requested review of this revision.Jul 15 2024, 12:24 PM

atul added a child revision: D12757: [lib] Introduce `memberInfoSansPermissionsValidator`.Jul 15 2024, 12:25 PM

atul added a child revision: D12758: [lib] Introduce `memberInfoSansPermissionsValidator` and consume in `rawThreadInfoValidator`.Jul 15 2024, 12:56 PM

CI issues – can you please resolve before asking for review again?

This revision now requires changes to proceed.Jul 17 2024, 12:08 PM

Actually it seems to be explained in the Test Plan:

This is just a move diff, unit tests still pass. Note: There's still a validator unit test that is expected to fail. Going to address that now that flow stuff is reolved.

Looks like it's addressed in D12758

This revision is now accepted and ready to land.Jul 17 2024, 12:10 PM

cherry-pick and land, validator test should pass now

Ran yarn eslint:all, yarn flow:all, and yarn jest:all locally and confirmed that they all passed without issue. Will wait for ESLint & Flow & Jest workflow to pass before landing.

This revision was landed with ongoing or failed builds.Jul 17 2024, 2:05 PM

Closed by commit rCOMMdc0975f965cb: [lib] Move `stripPermissionsFromMemberInfo` out of `...-types.js` file (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMdc0975f965cb: [lib] Move `stripPermissionsFromMemberInfo` out of `...-types.js` file.

Harbormaster completed remote builds in B30431: Diff 42406.Jul 17 2024, 2:24 PM