[lib] Add `flow` suppression to `deprecatedDecodeMinimallyEncodedRawThreadInfo`
AcceptedPublic
Actions

Authored by atul on Thu, Jun 27, 2:16 PM.

Details

Reviewers

Summary

Add flow suppression in deprecatedDecodeMinimallyEncodedRawThreadInfo before call to decodeMinimallyEncodedMemberInfo.

This code path will only be encountered during legacy migrations where member permissions ARE persisted so flow "issues" aren't relevant going forward because deprecatedDecodeMinimallyEncodedRawThreadInfo should never be called anywhere new.

This gets us down to 2 flow issues, both with minimallyEncodeRawThreadInfo.

Depends on D12599

Test Plan

Close reading, there are no logic changes... just flow suppressions to account for differing representation of RawThreadInfo.members

Diff Detail

Repository

rCOMM Comm

Branch

july26 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Thu, Jun 27, 2:16 PM

Herald added a subscriber: tomek. · View Herald TranscriptThu, Jun 27, 2:16 PM

atul published this revision for review.Thu, Jun 27, 2:16 PM

Harbormaster failed remote builds in B29976: Diff 41775!Thu, Jun 27, 2:28 PM

I think it's better to have type suppressions than to have to maintain the old set of types indefinitely. This makes sense to me

This revision is now accepted and ready to land.Mon, Jul 1, 1:09 PM

Revision Contents
Changeset List

Path

Size

lib/

types/

minimally-encoded-thread-permissions-types.js

3 lines

Diff 41775

View Options

lib/types/minimally-encoded-thread-permissions-types.js

[lib] Add `flow` suppression to `deprecatedDecodeMinimallyEncodedRawThreadInfo`AcceptedPublicActions