Page MenuHomePhabricator
Differential D12763

[lib] Introduce `stripMemberPermissionsFromRawThreadInfo`
ClosedPublic
Actions

Authored by atul on Jul 15 2024, 6:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 1:32 PM
Unknown Object (File)
Fri, Mar 28, 3:09 PM
Unknown Object (File)
Feb 25 2025, 5:06 AM
Unknown Object (File)
Feb 23 2025, 5:48 PM
Unknown Object (File)
Feb 21 2025, 2:23 PM
Unknown Object (File)
Feb 21 2025, 2:23 PM
Unknown Object (File)
Feb 21 2025, 2:23 PM
Unknown Object (File)
Feb 21 2025, 2:23 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMc4089cbcf0e1: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo`
Summary

This utility will be helpful in rawThreadInfoFromServerThreadInfo and client migrations.

Depends on D12758

Test Plan

Added basic unit test, will continue testing implicitly with rest of stack.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D12763_1 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jul 15 2024, 6:32 PM
Harbormaster completed remote builds in B30344: Diff 42306.Jul 15 2024, 6:52 PM
atul requested review of this revision.Jul 15 2024, 6:52 PM
atul added a child revision: D12779: [keyserver] Strip `member.permissions` for `FUTURE_CODE_VERSION` clients.Jul 16 2024, 2:45 PM
ashoat requested changes to this revision.Jul 17 2024, 12:20 PM

Love that you included tests! A bit confused about the invariant not matching the types – a couple questions inline

lib/utils/member-info-utils.js
19 ↗(On Diff #42306)

If we only expect to use this with ThinRawThreadInfo, why aren't we passing that type in here?

20 ↗(On Diff #42306)

Shouldn't we at least be able to return ThinRawThreadInfo given the invariant below?

This revision now requires changes to proceed.Jul 17 2024, 12:20 PM
atul added inline comments.Jul 17 2024, 12:32 PM
lib/utils/member-info-utils.js
19 ↗(On Diff #42306)

Sorry, the changes to stripMemberPermissionsFromRawThreadInfo types got mistakenly included in another commit. Will move back into this commit.

Will need to go through and rebase whole stack because of various ESLint issues which didn't seem to surface when I was running yarn eslint:all locally.

atul updated this revision to Diff 42414.Jul 17 2024, 2:23 PM

move changes to stripMemberPermissionsFromRawThreadInfo into this diff

Harbormaster completed remote builds in B30438: Diff 42414.Jul 17 2024, 2:50 PM
ashoat accepted this revision.Jul 18 2024, 10:14 AM
This revision is now accepted and ready to land.Jul 18 2024, 10:14 AM
atul updated this revision to Diff 42484.Jul 18 2024, 12:36 PM

cherry-pick and land

atul updated this revision to Diff 42487.Jul 18 2024, 12:40 PM

rebase

Harbormaster failed remote builds in B30482: Diff 42484!Jul 18 2024, 12:49 PM
Harbormaster completed remote builds in B30485: Diff 42487.Jul 18 2024, 1:01 PM
atul updated this revision to Diff 42498.Jul 18 2024, 2:10 PM

cherry-pick and land

This revision was landed with ongoing or failed builds.Jul 18 2024, 2:17 PM
Closed by commit rCOMMc4089cbcf0e1: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc4089cbcf0e1: [lib] Introduce `stripMemberPermissionsFromRawThreadInfo`.
Harbormaster completed remote builds in B30493: Diff 42498.Jul 18 2024, 2:26 PM

Revision Contents
Changeset List

Diff 42498

View Options

lib/utils/member-info-utils-test-data.js

Show All 18 Linesset(NATIVE_HDRS
"DraftStoreOperations.h" "DraftStoreOperations.h"
"UserStoreOperations.h" "UserStoreOperations.h"
"KeyserverStoreOperations.h" "KeyserverStoreOperations.h"
"CommunityStoreOperations.h" "CommunityStoreOperations.h"
"IntegrityStoreOperations.h" "IntegrityStoreOperations.h"
"SyncedMetadataStoreOperations.h" "SyncedMetadataStoreOperations.h"
"AuxUserStoreOperations.h" "AuxUserStoreOperations.h"
"ThreadActivityStoreOperations.h" "ThreadActivityStoreOperations.h"
"EntryStoreOperations.h"
) )
set(NATIVE_SRCS set(NATIVE_SRCS
"CommCoreModule.cpp" "CommCoreModule.cpp"
"CommUtilsModule.cpp" "CommUtilsModule.cpp"
"CommRustModule.cpp" "CommRustModule.cpp"
"CommConstants.cpp" "CommConstants.cpp"
) )
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesset(DATA_STORES_HDRS
${_data_stores_path}/ReportStore.h ${_data_stores_path}/ReportStore.h
${_data_stores_path}/UserStore.h ${_data_stores_path}/UserStore.h
${_data_stores_path}/KeyserverStore.h ${_data_stores_path}/KeyserverStore.h
${_data_stores_path}/CommunityStore.h ${_data_stores_path}/CommunityStore.h
${_data_stores_path}/IntegrityStore.h ${_data_stores_path}/IntegrityStore.h
${_data_stores_path}/SyncedMetadataStore.h ${_data_stores_path}/SyncedMetadataStore.h
${_data_stores_path}/AuxUserStore.h ${_data_stores_path}/AuxUserStore.h
${_data_stores_path}/ThreadActivityStore.h ${_data_stores_path}/ThreadActivityStore.h
${_data_stores_path}/EntryStore.h
) )
set(DATA_STORES_SRCS set(DATA_STORES_SRCS
${_data_stores_path}/DraftStore.cpp ${_data_stores_path}/DraftStore.cpp
${_data_stores_path}/ThreadStore.cpp ${_data_stores_path}/ThreadStore.cpp
${_data_stores_path}/MessageStore.cpp ${_data_stores_path}/MessageStore.cpp
${_data_stores_path}/ReportStore.cpp ${_data_stores_path}/ReportStore.cpp
${_data_stores_path}/UserStore.cpp ${_data_stores_path}/UserStore.cpp
${_data_stores_path}/KeyserverStore.cpp ${_data_stores_path}/KeyserverStore.cpp
${_data_stores_path}/CommunityStore.cpp ${_data_stores_path}/CommunityStore.cpp
${_data_stores_path}/IntegrityStore.cpp ${_data_stores_path}/IntegrityStore.cpp
${_data_stores_path}/SyncedMetadataStore.cpp ${_data_stores_path}/SyncedMetadataStore.cpp
${_data_stores_path}/AuxUserStore.cpp ${_data_stores_path}/AuxUserStore.cpp
${_data_stores_path}/ThreadActivityStore.cpp ${_data_stores_path}/ThreadActivityStore.cpp
${_data_stores_path}/EntryStore.cpp
) )
set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities) set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities)
set(BACKUP_OP_HDRS set(BACKUP_OP_HDRS
${_backup_op_path}/BackupOperationsExecutor.h ${_backup_op_path}/BackupOperationsExecutor.h
) )
set(BACKUP_OP_SRCS set(BACKUP_OP_SRCS
${_backup_op_path}/BackupOperationsExecutor.cpp ${_backup_op_path}/BackupOperationsExecutor.cpp
Show All 25 Lines
View Options

lib/utils/member-info-utils.js

Show All 18 Linesset(NATIVE_HDRS
"DraftStoreOperations.h" "DraftStoreOperations.h"
"UserStoreOperations.h" "UserStoreOperations.h"
"KeyserverStoreOperations.h" "KeyserverStoreOperations.h"
"CommunityStoreOperations.h" "CommunityStoreOperations.h"
"IntegrityStoreOperations.h" "IntegrityStoreOperations.h"
"SyncedMetadataStoreOperations.h" "SyncedMetadataStoreOperations.h"
"AuxUserStoreOperations.h" "AuxUserStoreOperations.h"
"ThreadActivityStoreOperations.h" "ThreadActivityStoreOperations.h"
"EntryStoreOperations.h"
) )
set(NATIVE_SRCS set(NATIVE_SRCS
"CommCoreModule.cpp" "CommCoreModule.cpp"
"CommUtilsModule.cpp" "CommUtilsModule.cpp"
"CommRustModule.cpp" "CommRustModule.cpp"
"CommConstants.cpp" "CommConstants.cpp"
) )
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesset(DATA_STORES_HDRS
${_data_stores_path}/ReportStore.h ${_data_stores_path}/ReportStore.h
${_data_stores_path}/UserStore.h ${_data_stores_path}/UserStore.h
${_data_stores_path}/KeyserverStore.h ${_data_stores_path}/KeyserverStore.h
${_data_stores_path}/CommunityStore.h ${_data_stores_path}/CommunityStore.h
${_data_stores_path}/IntegrityStore.h ${_data_stores_path}/IntegrityStore.h
${_data_stores_path}/SyncedMetadataStore.h ${_data_stores_path}/SyncedMetadataStore.h
${_data_stores_path}/AuxUserStore.h ${_data_stores_path}/AuxUserStore.h
${_data_stores_path}/ThreadActivityStore.h ${_data_stores_path}/ThreadActivityStore.h
${_data_stores_path}/EntryStore.h
) )
set(DATA_STORES_SRCS set(DATA_STORES_SRCS
${_data_stores_path}/DraftStore.cpp ${_data_stores_path}/DraftStore.cpp
${_data_stores_path}/ThreadStore.cpp ${_data_stores_path}/ThreadStore.cpp
${_data_stores_path}/MessageStore.cpp ${_data_stores_path}/MessageStore.cpp
${_data_stores_path}/ReportStore.cpp ${_data_stores_path}/ReportStore.cpp
${_data_stores_path}/UserStore.cpp ${_data_stores_path}/UserStore.cpp
${_data_stores_path}/KeyserverStore.cpp ${_data_stores_path}/KeyserverStore.cpp
${_data_stores_path}/CommunityStore.cpp ${_data_stores_path}/CommunityStore.cpp
${_data_stores_path}/IntegrityStore.cpp ${_data_stores_path}/IntegrityStore.cpp
${_data_stores_path}/SyncedMetadataStore.cpp ${_data_stores_path}/SyncedMetadataStore.cpp
${_data_stores_path}/AuxUserStore.cpp ${_data_stores_path}/AuxUserStore.cpp
${_data_stores_path}/ThreadActivityStore.cpp ${_data_stores_path}/ThreadActivityStore.cpp
${_data_stores_path}/EntryStore.cpp
) )
set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities) set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities)
set(BACKUP_OP_HDRS set(BACKUP_OP_HDRS
${_backup_op_path}/BackupOperationsExecutor.h ${_backup_op_path}/BackupOperationsExecutor.h
) )
set(BACKUP_OP_SRCS set(BACKUP_OP_SRCS
${_backup_op_path}/BackupOperationsExecutor.cpp ${_backup_op_path}/BackupOperationsExecutor.cpp
Show All 25 Lines
View Options

lib/utils/member-info-utils.test.js

Show All 18 Linesset(NATIVE_HDRS
"DraftStoreOperations.h" "DraftStoreOperations.h"
"UserStoreOperations.h" "UserStoreOperations.h"
"KeyserverStoreOperations.h" "KeyserverStoreOperations.h"
"CommunityStoreOperations.h" "CommunityStoreOperations.h"
"IntegrityStoreOperations.h" "IntegrityStoreOperations.h"
"SyncedMetadataStoreOperations.h" "SyncedMetadataStoreOperations.h"
"AuxUserStoreOperations.h" "AuxUserStoreOperations.h"
"ThreadActivityStoreOperations.h" "ThreadActivityStoreOperations.h"
"EntryStoreOperations.h"
) )
set(NATIVE_SRCS set(NATIVE_SRCS
"CommCoreModule.cpp" "CommCoreModule.cpp"
"CommUtilsModule.cpp" "CommUtilsModule.cpp"
"CommRustModule.cpp" "CommRustModule.cpp"
"CommConstants.cpp" "CommConstants.cpp"
) )
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesset(DATA_STORES_HDRS
${_data_stores_path}/ReportStore.h ${_data_stores_path}/ReportStore.h
${_data_stores_path}/UserStore.h ${_data_stores_path}/UserStore.h
${_data_stores_path}/KeyserverStore.h ${_data_stores_path}/KeyserverStore.h
${_data_stores_path}/CommunityStore.h ${_data_stores_path}/CommunityStore.h
${_data_stores_path}/IntegrityStore.h ${_data_stores_path}/IntegrityStore.h
${_data_stores_path}/SyncedMetadataStore.h ${_data_stores_path}/SyncedMetadataStore.h
${_data_stores_path}/AuxUserStore.h ${_data_stores_path}/AuxUserStore.h
${_data_stores_path}/ThreadActivityStore.h ${_data_stores_path}/ThreadActivityStore.h
${_data_stores_path}/EntryStore.h
) )
set(DATA_STORES_SRCS set(DATA_STORES_SRCS
${_data_stores_path}/DraftStore.cpp ${_data_stores_path}/DraftStore.cpp
${_data_stores_path}/ThreadStore.cpp ${_data_stores_path}/ThreadStore.cpp
${_data_stores_path}/MessageStore.cpp ${_data_stores_path}/MessageStore.cpp
${_data_stores_path}/ReportStore.cpp ${_data_stores_path}/ReportStore.cpp
${_data_stores_path}/UserStore.cpp ${_data_stores_path}/UserStore.cpp
${_data_stores_path}/KeyserverStore.cpp ${_data_stores_path}/KeyserverStore.cpp
${_data_stores_path}/CommunityStore.cpp ${_data_stores_path}/CommunityStore.cpp
${_data_stores_path}/IntegrityStore.cpp ${_data_stores_path}/IntegrityStore.cpp
${_data_stores_path}/SyncedMetadataStore.cpp ${_data_stores_path}/SyncedMetadataStore.cpp
${_data_stores_path}/AuxUserStore.cpp ${_data_stores_path}/AuxUserStore.cpp
${_data_stores_path}/ThreadActivityStore.cpp ${_data_stores_path}/ThreadActivityStore.cpp
${_data_stores_path}/EntryStore.cpp
) )
set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities) set(_backup_op_path ./PersistentStorageUtilities/BackupOperationsUtilities)
set(BACKUP_OP_HDRS set(BACKUP_OP_HDRS
${_backup_op_path}/BackupOperationsExecutor.h ${_backup_op_path}/BackupOperationsExecutor.h
) )
set(BACKUP_OP_SRCS set(BACKUP_OP_SRCS
${_backup_op_path}/BackupOperationsExecutor.cpp ${_backup_op_path}/BackupOperationsExecutor.cpp
Show All 25 Lines