[lib] Narrow `canToggleMessagePin` and `useCanToggleMessagePin` types
ClosedPublic
Actions

Authored by atul on Apr 26 2024, 12:58 PM.

Details

Reviewers

ashoat
ginsu
tomek
varun

Commits

rCOMM2d4677a72526: [lib] Narrow `canToggleMessagePin` and `useCanToggleMessagePin` types

Summary

To make it clear which should be used in which scenario (RawThreadInfo vs ThreadInfo).

Depends on D11820

Test Plan

flow + close reading

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 26 2024, 12:58 PM

Harbormaster completed remote builds in B28545: Diff 39601.Apr 26 2024, 1:36 PM

atul requested review of this revision.Apr 26 2024, 1:36 PM

ashoat accepted this revision.Apr 27 2024, 6:47 PM

This revision is now accepted and ready to land.Apr 27 2024, 6:47 PM

land

This revision was landed with ongoing or failed builds.May 3 2024, 1:01 PM

Closed by commit rCOMM2d4677a72526: [lib] Narrow `canToggleMessagePin` and `useCanToggleMessagePin` types (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM2d4677a72526: [lib] Narrow `canToggleMessagePin` and `useCanToggleMessagePin` types.

Harbormaster completed remote builds in B28645: Diff 39764.May 3 2024, 1:07 PM

Revision Contents
Changeset List

Path

Size

lib/

utils/

message-pinning-utils.js

6 lines

Diff 39768

View Options

lib/utils/message-pinning-utils.js

	// @flow			// @flow

	import t from 'tcomb';			import t from 'tcomb';

	import type { UpdateSpec } from './update-spec.js';			import type { UpdateSpec } from './update-spec.js';
	import type { RawThreadInfos } from '../../types/thread-types.js';			import type { MixedRawThreadInfos } from '../../types/thread-types.js';
	import { updateTypes } from '../../types/update-types-enum.js';			import { updateTypes } from '../../types/update-types-enum.js';
	import type {			import type {
	ThreadDeletionRawUpdateInfo,			ThreadDeletionRawUpdateInfo,
	ThreadDeletionUpdateData,			ThreadDeletionUpdateData,
	ThreadDeletionUpdateInfo,			ThreadDeletionUpdateInfo,
	} from '../../types/update-types.js';			} from '../../types/update-types.js';
	import { tID, tNumber, tShape } from '../../utils/validation-utils.js';			import { tID, tNumber, tShape } from '../../utils/validation-utils.js';

	export const deleteThreadSpec: UpdateSpec<			export const deleteThreadSpec: UpdateSpec<
	ThreadDeletionUpdateInfo,			ThreadDeletionUpdateInfo,
	ThreadDeletionRawUpdateInfo,			ThreadDeletionRawUpdateInfo,
	ThreadDeletionUpdateData,			ThreadDeletionUpdateData,
	> = Object.freeze({			> = Object.freeze({
	generateOpsForThreadUpdates(			generateOpsForThreadUpdates(
	storeThreadInfos: RawThreadInfos,			storeThreadInfos: MixedRawThreadInfos,
	update: ThreadDeletionUpdateInfo,			update: ThreadDeletionUpdateInfo,
	) {			) {
	if (storeThreadInfos[update.threadID]) {			if (storeThreadInfos[update.threadID]) {
	return [			return [
	{			{
	type: 'remove',			type: 'remove',
	payload: {			payload: {
	ids: [update.threadID],			ids: [update.threadID],
	▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines

[lib] Narrow `canToggleMessagePin` and `useCanToggleMessagePin` typesClosedPublicActions