Page MenuHomePhabricator

[lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`
ClosedPublic

Authored by atul on Apr 26 2024, 12:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 10, 1:24 PM
Unknown Object (File)
Mon, Mar 31, 4:27 PM
Unknown Object (File)
Mon, Mar 31, 2:27 PM
Unknown Object (File)
Mon, Mar 31, 5:25 AM
Unknown Object (File)
Mon, Mar 31, 3:41 AM
Unknown Object (File)
Sun, Mar 30, 10:05 AM
Unknown Object (File)
Sun, Mar 23, 2:53 PM
Unknown Object (File)
Mar 5 2025, 3:58 PM
Subscribers
None

Details

Summary

Similar to D11791, but for useCanEditMessage.


Depends on D11792

Test Plan

flow + close reading

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.Apr 26 2024, 1:07 PM
ashoat added inline comments.
lib/shared/edit-messages-utils.js
61 ↗(On Diff #39595)

I think we should do this this instead

73–77 ↗(On Diff #39595)

And then this

This revision is now accepted and ready to land.Apr 27 2024, 6:41 PM
This revision was landed with ongoing or failed builds.May 2 2024, 9:59 AM
This revision was automatically updated to reflect the committed changes.