Page MenuHomePhabricator
Differential D11816

[lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`
ClosedPublic
Actions

Authored by atul on Fri, Apr 26, 12:49 PM.
Tags
None
Referenced Files
F1791061: D11816.diff
Sun, May 19, 9:59 AM
Unknown Object (File)
Wed, May 15, 10:39 AM
Unknown Object (File)
Wed, May 15, 12:49 AM
Unknown Object (File)
Wed, May 15, 12:49 AM
Unknown Object (File)
Wed, May 15, 12:49 AM
Unknown Object (File)
Mon, May 13, 11:47 AM
Unknown Object (File)
Mon, May 13, 11:18 AM
Unknown Object (File)
Mon, May 13, 2:46 AM
View All 15 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
varun
Commits
rCOMMbf7178f18877: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in…
Summary

Similar to D11791, but for useCanEditMessage.

Depends on D11792

Test Plan

flow + close reading

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D11816 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Fri, Apr 26, 12:49 PM
atul added a child revision: D11817: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateSidebarFromMessage`.
Harbormaster completed remote builds in B28539: Diff 39595.Fri, Apr 26, 1:07 PM
atul requested review of this revision.Fri, Apr 26, 1:07 PM
ashoat accepted this revision.Sat, Apr 27, 6:41 PM
ashoat added inline comments.
lib/shared/edit-messages-utils.js
61 ↗(On Diff #39595)

I think we should do this this instead

73–77 ↗(On Diff #39595)

And then this

This revision is now accepted and ready to land.Sat, Apr 27, 6:41 PM
atul updated this revision to Diff 39749.Thu, May 2, 9:47 AM

address feedback

Harbormaster failed remote builds in B28633: Diff 39749!Thu, May 2, 9:58 AM
This revision was landed with ongoing or failed builds.Thu, May 2, 9:59 AM
Closed by commit rCOMMbf7178f18877: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMbf7178f18877: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in….

Revision Contents
Changeset List

PathSize
lib/
shared/
18 lines

Diff 39749

View Options

lib/shared/edit-messages-utils.js

Loading...