Page MenuHomePhabricator
Differential D11751

[web] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsMenu`
ClosedPublic
Actions

Authored by atul on Apr 23 2024, 1:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 8, 5:42 AM
Unknown Object (File)
Sat, Mar 8, 5:42 AM
Unknown Object (File)
Sat, Mar 8, 5:42 AM
Unknown Object (File)
Sat, Mar 8, 5:42 AM
Unknown Object (File)
Sat, Mar 8, 5:42 AM
Unknown Object (File)
Feb 11 2025, 3:24 PM
Unknown Object (File)
Jan 23 2025, 10:53 AM
Unknown Object (File)
Jan 19 2025, 10:16 AM
View All 68 Files
Subscribers
ashoat

Details

Reviewers
varun
ginsu
tomek
will
Commits
rCOMM26e18f854825: [web] Replace `threadHasPermission` with `useThreadHasPermission` in…
Summary

Similar to D11750, but for CommunityActionsMenu

Depends on D11750

Test Plan

flow + close reading.

Will test generally at end to make sure things work as expected. Don't think it's practical to manually test each of these trivial changes.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
web/
components/
6 lines

Diff 39471

View Options

web/components/community-actions-menu.react.js

Show First 20 Lines • Show All 149 Lines • ▼ Show 20 Lines +uploadMultimedia: (
extras: MultimediaUploadExtras, extras: MultimediaUploadExtras,
callbacks: MultimediaUploadCallbacks, callbacks: MultimediaUploadCallbacks,
) => Promise<UploadMultimediaResult>, ) => Promise<UploadMultimediaResult>,
+blobServiceUpload: BlobServiceUploadAction, +blobServiceUpload: BlobServiceUploadAction,
+sendMultimediaMessage: ( +sendMultimediaMessage: (
input: SendMultimediaMessageInput, input: SendMultimediaMessageInput,
) => Promise<SendMessageResult>, ) => Promise<SendMessageResult>,
+sendTextMessage: (input: SendTextMessageInput) => Promise<SendMessageResult>, +sendTextMessage: (input: SendTextMessageInput) => Promise<SendMessageResult>,
+newThread: (request: ClientNewThreadRequest) => Promise<NewThreadResult>, +newThinThread: (request: ClientNewThreadRequest) => Promise<NewThreadResult>,
+textMessageCreationSideEffectsFunc: CreationSideEffectsFunc<RawTextMessageInfo>, +textMessageCreationSideEffectsFunc: CreationSideEffectsFunc<RawTextMessageInfo>,
}; };
type State = { type State = {
+pendingUploads: PendingMultimediaUploads, +pendingUploads: PendingMultimediaUploads,
}; };
class InputStateContainer extends React.PureComponent<Props, State> { class InputStateContainer extends React.PureComponent<Props, State> {
state: State = { state: State = {
▲ Show 20 Lines • Show All 380 Lines • ▼ Show 20 Lines if (!threadIsPending(threadInfo.id)) {
return Promise.resolve(threadInfo.id); return Promise.resolve(threadInfo.id);
} }
let threadCreationPromise = this.pendingThreadCreations.get(threadInfo.id); let threadCreationPromise = this.pendingThreadCreations.get(threadInfo.id);
if (!threadCreationPromise) { if (!threadCreationPromise) {
const calendarQuery = this.props.calendarQuery(); const calendarQuery = this.props.calendarQuery();
threadCreationPromise = createRealThreadFromPendingThread({ threadCreationPromise = createRealThreadFromPendingThread({
threadInfo, threadInfo,
dispatchActionPromise: this.props.dispatchActionPromise, dispatchActionPromise: this.props.dispatchActionPromise,
createNewThread: this.props.newThread, createNewThinThread: this.props.newThinThread,
sourceMessageID: threadInfo.sourceMessageID, sourceMessageID: threadInfo.sourceMessageID,
viewerID: this.props.viewerID, viewerID: this.props.viewerID,
calendarQuery, calendarQuery,
}); });
this.pendingThreadCreations.set(threadInfo.id, threadCreationPromise); this.pendingThreadCreations.set(threadInfo.id, threadCreationPromise);
} }
return threadCreationPromise; return threadCreationPromise;
} }
▲ Show 20 Lines • Show All 1,165 Lines • ▼ Show 20 Lines const ongoingMessageCreation = useSelector(
) === 'loading', ) === 'loading',
); );
const hasWiFi = useSelector(state => state.connectivity.hasWiFi); const hasWiFi = useSelector(state => state.connectivity.hasWiFi);
const calendarQuery = useCalendarQuery(); const calendarQuery = useCalendarQuery();
const callUploadMultimedia = useLegacyAshoatKeyserverCall(uploadMultimedia); const callUploadMultimedia = useLegacyAshoatKeyserverCall(uploadMultimedia);
const callBlobServiceUpload = useBlobServiceUpload(); const callBlobServiceUpload = useBlobServiceUpload();
const callSendMultimediaMessage = useSendMultimediaMessage(); const callSendMultimediaMessage = useSendMultimediaMessage();
const callSendTextMessage = useSendTextMessage(); const callSendTextMessage = useSendTextMessage();
const callNewThread = useNewThread(); const callNewThinThread = useNewThread();
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const dispatch = useDispatch(); const dispatch = useDispatch();
const mediaReportsEnabled = useIsReportEnabled('mediaReports'); const mediaReportsEnabled = useIsReportEnabled('mediaReports');
const staffCanSee = useStaffCanSee(); const staffCanSee = useStaffCanSee();
const textMessageCreationSideEffectsFunc = const textMessageCreationSideEffectsFunc =
useMessageCreationSideEffectsFunc<RawTextMessageInfo>(messageTypes.TEXT); useMessageCreationSideEffectsFunc<RawTextMessageInfo>(messageTypes.TEXT);
return ( return (
<InputStateContainer <InputStateContainer
{...props} {...props}
viewerID={viewerID} viewerID={viewerID}
messageStoreMessages={messageStoreMessages} messageStoreMessages={messageStoreMessages}
ongoingMessageCreation={ongoingMessageCreation} ongoingMessageCreation={ongoingMessageCreation}
hasWiFi={hasWiFi} hasWiFi={hasWiFi}
mediaReportsEnabled={mediaReportsEnabled} mediaReportsEnabled={mediaReportsEnabled}
calendarQuery={calendarQuery} calendarQuery={calendarQuery}
uploadMultimedia={callUploadMultimedia} uploadMultimedia={callUploadMultimedia}
blobServiceUpload={callBlobServiceUpload} blobServiceUpload={callBlobServiceUpload}
sendMultimediaMessage={callSendMultimediaMessage} sendMultimediaMessage={callSendMultimediaMessage}
sendTextMessage={callSendTextMessage} sendTextMessage={callSendTextMessage}
newThread={callNewThread} newThinThread={callNewThinThread}
dispatchActionPromise={dispatchActionPromise} dispatchActionPromise={dispatchActionPromise}
dispatch={dispatch} dispatch={dispatch}
staffCanSee={staffCanSee} staffCanSee={staffCanSee}
textMessageCreationSideEffectsFunc={textMessageCreationSideEffectsFunc} textMessageCreationSideEffectsFunc={textMessageCreationSideEffectsFunc}
/> />
); );
}); });
export default ConnectedInputStateContainer; export default ConnectedInputStateContainer;