[lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`
ClosedPublic
Actions

Authored by atul on Apr 26 2024, 7:49 PM.

Details

Reviewers

ashoat
ginsu
tomek
varun

Commits

rCOMMbf7178f18877: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in…

Summary

Similar to D11791, but for useCanEditMessage.

Depends on D11792

Test Plan

flow + close reading

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 26 2024, 7:49 PM

atul added a child revision: D11817: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanCreateSidebarFromMessage`.

Harbormaster completed remote builds in B28539: Diff 39595.Apr 26 2024, 8:07 PM

atul requested review of this revision.Apr 26 2024, 8:07 PM

ashoat accepted this revision.Apr 28 2024, 1:41 AM

ashoat added inline comments.

lib/shared/edit-messages-utils.js
61 ↗	(On Diff #39595)	I think we should do this this instead
73–77 ↗	(On Diff #39595)	And then this

This revision is now accepted and ready to land.Apr 28 2024, 1:41 AM

address feedback

Harbormaster failed remote builds in B28633: Diff 39749!May 2 2024, 4:58 PM

This revision was landed with ongoing or failed builds.May 2 2024, 4:59 PM

Closed by commit rCOMMbf7178f18877: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in…. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMbf7178f18877: [lib] Replace `threadHasPermission` with `useThreadHasPermission` in….

Revision Contents
Changeset List

Path

Size

lib/

shared/

edit-messages-utils.js

18 lines

Diff 39750

View Options

lib/shared/edit-messages-utils.js

[lib] Replace `threadHasPermission` with `useThreadHasPermission` in `useCanEditMessage`ClosedPublicActions