Page MenuHomePhabricator
Differential D11807

[native] Fix pending state in ExistingEthereumAccount for identity auth
ClosedPublic
Actions

Authored by ashoat on Fri, Apr 26, 11:30 AM.
Tags
None
Referenced Files
F1710218: D11807.id.diff
Mon, May 6, 2:08 PM
Unknown Object (File)
Thu, May 2, 6:19 PM
Unknown Object (File)
Thu, May 2, 2:08 PM
Unknown Object (File)
Wed, May 1, 9:26 AM
Unknown Object (File)
Tue, Apr 30, 10:41 AM
Subscribers
tomek

Details

Reviewers
inka
Commits
rCOMM0fdc58b6d2ec: [native] Fix pending state in ExistingEthereumAccount for identity auth
Summary

Noticed while working on the stack ending in D11806 that the pending state here is only handled for the legacy auth.

Changed it here and did some corresponding reworking of the logic.

Depends on D11806

Test Plan

Careful reading of the code

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Fri, Apr 26, 11:30 AM
Herald added a subscriber: tomek. · View Herald TranscriptFri, Apr 26, 11:30 AM
ashoat removed a parent revision: D11806: [lib][native][web] Rename LogInExtraInfo to LegacyLogInExtraInfo.Fri, Apr 26, 11:32 AM
Harbormaster completed remote builds in B28525: Diff 39570.Fri, Apr 26, 11:57 AM
ashoat requested review of this revision.Fri, Apr 26, 11:57 AM
inka accepted this revision.Tue, Apr 30, 8:51 AM
inka added inline comments.
native/account/registration/existing-ethereum-account.react.js
39–41 ↗(On Diff #39570)

The RegistrationButton button is disabled when variant === 'disabled' || variant === 'loading', so this is not needed, but I suppose it's safer

This revision is now accepted and ready to land.Tue, Apr 30, 8:51 AM
Closed by commit rCOMM0fdc58b6d2ec: [native] Fix pending state in ExistingEthereumAccount for identity auth (authored by ashoat). · Explain WhyTue, Apr 30, 9:34 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM0fdc58b6d2ec: [native] Fix pending state in ExistingEthereumAccount for identity auth.

Revision Contents
Changeset List

PathSize
native/
account/
registration/
69 lines

Diff 39706

View Options

native/account/registration/existing-ethereum-account.react.js

Loading...