Paths

Table of Contentst

Differential D11804

[lib] Fix payload of KEYSERVER_AUTH_STARTED action
ClosedPublic
Actions

Authored by ashoat on Fri, Apr 26, 11:26 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 4, 12:30 PM

	Unknown Object (File)
	Thu, May 2, 7:16 PM

	Unknown Object (File)
	Wed, May 1, 10:52 PM

	Unknown Object (File)
	Tue, Apr 30, 12:43 PM

Subscribers

Details

Reviewers

Commits

rCOMMdc9e572a5222: [lib] Fix payload of KEYSERVER_AUTH_STARTED action

Summary

This payload is mistyped. In useRawKeyserverAuth (the only place where it is dispatched), we do not include a payload for this action. Additionally, this action is never reduced in any reducers, so this change should be safe.

Depends on D11803

Test Plan

Searched the codebase for places where this action is dispatched and confirmed there is no payload
Searched the codebase for places where this action is reduced and confirmed there are none

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Fri, Apr 26, 11:26 AM

Herald added a subscriber: tomek. · View Herald TranscriptFri, Apr 26, 11:26 AM

ashoat added a child revision: D11805: [lib][native][web] Rename some legacy login types.Fri, Apr 26, 11:27 AM

Harbormaster completed remote builds in B28522: Diff 39567.Fri, Apr 26, 11:43 AM

ashoat requested review of this revision.Fri, Apr 26, 11:43 AM

inka accepted this revision.Tue, Apr 30, 8:35 AM

This revision is now accepted and ready to land.Tue, Apr 30, 8:35 AM

Closed by commit rCOMMdc9e572a5222: [lib] Fix payload of KEYSERVER_AUTH_STARTED action (authored by ashoat). · Explain WhyTue, Apr 30, 9:34 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMdc9e572a5222: [lib] Fix payload of KEYSERVER_AUTH_STARTED action.

Revision Contents
Changeset List

Path

Size

lib/

types/

2 lines

Diff 39702

lib/types/redux-types.js

Loading...