Page MenuHomePhabricator
Differential D11760

[web] Fix missing relationship buttons
ClosedPublic
Actions

Authored by inka on Wed, Apr 24, 7:32 AM.
Tags
None
Referenced Files
F1695670: D11760.id39440.diff
Fri, May 3, 8:30 AM
Unknown Object (File)
Thu, May 2, 8:19 PM
Unknown Object (File)
Wed, May 1, 4:01 PM
Unknown Object (File)
Tue, Apr 30, 2:09 PM
Unknown Object (File)
Mon, Apr 29, 2:10 PM
Unknown Object (File)
Mon, Apr 29, 1:00 PM
Unknown Object (File)
Mon, Apr 29, 11:32 AM
Unknown Object (File)
Sun, Apr 28, 9:02 AM
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMMfa2cd2e93e24: [web] Fix missing relationship buttons
Summary

issue: ENG-7486
We might not have user infos in our UserStore, if we don't have any relationship with them. But we can extract them from the pending thread infos. useRelationshipPrompt takes pendingPersonalThreadUserInfo as an argument, and uses it if the user infos are indeed not present in the store.

Test Plan

Tested that the relationship buttons are present and work correctly

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Wed, Apr 24, 7:32 AM
Herald added a subscriber: ashoat. · View Herald TranscriptWed, Apr 24, 7:32 AM
Harbormaster completed remote builds in B28433: Diff 39440.Wed, Apr 24, 7:51 AM
inka requested review of this revision.Wed, Apr 24, 7:51 AM
ashoat added inline comments.Wed, Apr 24, 6:32 PM
web/chat/chat-message-list.react.js
322–325 ↗(On Diff #39440)

Is there a risk in an index out-of-bounds error here?

inka updated this revision to Diff 39485.Thu, Apr 25, 5:52 AM

Make the code safer

Harbormaster completed remote builds in B28465: Diff 39485.Thu, Apr 25, 6:09 AM
tomek accepted this revision.Thu, Apr 25, 7:17 AM

Is native also affected by this bug?

This revision is now accepted and ready to land.Thu, Apr 25, 7:17 AM
inka added a comment.Thu, Apr 25, 8:28 AM
In D11760#337835, @tomek wrote:

Is native also affected by this bug?

No, native handles this differently

Closed by commit rCOMMfa2cd2e93e24: [web] Fix missing relationship buttons (authored by inka). · Explain WhyThu, Apr 25, 8:46 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMfa2cd2e93e24: [web] Fix missing relationship buttons.

Revision Contents
Changeset List

PathSize
web/
chat/
30 lines
relationship-prompt/
13 lines

Diff 39495

View Options

web/chat/chat-message-list.react.js

Loading...
View Options

web/chat/relationship-prompt/relationship-prompt.js

Loading...