Page MenuHomePhabricator

Add missing privacy API declarations and upgrade MMKV
ClosedPublic

Authored by marcin on Thu, Apr 25, 4:07 AM.
Tags
None
Referenced Files
F1699820: D11779.diff
Sat, May 4, 10:14 AM
Unknown Object (File)
Thu, May 2, 8:30 AM
Unknown Object (File)
Wed, May 1, 9:02 PM
Unknown Object (File)
Wed, May 1, 5:52 PM
Unknown Object (File)
Wed, May 1, 12:07 PM
Unknown Object (File)
Wed, May 1, 11:14 AM
Unknown Object (File)
Mon, Apr 29, 12:14 AM
Subscribers
None

Details

Summary

This differential addresses the Linear issue: https://linear.app/comm/issue/ENG-7278/add-new-api-declarations-to-ios-privacy-manifest. It is done by:

  1. Creating privacy manfiest file that lists privacy API's that our libraries use and privides reasons for each API. Reasons are taken from libraries repositories.
  2. Upgrades MMKV. MMKV was also using privacy API and since version 1.3.5 those usages are removed so that MMKV doesn't contribute to the issue.
Test Plan
  1. Build both Android and iOS app and ensure that notifs work.
  2. Build both Android and iOS app without this diff and then re-build after applying this diff. Ensure that notifs work.

Steps above test that MMKV upgrade doesn't break notifs. Correctness of privacy manifest will be tested by making a release and ensuring that we don't receive message from Apple about missing privacy declarations.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable