Page MenuHomePhabricator
Differential D11811

[web][native] mark keys as published before uploading to identity service
Changes PlannedPublic
Actions

Authored by varun on Fri, Apr 26, 12:11 PM.
Tags
None
Referenced Files
F1712856: D11811.id39589.diff
Tue, May 7, 4:59 AM
F1710590: D11811.id.diff
Mon, May 6, 3:53 PM
Unknown Object (File)
Thu, May 2, 3:37 PM
Unknown Object (File)
Thu, May 2, 1:59 AM
Unknown Object (File)
Tue, Apr 30, 12:12 PM
Subscribers
ashoat
tomek

Details

Reviewers
marcin
kamil
ashoat
Summary

On web and native, we should make sure we mark prekeys/otks as published right before uploading them to the identity service to prevent a scenario where identity is vending keys that haven't been published by the client

Depends on D11810

Test Plan

will attach gist shortly

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Fri, Apr 26, 12:11 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFri, Apr 26, 12:11 PM
Harbormaster completed remote builds in B28534: Diff 39589.Fri, Apr 26, 12:40 PM
varun requested review of this revision.Fri, Apr 26, 12:40 PM
varun planned changes to this revision.Fri, Apr 26, 1:33 PM
ashoat requested changes to this revision.Sat, Apr 27, 6:08 PM

Worth reading my comment in the preceding diff before proceeding here. It looks like this diff only moves around calls to mark prekeys as published, which I think should actually stay where they are (after publishing to identity). Might be best to abandon this diff, but let me know if I'm missing something

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
70 lines
web/
shared-worker/
worker/
5 lines

Diff 39589

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

web/shared-worker/worker/worker-crypto.js

Loading...