Page MenuHomePhabricator
Differential D12689

[terraform] create comm database on aws rds startup
ClosedPublic
Actions

Authored by will on Mon, Jul 8, 5:37 AM.
Tags
None
Referenced Files
F2368697: D12689.id42391.diff
Wed, Jul 31, 12:07 PM
F2368681: D12689.id42442.diff
Wed, Jul 31, 11:47 AM
Unknown Object (File)
Wed, Jul 31, 2:26 AM
Unknown Object (File)
Sat, Jul 27, 4:04 PM
Unknown Object (File)
Sat, Jul 27, 8:28 AM
Unknown Object (File)
Sat, Jul 27, 8:28 AM
Unknown Object (File)
Sat, Jul 27, 8:28 AM
Unknown Object (File)
Fri, Jul 26, 4:50 PM
View All 36 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
varun
Commits
rCOMMcda5310213fd: [terraform] create comm database on aws rds startup
Summary

Our scripts take care of creating the comm database. However, AWS RDS initializes empty, causing
ecs tasks running the keyserver image to fail. This uses a null_resource to setup the comm database before launching keyserver nodes

Depends on D12688

Test Plan

On terraform apply, I no longer need to mysql remotely into aws rds to create the comm database. The comm database is first created and then the ecs tasks are launched

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Mon, Jul 8, 5:37 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Jul 8, 5:37 AM
will edited the summary of this revision. (Show Details)Mon, Jul 8, 5:38 AM
will added a parent revision: D12688: [terraform] make aws rds instance class configurable for self-hosting.
will added a child revision: D12690: [terraform] restrict redis access to ecs keyserver service only.
Harbormaster returned this revision to the author for changes because remote builds failed.Mon, Jul 8, 6:04 AM
Harbormaster failed remote builds in B30193: Diff 42105!
will updated this revision to Diff 42143.Tue, Jul 9, 6:40 AM

rebase

Harbormaster completed remote builds in B30222: Diff 42143.Tue, Jul 9, 6:56 AM
will requested review of this revision.Tue, Jul 9, 6:56 AM
will updated this revision to Diff 42213.Wed, Jul 10, 2:25 PM

run this command every time

Harbormaster completed remote builds in B30272: Diff 42213.Wed, Jul 10, 2:42 PM
varun accepted this revision.Wed, Jul 10, 11:58 PM
varun added inline comments.
services/terraform/self-host/aws_db.tf
104 ↗(On Diff #42213)

what does this line do?

This revision is now accepted and ready to land.Wed, Jul 10, 11:58 PM
varun added a comment.Wed, Jul 10, 11:58 PM

this solution is pretty neat

will added inline comments.Thu, Jul 11, 8:32 AM
services/terraform/self-host/aws_db.tf
104 ↗(On Diff #42213)

So this ensures that the command is constantly run on every terraform apply as the changing timestamp always triggers the null resource.

This might be overkill, but the case I'm accounting for is if AWS RDS needs to be relaunched or the database was dropped (which I had to do for testing) and the null_resource isn't destroyed with it.

I think it's safe to put in for now, and maybe we can rethink how useful it is later

will updated this revision to Diff 42391.Wed, Jul 17, 9:00 AM

remove timestamp trigger, running only on first rds creation

will added inline comments.Wed, Jul 17, 9:02 AM
services/terraform/self-host/aws_db.tf
104 ↗(On Diff #42213)

Ended up removing this. When one need to switch ip addresses, this prevents you from running terraform apply

Harbormaster completed remote builds in B30419: Diff 42391.Wed, Jul 17, 9:33 AM
Closed by commit rCOMMcda5310213fd: [terraform] create comm database on aws rds startup (authored by will). · Explain WhyWed, Jul 17, 7:01 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMcda5310213fd: [terraform] create comm database on aws rds startup.

Revision Contents
Changeset List

PathSize
services/
terraform/
self-host/
14 lines
2 lines

Diff 42442

View Options

services/terraform/self-host/aws_db.tf

Loading...
View Options

services/terraform/self-host/keyserver_primary.tf

Loading...