Drafting this for some initial feedback. This sets up ecs cluster with primary keyserver task def
Depends on D12529
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- keyserver_to_aws
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/terraform/self-host/aws_ecs.tf | ||
|---|---|---|
| 10–12 | Is service connect needed in self-host? Are nodes going to talk to each other? | |
| services/terraform/self-host/aws_iam.tf | ||
| 48–58 | I'd use jsonencode() - see examples in aws_iam.tf e.g. for resource "aws_iam_role" "ecs_task_execution". Just see you used it right below | |
| services/terraform/self-host/keyserver_primary.tf | ||
| 3 | You're going to change this later to comm repo? | |
| 70–76 | can we use jsonencode()? | |
| services/terraform/self-host/aws_ecs.tf | ||
|---|---|---|
| 10–12 | That's a good question. I don't think so. I'll remove for now and add back in a separate diff if it comes up | |
| services/terraform/self-host/keyserver_primary.tf | ||
| 3 | Yep! Before landing the stack, I'll test and push the primary and secondary images on the commapp repo | |