Details

Reviewers

bartek
varun
ashoat

Commits

rCOMMa413bd61cbd9: [terraform] Replace all config options with terraform variables and remove sops

Summary

Bartek pointed out that SOPS was overkill for self-hosting. Additionally, several configuration options required the user to make terraform changes.

In this diff, I introduce the usage of terraform variables to

configure mariadb username/password that was previously configured through sops
configure the aws region, subnets, and user ip

Depends on D12323

Test Plan

terraform apply and successfully connected mysql client to rds endpoint

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Jun 5 2024, 5:06 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 5 2024, 5:06 PM

will retitled this revision from [terraform] Replace all config options with .tfvars and remove sops to [terraform] Replace all config options with terraform variables and remove sops.Jun 5 2024, 5:07 PM

will added inline comments.

services/terraform/self-host/aws_vpc.tf
9 ↗	(On Diff #41000)	Changed to numbers to avoid possible confusion with the letters used by availability zones

Harbormaster completed remote builds in B29465: Diff 41000.Jun 5 2024, 5:23 PM

will requested review of this revision.Jun 5 2024, 5:23 PM

Was thinking similar to the dev folder, we can create a simple run.sh script with:

terraform init

terraform apply -var-file="secrets.tfvars"

will added inline comments.Jun 5 2024, 5:52 PM

services/terraform/self-host/aws_vpc.tf
33 ↗	(On Diff #41000)	`32` as the mask means the block resolves to a single exact ip address

will added a reviewer: ashoat.Jun 5 2024, 5:52 PM

Two comments here:

When using one of "default" filenames (I recall terraform.tfvars), you don't have to use the -var-file="secrets.tfvars" arg
It's a good practice to commit terraform.tfvars.example (while gitignoring actual terraform.tfvars) with example variables (usually required ones, that don't have defaults in variables.tf). This file can be copied and renamed by individual users.

What do you think?

I like @bartek's suggestions. I'm probably a bad reviewer for Terraform stuff since I'm not familiar

In D12324#350437, @bartek wrote:

Two comments here:

When using one of "default" filenames (I recall terraform.tfvars), you don't have to use the -var-file="secrets.tfvars" arg

It's a good practice to commit terraform.tfvars.example (while gitignoring actual terraform.tfvars) with example variables (usually required ones, that don't have defaults in variables.tf). This file can be copied and renamed by individual users.

What do you think?