Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Yesterday

varun closed D11756: [identity] delete all data for user from otks table on account deletion.
Wed, Apr 24, 6:52 AM
varun committed rCOMMf04aa1f8195f: [identity] delete all data for user from otks table on account deletion (authored by varun).
[identity] delete all data for user from otks table on account deletion
Wed, Apr 24, 6:52 AM
varun closed D11755: [identity] delete otk data on logout.
Wed, Apr 24, 6:52 AM
varun committed rCOMMbac2d9c740ca: [identity] delete otk data on logout (authored by varun).
[identity] delete otk data on logout
Wed, Apr 24, 6:52 AM

Tue, Apr 23

varun requested review of D11756: [identity] delete all data for user from otks table on account deletion.
Tue, Apr 23, 8:54 PM
varun requested review of D11755: [identity] delete otk data on logout.
Tue, Apr 23, 8:53 PM
varun accepted D11687: [identity] Allow UpdateDeviceList RPC to remove devices.
Tue, Apr 23, 5:49 PM

Mon, Apr 22

varun accepted D11686: [identity] Extract device list verification to separate func.
Mon, Apr 22, 2:41 PM
varun accepted D11685: [identity] Add device list timestamp verification.
Mon, Apr 22, 2:35 PM
varun accepted D11710: [terraform] Update staging identity.
Mon, Apr 22, 5:23 AM
varun accepted D11709: [identity] Temporarily revert wallet user check.
Mon, Apr 22, 5:22 AM

Fri, Apr 19

varun closed D11706: [terraform] revert identity image.
Fri, Apr 19, 2:09 PM
varun committed rCOMMc98092642f83: [terraform] revert identity image (authored by varun).
[terraform] revert identity image
Fri, Apr 19, 2:09 PM
varun closed D11704: bump identity version and introduce script for identity releases.
Fri, Apr 19, 2:09 PM
varun committed rCOMM8d3335ab7c24: bump identity version and introduce script for identity releases (authored by varun).
bump identity version and introduce script for identity releases
Fri, Apr 19, 2:09 PM
varun published D11706: [terraform] revert identity image for review.
Fri, Apr 19, 1:13 PM
varun requested review of D11705: [web] log out if CSAT is missing.
Fri, Apr 19, 1:09 PM
varun requested review of D11704: bump identity version and introduce script for identity releases.
Fri, Apr 19, 12:22 PM
varun closed D11590: add deletePasswordUser to IdentityServiceClient.
Fri, Apr 19, 8:43 AM
varun committed rCOMM9ce8370c23e8: add deletePasswordUser to IdentityServiceClient (authored by varun).
add deletePasswordUser to IdentityServiceClient
Fri, Apr 19, 8:43 AM
varun closed D11589: [commRustModule] expose deletePasswordUser to JS.
Fri, Apr 19, 8:43 AM
varun closed D11588: [native_rust_library] implement delete_password_user method and move delete methods to a separate file.
Fri, Apr 19, 8:43 AM
varun committed rCOMM6ce80ef9594e: [commRustModule] expose deletePasswordUser to JS (authored by varun).
[commRustModule] expose deletePasswordUser to JS
Fri, Apr 19, 8:43 AM
varun committed rCOMM6357843146a4: [native_rust_library] implement delete_password_user method and move delete… (authored by varun).
[native_rust_library] implement delete_password_user method and move delete…
Fri, Apr 19, 8:43 AM
varun closed D11587: replace single deleteUser RPC with deleteWalletUser, deletePasswordUserStart, and deletePasswordUserFinish.
Fri, Apr 19, 8:43 AM
varun committed rCOMM65a6df827828: replace single deleteUser RPC with deleteWalletUser, deletePasswordUserStart… (authored by varun).
replace single deleteUser RPC with deleteWalletUser, deletePasswordUserStart…
Fri, Apr 19, 8:43 AM
varun added inline comments to D11587: replace single deleteUser RPC with deleteWalletUser, deletePasswordUserStart, and deletePasswordUserFinish.
Fri, Apr 19, 8:37 AM
varun closed D11695: [identity] remove OTKs in chronological order to make sure there are never more than 100 keys per olm account.
Fri, Apr 19, 8:28 AM
varun committed rCOMM6ed6865e5347: [identity] remove OTKs in chronological order to make sure there are never more… (authored by varun).
[identity] remove OTKs in chronological order to make sure there are never more…
Fri, Apr 19, 8:28 AM
varun added inline comments to D11695: [identity] remove OTKs in chronological order to make sure there are never more than 100 keys per olm account.
Fri, Apr 19, 8:27 AM

Thu, Apr 18

varun requested review of D11695: [identity] remove OTKs in chronological order to make sure there are never more than 100 keys per olm account.
Thu, Apr 18, 5:07 PM
varun accepted D11689: [lib/web] fix error handling indirection.
Thu, Apr 18, 12:24 PM
varun closed D11678: [identity] make sure otk exists when we delete it.
Thu, Apr 18, 11:36 AM
varun closed D11677: [identity] make sure we don't call refresh keys task twice when fetching content and notif keys.
Thu, Apr 18, 11:36 AM
varun committed rCOMMc4f179752442: [identity] make sure otk exists when we delete it (authored by varun).
[identity] make sure otk exists when we delete it
Thu, Apr 18, 11:36 AM
varun closed D11679: [identity] rename otk db method.
Thu, Apr 18, 11:36 AM
varun committed rCOMMe9292dd81be1: [identity] rename otk db method (authored by varun).
[identity] rename otk db method
Thu, Apr 18, 11:36 AM
varun committed rCOMMd3ab5fe7954d: [identity] make sure we don't call refresh keys task twice when fetching… (authored by varun).
[identity] make sure we don't call refresh keys task twice when fetching…
Thu, Apr 18, 11:36 AM
varun closed D11674: [identity] move otk db stuff to new sub module.
Thu, Apr 18, 11:36 AM
varun closed D11658: [identity] check that prekeys are formatted correctly.
Thu, Apr 18, 11:36 AM
varun committed rCOMM20a7303a4845: [identity] check that prekeys are formatted correctly (authored by varun).
[identity] check that prekeys are formatted correctly
Thu, Apr 18, 11:36 AM
varun committed rCOMM92a6da5a8b6a: [identity] move otk db stuff to new sub module (authored by varun).
[identity] move otk db stuff to new sub module
Thu, Apr 18, 11:36 AM

Wed, Apr 17

varun requested review of D11677: [identity] make sure we don't call refresh keys task twice when fetching content and notif keys.
Wed, Apr 17, 11:45 AM
varun requested review of D11679: [identity] rename otk db method.
Wed, Apr 17, 11:39 AM
varun requested review of D11678: [identity] make sure otk exists when we delete it.
Wed, Apr 17, 11:37 AM
varun requested review of D11674: [identity] move otk db stuff to new sub module.
Wed, Apr 17, 10:25 AM
varun updated the diff for D11658: [identity] check that prekeys are formatted correctly.

address feedback

Wed, Apr 17, 10:07 AM
varun closed D11657: check one-time key format.
Wed, Apr 17, 10:06 AM
varun committed rCOMMa6b05e1ac0c6: check one-time key format (authored by varun).
check one-time key format
Wed, Apr 17, 10:06 AM
varun closed D11608: [identity] otk db changes.
Wed, Apr 17, 10:06 AM
varun committed rCOMMcf700b99ee8d: [identity] otk db changes (authored by varun).
[identity] otk db changes
Wed, Apr 17, 10:06 AM

Sat, Apr 13

varun requested review of D11658: [identity] check that prekeys are formatted correctly.
Sat, Apr 13, 11:57 AM
varun published D11608: [identity] otk db changes for review.
Sat, Apr 13, 11:40 AM
varun requested review of D11657: check one-time key format.
Sat, Apr 13, 8:58 AM

Thu, Apr 11

varun closed D11625: [native] call setCommServicesAuthMetadata on wallet registration.
Thu, Apr 11, 11:11 AM
varun committed rCOMM2778952217d6: [native] call setCommServicesAuthMetadata on wallet registration (authored by varun).
[native] call setCommServicesAuthMetadata on wallet registration
Thu, Apr 11, 11:11 AM

Wed, Apr 10

varun requested review of D11625: [native] call setCommServicesAuthMetadata on wallet registration.
Wed, Apr 10, 1:30 PM
varun closed D11585: [lib] remove reference to nonexistent keyserver endpoint.
Wed, Apr 10, 12:08 PM
varun committed rCOMM1d328ce5d786: [lib] remove reference to nonexistent keyserver endpoint (authored by varun).
[lib] remove reference to nonexistent keyserver endpoint
Wed, Apr 10, 12:08 PM
varun closed D11623: [native] remove unnecessary include.
Wed, Apr 10, 12:07 PM
varun committed rCOMMcf5e7c2e5d1e: [native] remove unnecessary include (authored by varun).
[native] remove unnecessary include
Wed, Apr 10, 12:07 PM
varun requested review of D11623: [native] remove unnecessary include.
Wed, Apr 10, 11:04 AM
varun accepted D11570: [protos][identity] Add RPC for fetching multiple device lists.
Wed, Apr 10, 10:59 AM
varun accepted D11547: [protos] Refactor user Identity message type.
Wed, Apr 10, 10:17 AM
varun accepted D11573: [native] Clear auth metadata on logout.
In D11573#333844, @ashoat wrote:

For some reason setCommServicesAuthMetadata creates a job that is run on GlobalDBSingleton::instance

Looks like this code was introduced by @varun in D9224. @varun, can you clarify why you're running this on the DB thread given it doesn't perform any SQLite queries? I'm wondering if it's done that way on purpose to protect against some race condition or something. @tomek changes that logic here, so we should make sure we're not accidentally reverting something that was decided intentionally.

Wed, Apr 10, 10:15 AM

Mon, Apr 8

varun requested review of D11585: [lib] remove reference to nonexistent keyserver endpoint.
Mon, Apr 8, 8:25 AM
varun requested review of D11590: add deletePasswordUser to IdentityServiceClient.
Mon, Apr 8, 8:19 AM
varun requested review of D11589: [commRustModule] expose deletePasswordUser to JS.
Mon, Apr 8, 8:14 AM
varun requested review of D11588: [native_rust_library] implement delete_password_user method and move delete methods to a separate file.
Mon, Apr 8, 8:08 AM
varun requested review of D11587: replace single deleteUser RPC with deleteWalletUser, deletePasswordUserStart, and deletePasswordUserFinish.
Mon, Apr 8, 8:04 AM
varun abandoned D10657: [shared][protos] update UpdateUserPassword and DeleteUser workflows to match whitepaper.
Mon, Apr 8, 7:42 AM
varun abandoned D10738: [identity] identity service changes corresponding to proto updates.
Mon, Apr 8, 7:42 AM

Fri, Apr 5

varun requested changes to D11547: [protos] Refactor user Identity message type.
Fri, Apr 5, 7:21 AM

Thu, Apr 4

varun accepted D11548: [identity] Store social proof as a Map in DDB.
Thu, Apr 4, 8:22 PM
varun closed D11515: [keyserver] expose getFarcasterUsers client method to JS on keyserver.
Thu, Apr 4, 6:42 PM
varun committed rCOMMd36ab4dcb7f8: [keyserver] expose getFarcasterUsers client method to JS on keyserver (authored by varun).
[keyserver] expose getFarcasterUsers client method to JS on keyserver
Thu, Apr 4, 6:42 PM
varun closed D11514: [native] fix regression in error handling.
Thu, Apr 4, 6:42 PM
varun committed rCOMMb7b0e9b81b8a: [native] fix regression in error handling (authored by varun).
[native] fix regression in error handling
Thu, Apr 4, 6:42 PM
varun accepted D11549: [protos] Remove social_proof from IdentityKeyInfo.

amazing, thank you!

Thu, Apr 4, 12:22 PM
varun accepted D11556: Update comm_query_executor.wasm.
Thu, Apr 4, 12:10 PM
varun added inline comments to D11549: [protos] Remove social_proof from IdentityKeyInfo.
Thu, Apr 4, 11:40 AM
varun accepted D11551: [protos] Replace challengeResponse with nonce and signature pair.
Thu, Apr 4, 11:38 AM

Wed, Apr 3

varun added a comment to D11524: [native_rust_library] Cleanup remaining APIs.

in your testing were you able to see Rust logs in Xcode or your terminal? noticed we have #[instrument] for some functions in this library but i don't think we configure tracing anywhere...

Wed, Apr 3, 10:34 AM
varun accepted D11524: [native_rust_library] Cleanup remaining APIs.
Wed, Apr 3, 10:31 AM
varun accepted D11523: [native_rust_library] Move device list APIs to submodule.
Wed, Apr 3, 10:30 AM
varun accepted D11522: [native_rust_library] Move account actions to submodule.
Wed, Apr 3, 10:30 AM
varun accepted D11521: [native_rust_library] Move X3DH APIs to submodule.
Wed, Apr 3, 10:28 AM
varun accepted D11520: [native_rust_library] Move login APIs to submodule.
Wed, Apr 3, 10:27 AM
varun accepted D11519: [native_rust_library] Move password registration to submodule.
Wed, Apr 3, 10:26 AM
varun accepted D11518: [native_rust_library] Create ffi submodules for identity API.
Wed, Apr 3, 10:25 AM
varun accepted D11517: [native_rust_library] Create identity submodule.
Wed, Apr 3, 10:22 AM
varun accepted D11516: [native_rust_library] Extract utils module.
Wed, Apr 3, 10:21 AM
varun accepted D11546: [protos][identity] Make keyserver_info response non-optional.
Wed, Apr 3, 9:21 AM

Tue, Apr 2

varun added inline comments to D11514: [native] fix regression in error handling.
Tue, Apr 2, 12:29 PM
varun added inline comments to D11515: [keyserver] expose getFarcasterUsers client method to JS on keyserver.
Tue, Apr 2, 12:06 PM

Mon, Apr 1

varun accepted D11469: [native] Add LogInExistingDevice to native_rust_library.
Mon, Apr 1, 9:42 PM
varun accepted D11470: [native] Add JSI bindings for LogInExistingDevice RPC.
Mon, Apr 1, 9:35 PM
varun accepted D11466: [identity] Implement LogInExistingDevice RPC.
Mon, Apr 1, 9:28 PM
varun accepted D11471: [protos][identity] Add primary device keys to GetKeyserverKeys response.
Mon, Apr 1, 8:42 PM
varun accepted D11495: [lib][native] Pass FID from useRegistrationServerCall to identity service during registration.
Mon, Apr 1, 8:32 PM
Next